author Victor Porof <>
Thu, 04 Jul 2019 14:50:06 +0200
changeset 481448 c7e91f614eb78c4447a623f1c88a66421113ab07
child 483548 d9bce64ad7aca304c78949c548063b70c29f323a
permissions -rwxr-xr-x
Bug 1563300 - Add a js-format git commit hook, r=sylvestre, CLOSED TREE Differential Revision:

#!/usr/bin/env python
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at

import os
import subprocess
from subprocess import check_output, CalledProcessError
import sys

here = os.path.dirname(os.path.realpath(__file__))
topsrcdir = os.path.join(here, os.pardir, os.pardir)

EXTRA_PATHS = ("python/mozversioncontrol",)
sys.path[:0] = [os.path.join(topsrcdir, p) for p in EXTRA_PATHS]

from mozversioncontrol import get_repository_object, InvalidRepoPath

def run_js_format(hooktype, changedFiles):
        vcs = get_repository_object(topsrcdir)
    except InvalidRepoPath:

    if not changedFiles:
        # No files have been touched

    extensions = (".js", ".jsx", ".jsm")
    path_list = []
    for filename in sorted(changedFiles):
        # Ignore files unsupported in eslint and prettier
        if filename.endswith(extensions):

    if not path_list:
        # No files have been touched

    arguments = ["eslint", "--fix"] + path_list
    # On windows we need this to call the command in a shell, see Bug 1511594
    if == "nt":
        js_format_cmd = ["sh", "mach"] + arguments
        js_format_cmd = [os.path.join(topsrcdir, "mach")] + arguments
    if "commit" in hooktype:
        # don't prevent commits, just display the eslint and prettier results

        # Add the modified files back to the repo (expect a string)
        # one by one (fails otherwise, see bug #1541409)
        for f in path_list:

        return False
    print("warning: '{}' is not a valid js-format hooktype".format(hooktype))
    return False

def git():
    hooktype = os.path.basename(__file__)
    if hooktype == "":
        hooktype = "pre-push"

        changedFiles = check_output(
            ["git", "diff", "--staged", "--diff-filter=d", "--name-only", "HEAD"]
        # TODO we should detect if we are in a "add -p" mode and show a warning
        return run_js_format(hooktype, changedFiles)

    except CalledProcessError:
        print("Command to retrieve local files failed")
        return 1

if __name__ == "__main__":