mfbt/STYLE
author Nicholas Nethercote <nnethercote@mozilla.com>
Thu, 01 Sep 2016 15:01:16 +1000
changeset 312356 93657f8dedaafa384bcd49c71b52e195ec968de8
parent 195770 1b7d7dcf71e23f6ed68f10a72416f7dc5e58a6c2
child 331732 89b895c219f2b97fc0ded8877b30c337e697bdaa
permissions -rw-r--r--
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm. The new name makes the sense of the condition much clearer. E.g. compare: NS_WARN_IF_FALSE(!rv.Failed()); with: NS_WARNING_ASSERTION(!rv.Failed()); The new name also makes it clearer that it only has effect in debug builds, because that's standard for assertions.

MFBT uses standard Mozilla style, with the following exceptions.

- Some of the files use a lower-case letter at the start of function names.
  This is because MFBT used to use a different style, and was later converted
  to standard Mozilla style. These functions have not been changed to use an
  upper-case letter because it would cause a lot of churn in other parts of the
  codebase. However, new files should follow standard Mozilla style and use an
  upper-case letter at the start of function names.

- Imported third-party code (such as decimal/*, double-conversion/*, and lz4*)
  remains in its original style.