mfbt/decimal/comparison-with-nan.patch
 author Ben Kelly Tue, 10 Feb 2015 23:55:43 -0500 changeset 228679 48906d15a28eafe9a84d7607f17bcd6661a540fb parent 130915 f40200a441622c0c73be1eb5789b9c185da46cb5 child 284453 4929064f96e0bb142bf82e36230d1b0c8f570c9d permissions -rw-r--r--
Bug 1100398 P5 Provide NS_CloneInputStream() factory method in nsStreamUtils.h. r=froydnj

diff --git a/mfbt/decimal/Decimal.cpp b/mfbt/decimal/Decimal.cpp
--- a/mfbt/decimal/Decimal.cpp
+++ b/mfbt/decimal/Decimal.cpp
@@ -505,21 +505,25 @@ Decimal Decimal::operator/(const Decimal
if (remainder > divisor / 2)
++result;

return Decimal(resultSign, resultExponent, result);
}

bool Decimal::operator==(const Decimal& rhs) const
{
+    if (isNaN() || rhs.isNaN())
+        return false;
return m_data == rhs.m_data || compareTo(rhs).isZero();
}

bool Decimal::operator!=(const Decimal& rhs) const
{
+    if (isNaN() || rhs.isNaN())
+        return true;
if (m_data == rhs.m_data)
return false;
const Decimal result = compareTo(rhs);
if (result.isNaN())
return false;
return !result.isZero();
}

@@ -528,16 +532,18 @@ bool Decimal::operator<(const Decimal& r
const Decimal result = compareTo(rhs);
if (result.isNaN())
return false;
return !result.isZero() && result.isNegative();
}

bool Decimal::operator<=(const Decimal& rhs) const
{
+    if (isNaN() || rhs.isNaN())
+        return false;
if (m_data == rhs.m_data)
return true;
const Decimal result = compareTo(rhs);
if (result.isNaN())
return false;
return result.isZero() || result.isNegative();
}

@@ -546,16 +552,18 @@ bool Decimal::operator>(const Decimal& r
const Decimal result = compareTo(rhs);
if (result.isNaN())
return false;
return !result.isZero() && result.isPositive();
}

bool Decimal::operator>=(const Decimal& rhs) const
{
+    if (isNaN() || rhs.isNaN())
+        return false;
if (m_data == rhs.m_data)
return true;
const Decimal result = compareTo(rhs);
if (result.isNaN())
return false;
return result.isZero() || !result.isNegative();
}