author Nicholas Nethercote <nnethercote@mozilla.com>
Wed, 25 Oct 2017 10:22:38 +1100
changeset 387909 3d0093f961eec929caa370444cd0f7fcbfbc82bc
parent 177050 bbdc558a0bb261e2434a6f974cafcd39f544c639
child 402119 d5a5ad1dbbf2c53a80386e7397ba6b32153b2b8e
permissions -rw-r--r--
Bug 1410794 - Change some |string| occurrences in nsIPrefBranch.idl to |ACString|. r=erahm. This makes the code nicer. In particular, it removes many getter_Copies() calls. The patch also converts a lot of nsCStrings to nsAutoCString, which will avoid heap allocation in the common case. The patch also renames PREF_CopyCharPref() as PREF_GetCStringPref(), because it's actually getting a string, not a char, and that matches the existing GetCString() and GetDefaultCString() methods. Correspondingly, it also renames PREF_SetCharPref() as PREF_SetCStringPref(). The |aPrefName| arguments in nsIPrefBranch.idl remain as |string| because they almost always involve passing in C string literals, and passing "foo" is much nicer than passing NS_LITERAL_CSTRING("foo"). It's worth noting that early versions of this patch used |AUTF8String| instead of |ACString|. But it turns out that libpref stores prefs internally as Latin1. And |ACString| is compatible with Latin1 but |AUTF8String| isn't, because non-ASCII Latin1 strings are not valid UTF-8!

<?xml version="1.0"?>
<?xml-stylesheet href="chrome://global/skin" type="text/css"?>
<?xml-stylesheet href="chrome://mochikit/content/tests/SimpleTest/test.css"
<window title="Mozilla Bug 538242"

  <script type="application/javascript"
          src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js" />

<body  xmlns="http://www.w3.org/1999/xhtml">
<div id="content" style="display: none">
<pre id="test">

<script class="testbody" type="application/javascript">

if (navigator.platform.startsWith("Win")) {
  SimpleTest.expectAssertions(0, 1);


SimpleTest.waitForFocus(function () {
  if (navigator.platform.indexOf("Lin") != -1) {
    ok(true, "This test is disabled on Linux because it expects moving windows to be synchronous which is not guaranteed on Linux.");

  var win = window.open("window_bug538242.xul", "_blank", 
  SimpleTest.waitForFocus(function () {
    is(win.screenX, 100, "window should open at 100, 100");
    is(win.screenY, 100, "window should open at 100, 100");
    var [oldX, oldY] = [win.screenX, win.screenY];
    win.moveTo(0, 0);
    isnot(win.screenX, oldX, "window should have moved to a point near 0, 0");
    isnot(win.screenY, oldY, "window should have moved to a point near 0, 0");
  }, win);