author Ethan Glasser-Camp <>
Thu, 16 May 2019 15:04:25 +0000
changeset 474248 31cf332c9b21698336c5e6c18939a3a8b58a7902
parent 474247 0de43d5275d15b83e80fa021bac4175f85a5d3a4
permissions -rw-r--r--
Bug 1547034: Add userFacingName and userFacingDescription to schema r=mythmon Display these when available instead of generating one. We play some games here to let SinglePreferenceExperiment continue to validate according to the PreferenceExperiment schema. This is kind of ugly. Another approach might be to move the about-studies code that generates a description. I was hesitant to do this because it would mean losing the formatting. Depends on D29873 Differential Revision:

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

"use strict";

const {PreferenceExperimentAction} = ChromeUtils.import("resource://normandy/actions/PreferenceExperimentAction.jsm");
ChromeUtils.defineModuleGetter(this, "ActionSchemas", "resource://normandy/actions/schemas/index.js");
ChromeUtils.defineModuleGetter(this, "JsonSchemaValidator", "resource://gre/modules/components-utils/JsonSchemaValidator.jsm");

var EXPORTED_SYMBOLS = ["SinglePreferenceExperimentAction"];

 * The backwards-compatible version of the preference experiment that
 * can only accept a single preference.
class SinglePreferenceExperimentAction extends PreferenceExperimentAction {
  get schema() {
    return ActionSchemas["single-preference-experiment"];

  async _run(recipe) {
    const {
    } = recipe.arguments;

    const newArguments = {
      // The multiple-preference-experiment schema requires a string
      // name/description, which are necessary in the wire format, but
      // experiment objects can have null for these fields. Add some
      // filler fields here and remove them after validation.
      userFacingName: "temp-name",
      userFacingDescription: "temp-description",
      branches: => {
        const { value, ...branchProps } = branch;
        return {
          preferences: {
            [preferenceName]: {
              preferenceValue: value,

    const multiprefSchema = ActionSchemas["multiple-preference-experiment"];

    let [valid, validatedArguments] = JsonSchemaValidator.validateAndParseParameters(newArguments, multiprefSchema);
    if (!valid) {
      throw new Error(`Transformed arguments do not match schema. Original arguments: ${JSON.stringify(recipe.arguments)}, new arguments: ${JSON.stringify(newArguments)}, schema: ${JSON.stringify(multiprefSchema)}`);

    validatedArguments.userFacingName = null;
    validatedArguments.userFacingDescription = null;

    recipe.arguments = validatedArguments;

    const newRecipe = {
      arguments: validatedArguments,

    return super._run(newRecipe);