Bug 1225124 - Mozharness should not fatal exit if symbols URL cannot be found. r=ted
authorHenrik Skupin <mail@hskupin.info>
Wed, 09 Mar 2016 13:14:21 +0100
changeset 288575 fb639ac493bcdf7c92f6a06cffd161a9c95a031f
parent 288564 23bb5776bd4fffe41919d79f814a261254b5dbf1
child 288576 36b8d3c16c1776711703f1498902402b0bacf828
push id18174
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:44:58 +0000
treeherderfx-team@dd0baa33759d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1225124
milestone48.0a1
Bug 1225124 - Mozharness should not fatal exit if symbols URL cannot be found. r=ted MozReview-Commit-ID: Dr0PFTwfaIv
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -197,18 +197,20 @@ class TestingMixin(VirtualenvMixin, Buil
             try:
                 if symbols_url:
                     self._urlopen(symbols_url)
                     self.symbols_url = symbols_url
             except urllib2.URLError:
                 self.warning("Can't figure out symbols_url from installer_url: %s!" %
                              self.installer_url)
 
-        else:
-            self.fatal("Can't figure out symbols_url without an installer_url!")
+        # If no symbols URL can be determined let minidump_stackwalk query the symbols.
+        # As of now this only works for Nightly and release builds.
+        if not self.symbols_url:
+            self.warning("No symbols_url found. Let minidump_stackwalk query for symbols.")
 
         return self.symbols_url
 
     def _pre_config_lock(self, rw_config):
         for i, (target_file, target_dict) in enumerate(rw_config.all_cfg_files_and_dicts):
             if 'developer_config' in target_file:
                 self._developer_mode_changes(rw_config)