Bug 1300013 - Fix bogus tooltip for explicit/dom/memory-file-data/small memory report. r=erahm.
authorNicholas Nethercote <nnethercote@mozilla.com>
Mon, 05 Sep 2016 14:14:00 +1000
changeset 312698 f38efca9b50a6f4b88e0a59feb0435d1f13e4d5e
parent 312650 dbe4b47941c7b3d6298a0ead5e40dd828096c808
child 312699 3895ee3a6dc189518a53129239030f10ca249207
push id20458
push userphilringnalda@gmail.com
push dateTue, 06 Sep 2016 00:05:54 +0000
treeherderfx-team@8c8d47b20849 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1300013
milestone51.0a1
Bug 1300013 - Fix bogus tooltip for explicit/dom/memory-file-data/small memory report. r=erahm. The parameter was missing. The patch also clarifies the wording.
dom/base/File.cpp
--- a/dom/base/File.cpp
+++ b/dom/base/File.cpp
@@ -1131,20 +1131,21 @@ public:
     }
 
     if (smallObjectsTotal > 0) {
       aHandleReport->Callback(
         /* process */ NS_LITERAL_CSTRING(""),
         NS_LITERAL_CSTRING("explicit/dom/memory-file-data/small"),
         KIND_HEAP, UNITS_BYTES, smallObjectsTotal,
         nsPrintfCString(
-          "Memory used to back small memory files (less than %d bytes each).\n\n"
+          "Memory used to back small memory files (i.e. those taking up less "
+          "than %zu bytes of memory each).\n\n"
           "Note that the allocator may round up a memory file's length -- "
           "that is, an N-byte memory file may take up more than N bytes of "
-          "memory."),
+          "memory.", LARGE_OBJECT_MIN_SIZE),
         aData);
     }
 
     return NS_OK;
   }
 };
 
 NS_IMPL_ISUPPORTS(BlobImplMemoryDataOwnerMemoryReporter, nsIMemoryReporter)