Bug 1278725 - Restore original "up" arrow scaling r=liuche
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 09 Jun 2016 10:32:24 -0700
changeset 301448 e8d3a286f70ed10ad64ca62287115e55fe26c674
parent 301447 acffab47253e0c19e586ed827470fec2819f7112
child 301449 ebef91ed1cf0b4d9525ea33fda5d51d96a5c6d4d
push id19656
push userahunt@mozilla.com
push dateFri, 10 Jun 2016 15:18:35 +0000
treeherderfx-team@e8d3a286f70e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersliuche
bugs1278725
milestone50.0a1
Bug 1278725 - Restore original "up" arrow scaling r=liuche Before introducing the folder count, the bookmark folder icon was set as the drawable on a TextView. This actually resulted in scaling that doesn't preserve the aspect ratio. To reproduce this in the new ImageView (added when we switched to a two-line folder layout), we simply need to set the icon size explicitly and scale to fit the whole area (as opposed to setting two constraints and fitting while preserving aspect ratio). The folder/reading-list icons are unaffected as they already have the expected aspect-ratio, the back-arrow is now scaled as expected. MozReview-Commit-ID: Fl5JY3Lznau
mobile/android/base/resources/layout/two_line_folder_row.xml
--- a/mobile/android/base/resources/layout/two_line_folder_row.xml
+++ b/mobile/android/base/resources/layout/two_line_folder_row.xml
@@ -6,18 +6,18 @@
 <merge xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:tools="http://schemas.android.com/tools"
        xmlns:gecko="http://schemas.android.com/apk/res-auto"
        tools:context=".BrowserApp">
 
     <ImageView android:id="@+id/icon"
                android:src="@drawable/folder_closed"
                android:layout_width="24dp"
-               android:layout_height="24dp"
-               android:scaleType="fitCenter"
+               android:layout_height="18dp"
+               android:scaleType="fitXY"
                android:layout_margin="20dp"/>
 
     <LinearLayout android:layout_width="0dp"
                   android:layout_height="wrap_content"
                   android:layout_weight="1"
                   android:layout_gravity="center_vertical"
                   android:paddingRight="10dp"
                   android:orientation="vertical">