Bug 1301214 - Changed action of code coverage options to store_true and enabled code coverage for mochitest-devtools-chrome. r=gmierz2+560562,jmaher
authorCody Tran <cody_tran95@hotmail.com>
Mon, 24 Oct 2016 21:36:17 -0400
changeset 319952 e36c5db0191eba666619c5ae2895ece4d595a00b
parent 319951 aada0714c23626c5ed0da68372c6676198325472
child 319953 23e68db8afd7d33527306dfff7819332c1d1297f
push id20749
push userryanvm@gmail.com
push dateSat, 29 Oct 2016 13:21:21 +0000
treeherderfx-team@1b170b39ed6b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgmierz2
bugs1301214, 560562
milestone52.0a1
Bug 1301214 - Changed action of code coverage options to store_true and enabled code coverage for mochitest-devtools-chrome. r=gmierz2+560562,jmaher MozReview-Commit-ID: lJMQGfhfDA
taskcluster/ci/desktop-test/test-sets.yml
taskcluster/ci/desktop-test/tests.yml
testing/mozharness/mozharness/mozilla/testing/codecoverage.py
--- a/taskcluster/ci/desktop-test/test-sets.yml
+++ b/taskcluster/ci/desktop-test/test-sets.yml
@@ -85,11 +85,12 @@ windows-vm-tests:
 # note: on win, mochitest-a11y and mochitest-chrome come under mochitest-other
 # windows-hw-tests:
 #    - mochitest-clipboard
 #    - mochitest-gpu
 #    - mochitest-other
 
 ccov-code-coverage-tests:
     - mochitest-browser-chrome
+    - mochitest-devtools-chrome
 
 jsdcov-code-coverage-tests:
     - mochitest-browser-chrome
\ No newline at end of file
--- a/taskcluster/ci/desktop-test/tests.yml
+++ b/taskcluster/ci/desktop-test/tests.yml
@@ -320,33 +320,43 @@ mochitest-devtools-chrome:
     suite: mochitest/mochitest-devtools-chrome-chunked
     treeherder-symbol: tc-M(dt)
     loopback-video: true
     max-run-time: 5400
     chunks:
         by-test-platform:
             win.*: 8
             default: 10
+    run-on-projects:
+        by-test-platform:
+            linux64-ccov/opt: []
+            default: ['all']
     e10s:
         by-test-platform:
             # Bug 1242986: linux64/debug mochitest-devtools-chrome e10s is not greened up yet
             linux64/debug: false
+            linux64-ccov/opt: false
             default: both
     mozharness:
         script: desktop_unittest.py
         no-read-buildbot-config: true
         config:
             by-test-platform:
                 win.*:
                     - unittests/win_taskcluster_unittest.py
                 default:
                     - unittests/linux_unittest.py
                     - remove_executables.py
         extra-options:
-            - --mochitest-suite=mochitest-devtools-chrome-chunked
+            by-test-platform:
+                linux64-ccov/opt:
+                    - --mochitest-suite=mochitest-devtools-chrome-chunked
+                    - --code-coverage
+                default:
+                    - --mochitest-suite=mochitest-devtools-chrome-chunked
     instance-size:
         by-test-platform:
             # Bug 1281241: migrating to m3.large instances
             linux64-asan/opt: legacy
             default: default
     # Bug 1296086: high number of intermittents observed with software GL and large instances
     allow-software-gl-layers: false
 
--- a/testing/mozharness/mozharness/mozilla/testing/codecoverage.py
+++ b/testing/mozharness/mozharness/mozilla/testing/codecoverage.py
@@ -9,17 +9,17 @@ import tempfile
 
 from mozharness.base.script import (
     PreScriptAction,
     PostScriptAction,
 )
 
 code_coverage_config_options = [
     [["--code-coverage"],
-     {"action": "store",
+     {"action": "store_true",
       "dest": "code_coverage",
       "default": False,
       "help": "Whether test run should package and upload code coverage data."
       }],
 ]
 
 
 class CodeCoverageMixin(object):