Backed out changeset 68e3c6430121 (bug 1250709)
authorSteve Fink <sfink@mozilla.com>
Mon, 14 Mar 2016 21:58:24 -0700
changeset 288707 e2b9894a48e58ac147c98dbb50d049cc403795be
parent 288706 b56407b86b1340cfed2fb5b010f1ab53c7d32226
child 288708 ab0ed243cb7fc03373718fd7538416a83ca65a55
push id18174
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:44:58 +0000
treeherderfx-team@dd0baa33759d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1250709
milestone48.0a1
backs out68e3c64301214d4a656f9aadea250f13ec768480
Backed out changeset 68e3c6430121 (bug 1250709)
js/src/devtools/rootAnalysis/analyze.py
testing/taskcluster/scripts/builder/hazard-analysis.sh
--- a/js/src/devtools/rootAnalysis/analyze.py
+++ b/js/src/devtools/rootAnalysis/analyze.py
@@ -101,20 +101,16 @@ JOBS = { 'dbs':
                '--build-root=%(objdir)s',
                '--wrap-dir=%(sixgill)s/scripts/wrap_gcc',
                '--work-dir=work',
                '-b', '%(sixgill_bin)s',
                '--buildcommand=%(buildcommand)s',
                '.'),
               ()),
 
-         'list-dbs':
-             (('ls', '-l'),
-              ()),
-
          'callgraph':
              (('%(js)s', '%(analysis_scriptdir)s/computeCallgraph.js'),
               'callgraph.txt'),
 
          'gcFunctions':
              (('%(js)s', '%(analysis_scriptdir)s/computeGCFunctions.js', '%(callgraph)s',
                '[gcFunctions]', '[gcFunctions_list]', '[gcEdges]', '[suppressedFunctions_list]'),
               ('gcFunctions.txt', 'gcFunctions.lst', 'gcEdges.txt', 'suppressedFunctions.lst')),
--- a/testing/taskcluster/scripts/builder/hazard-analysis.sh
+++ b/testing/taskcluster/scripts/builder/hazard-analysis.sh
@@ -11,43 +11,28 @@ ANALYSIS_SRCDIR=$JS_SRCDIR/devtools/root
 PYTHON=python2.7
 if ! which $PYTHON; then
     PYTHON=python
 fi
 
 export CC="$GECKO_DIR/gcc/bin/gcc"
 export CXX="$GECKO_DIR/gcc/bin/g++"
 
-function check_commit_msg () {
-    hg --cwd "$GECKO_DIR" log -r. --template '{desc}\n' | grep -q -- "$1"
-}
-
-if check_commit_msg "--dep"; then
-    HAZ_DEP=1
-fi
-
 function build_js_shell () {
     ( cd $JS_SRCDIR; autoconf-2.13 )
-    if [[ -z "$HAZ_DEP" ]]; then
-        [ -d $HAZARD_SHELL_OBJDIR ] && rm -rf $HAZARD_SHELL_OBJDIR
-    fi
     mkdir -p $HAZARD_SHELL_OBJDIR || true
     cd $HAZARD_SHELL_OBJDIR
     $JS_SRCDIR/configure --enable-optimize --disable-debug --enable-ctypes --enable-nspr-build --without-intl-api --with-ccache
     make -j4
 }
 
 function configure_analysis () {
     local analysis_dir
     analysis_dir="$1"
 
-    if [[ -z "$HAZ_DEP" ]]; then
-        [ -d "$analysis_dir" ] && rm -rf "$analysis_dir"
-    fi
-
     mkdir -p "$analysis_dir" || true
     (
         cd "$analysis_dir"
         cat > defaults.py <<EOF
 js = "$HAZARD_SHELL_OBJDIR/dist/bin/js"
 analysis_scriptdir = "$ANALYSIS_SRCDIR"
 objdir = "$MOZ_OBJDIR"
 source = "$GECKO_DIR"
@@ -58,20 +43,16 @@ EOF
 }
 
 function run_analysis () {
     local analysis_dir
     analysis_dir="$1"
     local build_type
     build_type="$2"
 
-    if [[ -z "$HAZ_DEP" ]]; then
-        [ -d $MOZ_OBJDIR ] && rm -rf $MOZ_OBJDIR
-    fi
-
     (
         cd "$analysis_dir"
         $PYTHON "$ANALYSIS_SRCDIR/analyze.py" --buildcommand="$GECKO_DIR/testing/mozharness/scripts/spidermonkey/build.${build_type}"
     )
 }
 
 function grab_artifacts () {
     local analysis_dir
@@ -86,21 +67,18 @@ function grab_artifacts () {
         # Do not error out if no files found
         shopt -s nullglob
         set +e
         for f in *.txt *.lst; do
             gzip -9 -c "$f" > "${artifacts}/$f.gz"
         done
 
         # Check whether the user requested .xdb file upload in the top commit comment
-        if check_commit_msg "--upload-xdbs"; then
-            HAZ_UPLOAD_XDBS=1
-        fi
 
-        if [ -n "$HAZ_UPLOAD_XDBS" ]; then
+        if hg --cwd "$GECKO_DIR" log -l1 --template '{desc}\n' | grep -q -- '--upload-xdbs'; then
             for f in *.xdb; do
                 bzip2 -c "$f" > "${artifacts}/$f.bz2"
             done
         fi
     )
 }
 
 function check_hazards () {