Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r=jesup
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 16:05:06 -0700
changeset 288693 df2429673c945e1fe476c8056547cca787e727d7
parent 288692 2f3cc8818587cc3b25d196cb61a2063f37227ab9
child 288694 04a9056213bd331398ba8aecf8940fb2d8388989
push id18174
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:44:58 +0000
treeherderfx-team@dd0baa33759d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjesup
bugs1256482
milestone48.0a1
Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r=jesup As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings, of course. Given that the warning is in WebRTC which is third party code, there isn't much we can do about the warning. However, Google is building Chrome with Visual Studio 2015, so I wouldn't be surprised if this were fixed upstream or will be fixed upstream. Then again, we allow warnings when building WebRTC. So perhaps not. MozReview-Commit-ID: G6JP9fkCzfn
dom/media/webrtc/moz.build
--- a/dom/media/webrtc/moz.build
+++ b/dom/media/webrtc/moz.build
@@ -87,10 +87,12 @@ if CONFIG['GNU_CC'] or CONFIG['CLANG_CL'
         '-Wno-error=attributes'
     ]
 
 FINAL_LIBRARY = 'xul'
 
 if CONFIG['_MSC_VER']:
     CXXFLAGS += [
         '-wd4275', # non dll-interface class used as base for dll-interface class
+        '-wd4312', # This is intended as a temporary hack to support building with VS2015
+                   # 'reinterpret_cast': conversion from 'DWORD' to 'HANDLE' of greater size
     ]
     DEFINES['__PRETTY_FUNCTION__'] = '__FUNCSIG__'