Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 16 Jun 2015 20:37:17 -0700
changeset 249193 de50d9ec609e84e9feb2a78a4b1369a0eb85f6a1
parent 249192 759bfacec785851971bba8381d6bc7e938de27a2
child 249215 89fa4cae20d13106a304c8332fd4f2757476284a
push id13606
push usermichael.l.comella@gmail.com
push dateWed, 17 Jun 2015 15:57:51 +0000
treeherderfx-team@de50d9ec609e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1170884
milestone41.0a1
Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh This falls under the InefficientWeight rule. Changes completed via Android Studio quick-fix.
mobile/android/base/resources/layout/fxaccount_status_error_preference.xml
mobile/android/base/resources/layout/home_remote_tabs_group.xml
mobile/android/base/resources/layout/notification_icon_text.xml
mobile/android/base/resources/layout/notification_progress.xml
mobile/android/base/resources/layout/notification_progress_text.xml
mobile/android/base/resources/layout/preference_rightalign_icon.xml
mobile/android/base/resources/layout/preference_search_tip.xml
mobile/android/base/resources/layout/search_suggestions_row.xml
mobile/android/base/resources/layout/site_identity.xml
--- a/mobile/android/base/resources/layout/fxaccount_status_error_preference.xml
+++ b/mobile/android/base/resources/layout/fxaccount_status_error_preference.xml
@@ -19,17 +19,17 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center"
             android:minWidth="48dip"
             android:padding="10dip" />
     </LinearLayout>
 
     <RelativeLayout
-        android:layout_width="wrap_content"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginBottom="6dip"
         android:layout_marginLeft="15dip"
         android:layout_marginRight="6dip"
         android:layout_marginTop="6dip"
         android:layout_weight="1" >
 
         <TextView
--- a/mobile/android/base/resources/layout/home_remote_tabs_group.xml
+++ b/mobile/android/base/resources/layout/home_remote_tabs_group.xml
@@ -19,17 +19,17 @@
         android:layout_width="50dp"
         android:layout_height="50dp"
         android:layout_marginLeft="5dp"
         android:layout_gravity="center_vertical"
         android:scaleType="center"
         tools:src="@drawable/sync_mobile"/>
 
     <LinearLayout
-        android:layout_width="match_parent"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
         android:orientation="vertical">
 
         <org.mozilla.gecko.widget.FadedSingleColorTextView
             android:id="@+id/client"
             style="@style/Widget.TwoLinePageRow.Title"
             android:layout_width="match_parent"
--- a/mobile/android/base/resources/layout/notification_icon_text.xml
+++ b/mobile/android/base/resources/layout/notification_icon_text.xml
@@ -15,17 +15,17 @@
 
         <ImageView android:id="@+id/notification_image"
                    android:layout_width="25dp"
                    android:layout_height="25dp"
                    android:scaleType="fitCenter"/>
 
         <TextView android:id="@+id/notification_title"
                   android:textAppearance="@android:style/TextAppearance.StatusBar.EventContent.Title"
-                  android:layout_width="match_parent"
+                  android:layout_width="0dp"
                   android:layout_height="wrap_content"
                   android:layout_weight="1"
                   android:singleLine="true"
                   android:ellipsize="marquee"
                   android:fadingEdge="horizontal"
                   android:paddingLeft="4dp"/>
 
     </LinearLayout>
--- a/mobile/android/base/resources/layout/notification_progress.xml
+++ b/mobile/android/base/resources/layout/notification_progress.xml
@@ -16,17 +16,17 @@
 
         <ImageView android:id="@+id/notification_image"
                    android:layout_width="25dp"
                    android:layout_height="25dp"
                    android:scaleType="fitCenter"/>
 
         <TextView android:id="@+id/notification_title"
                   android:textAppearance="@android:style/TextAppearance.StatusBar.EventContent.Title"
-                  android:layout_width="match_parent"
+                  android:layout_width="0dp"
                   android:layout_height="wrap_content"
                   android:layout_weight="1"
                   android:singleLine="true"
                   android:ellipsize="marquee"
                   android:fadingEdge="horizontal"
                   android:paddingLeft="10dp"/>
 
     </LinearLayout>
--- a/mobile/android/base/resources/layout/notification_progress_text.xml
+++ b/mobile/android/base/resources/layout/notification_progress_text.xml
@@ -15,17 +15,17 @@
 
         <ImageView android:id="@+id/notification_image"
                    android:layout_width="25dp"
                    android:layout_height="25dp"
                    android:scaleType="fitCenter"/>
 
         <TextView android:id="@+id/notification_title"
                   android:textAppearance="@android:style/TextAppearance.StatusBar.EventContent.Title"
-                  android:layout_width="match_parent"
+                  android:layout_width="0dp"
                   android:layout_height="wrap_content"
                   android:layout_weight="1"
                   android:singleLine="true"
                   android:ellipsize="marquee"
                   android:fadingEdge="horizontal"
                   android:paddingLeft="4dp"/>
 
     </LinearLayout>
--- a/mobile/android/base/resources/layout/preference_rightalign_icon.xml
+++ b/mobile/android/base/resources/layout/preference_rightalign_icon.xml
@@ -8,17 +8,17 @@
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
       android:layout_width="match_parent"
       android:layout_height="wrap_content"
       android:orientation="horizontal"
       android:paddingRight="?android:attr/scrollbarSize">
 
     <RelativeLayout
-        android:layout_width="match_parent"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:gravity="right"
         android:layout_marginLeft="15dip"
         android:layout_marginRight="6dip"
         android:layout_marginTop="6dip"
         android:layout_marginBottom="6dip"
         android:paddingRight="6dip"
         android:layout_weight="1">
--- a/mobile/android/base/resources/layout/preference_search_tip.xml
+++ b/mobile/android/base/resources/layout/preference_search_tip.xml
@@ -6,17 +6,17 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
               android:orientation="horizontal"
               android:layout_width="match_parent"
               android:layout_height="match_parent"
               android:paddingRight="?android:attr/scrollbarSize">
 
     <TextView android:id="@+id/label_search_hint"
               android:layout_height="wrap_content"
-              android:layout_width="wrap_content"
+              android:layout_width="0dp"
               android:text="@string/pref_search_hint"
               android:layout_marginTop="5dip"
               android:layout_marginBottom="6dip"
               android:layout_marginLeft="15dip"
               android:layout_marginRight="6dip"
               android:paddingTop="8dp"
               android:paddingBottom="8dp"
               android:paddingRight="6dip"
--- a/mobile/android/base/resources/layout/search_suggestions_row.xml
+++ b/mobile/android/base/resources/layout/search_suggestions_row.xml
@@ -8,17 +8,17 @@
     android:layout_height="wrap_content"
     android:background="@drawable/search_row_background"
     android:padding="@dimen/search_row_padding"
     android:descendantFocusability="blocksDescendants"
     android:orientation="horizontal">
 
     <TextView
         android:id="@+id/auto_complete_row_text"
-        android:layout_width="wrap_content"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
         android:textSize="@dimen/query_text_size"/>
 
     <ImageButton
         android:id="@+id/auto_complete_row_jump_button"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
--- a/mobile/android/base/resources/layout/site_identity.xml
+++ b/mobile/android/base/resources/layout/site_identity.xml
@@ -14,17 +14,17 @@
                   android:padding="@dimen/doorhanger_padding">
 
         <ImageView android:id="@+id/larry"
                    android:layout_width="@dimen/doorhanger_icon_size"
                    android:layout_height="@dimen/doorhanger_icon_size"
                    android:src="@drawable/larry"
                    android:paddingRight="@dimen/doorhanger_padding"/>
 
-        <LinearLayout android:layout_width="match_parent"
+        <LinearLayout android:layout_width="0dp"
                      android:layout_height="wrap_content"
                      android:orientation="vertical"
                      android:layout_weight="1.0">
 
             <include layout="@layout/site_identity_unknown" />
 
             <LinearLayout android:id="@+id/site_identity_known_container"
                           android:layout_width="match_parent"