Bug 1113786 - Find-in-Page Bar doesn't respect privacy, r=mfinkle
authorMark Capella <markcapella@twcny.rr.com>
Sat, 10 Jan 2015 08:55:30 -0500
changeset 223078 d606591cf149d7452176fa49b3621b3ecfaa1c42
parent 223077 2815bfd2ccb58c382e0207f451d989a973e44e57
child 223079 9beacf61fe3dce6945f8f4630aa32ea3ee4e0fc2
push id10751
push usermarkcapella@twcny.rr.com
push dateSat, 10 Jan 2015 13:55:38 +0000
treeherderfx-team@d606591cf149 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs1113786
milestone37.0a1
Bug 1113786 - Find-in-Page Bar doesn't respect privacy, r=mfinkle
mobile/android/base/FindInPageBar.java
--- a/mobile/android/base/FindInPageBar.java
+++ b/mobile/android/base/FindInPageBar.java
@@ -91,16 +91,19 @@ public class FindInPageBar extends Linea
         mFindText.requestFocus();
 
         // handleMessage() receives response message and determines initial state of softInput
         GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("TextSelection:Get", REQUEST_ID));
         GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("FindInPage:Opened", null));
     }
 
     public void hide() {
+        // Always clear the Find string, primarily for privacy.
+        mFindText.setText("");
+
         setVisibility(GONE);
         getInputMethodManager(mFindText).hideSoftInputFromWindow(mFindText.getWindowToken(), 0);
         GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("FindInPage:Closed", null));
     }
 
     private InputMethodManager getInputMethodManager(View view) {
         Context context = view.getContext();
         return (InputMethodManager) context.getSystemService(Context.INPUT_METHOD_SERVICE);