Bug 1241614 - don't overflow:auto the container, use em to size the dialog to avoid hidpi visibility issues, r=dolske,ttaubert
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 22 Jan 2016 11:18:54 +0000
changeset 281608 c6bd409ec6555a3f38de8ab9183c3f69a7f1668e
parent 281607 c82223cbd377694cc761d1a2013c25130791abad
child 281609 627ac298f23043bd185b802fe042dee054c8e1b2
push id17244
push usergijskruitbosch@gmail.com
push dateTue, 26 Jan 2016 17:22:28 +0000
treeherderfx-team@050018247a87 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdolske, ttaubert
bugs1241614
milestone47.0a1
Bug 1241614 - don't overflow:auto the container, use em to size the dialog to avoid hidpi visibility issues, r=dolske,ttaubert
security/manager/pki/resources/content/exceptionDialog.xul
--- a/security/manager/pki/resources/content/exceptionDialog.xul
+++ b/security/manager/pki/resources/content/exceptionDialog.xul
@@ -4,36 +4,36 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <?xml-stylesheet href="chrome://global/skin/" type="text/css"?>
 
 <!DOCTYPE dialog SYSTEM "chrome://pippki/locale/certManager.dtd">
 
 <dialog id="exceptiondialog"
         windowtype="mozilla:exceptiondialog"
-        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" 
+        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         title="&exceptionMgr.title;"
         buttons="cancel,extra1,extra2"
         buttonlabelextra1="&exceptionMgr.exceptionButton.label;"
         buttonaccesskeyextra1="&exceptionMgr.exceptionButton.accesskey;"
-        style="width: 500px; height: 480px;"
+        style="width: 46em; min-height: 38em;"
         onload="initExceptionDialog();"
         ondialogextra1="addException();"
         ondialogextra2="checkCert();"
         persist="screenX screenY width height"
         defaultButton="extra2">
 
   <stringbundleset id="stringbundleset">
     <stringbundle id="pippki_bundle" src="chrome://pippki/locale/pippki.properties"/>
     <stringbundle id="brand_bundle" src="chrome://branding/locale/brand.properties"/>
   </stringbundleset>
 
   <script type="application/javascript" src="chrome://pippki/content/pippki.js"/>
   <script type="application/javascript" src="chrome://pippki/content/exceptionDialog.js"/>
-  
+
   <hbox>
     <vbox>
 #ifdef MOZ_WIDGET_GTK
       <image src="moz-icon://stock/gtk-dialog-warning?size=dialog"/>
 #else
       <image src="chrome://global/skin/icons/warning-large.png"/>
 #endif
       <spacer flex="1"/>
@@ -58,34 +58,32 @@
       <button id="checkCertButton" disabled="true" dlgtype="extra2"
               accesskey="&exceptionMgr.certlocation.accesskey;"
               label="&exceptionMgr.certlocation.download;"/>
     </hbox>
   </groupbox>
 
   <groupbox id="certStatusGroupBox" flex="1">
     <caption label="&exceptionMgr.certstatus.caption;"/>
-    <vbox  style="overflow: auto;" flex="1">
-      <hbox>
-        <description id="headerDescription" style="white-space: pre-wrap;"
-                     flex="1"/>
-        <vbox>
-          <button id="viewCertButton" label="&exceptionMgr.certstatus.viewCert;"
-                  accesskey="&exceptionMgr.certstatus.accesskey;"
-                  disabled="true" oncommand="viewCertButtonClick();"/>
-        </vbox>
-      </hbox>      
-      <description id="statusDescription"
-                   style="font-weight: bold; padding-bottom: 1em;"/>
-      <description id="statusLongDescription" style="white-space: pre-wrap;"/>
-      <description id="status2Description"
-                   style="font-weight: bold; padding-bottom: 1em;"/>
-      <description id="status2LongDescription" style="white-space: pre-wrap;"/>
-      <description id="status3Description" 
-                   style="font-weight: bold; padding-bottom: 1em;"/>
-      <description id="status3LongDescription" style="white-space: pre-wrap;"/>
-      <spacer flex="1"/>
-    </vbox>
+    <hbox>
+      <description id="headerDescription" style="white-space: pre-wrap;"
+                   flex="1"/>
+      <vbox>
+        <button id="viewCertButton" label="&exceptionMgr.certstatus.viewCert;"
+                accesskey="&exceptionMgr.certstatus.accesskey;"
+                disabled="true" oncommand="viewCertButtonClick();"/>
+      </vbox>
+    </hbox>
+    <description id="statusDescription"
+                 style="font-weight: bold; padding-bottom: 1em;"/>
+    <description id="statusLongDescription" style="white-space: pre-wrap;"/>
+    <description id="status2Description"
+                 style="font-weight: bold; padding-bottom: 1em;"/>
+    <description id="status2LongDescription" style="white-space: pre-wrap;"/>
+    <description id="status3Description"
+                 style="font-weight: bold; padding-bottom: 1em;"/>
+    <description id="status3LongDescription" style="white-space: pre-wrap;"/>
+    <spacer flex="1"/>
     <checkbox id="permanent" disabled="true"
               label="&exceptionMgr.permanent.label;"
               accesskey="&exceptionMgr.permanent.accesskey;"/>
   </groupbox>
 </dialog>