Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r=poiru
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 17:56:28 -0700
changeset 288682 c19d7ab6f3bac7d10cef454fc480893004d3fe75
parent 288681 27a4c68860fd1a25a85751b0b01352b9cba5ee05
child 288683 8882a15789b0eb9d5ff5bd1728fd38b2c9cc4d6b
push id18174
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:44:58 +0000
treeherderfx-team@dd0baa33759d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspoiru
bugs1256505
milestone48.0a1
Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: 70QwT9y6eb2
layout/base/moz.build
--- a/layout/base/moz.build
+++ b/layout/base/moz.build
@@ -196,8 +196,13 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'andr
 FINAL_LIBRARY = 'xul'
 
 BROWSER_CHROME_MANIFESTS += ['tests/browser.ini']
 MARIONETTE_LAYOUT_MANIFESTS += ['tests/marionette/manifest.ini']
 MOCHITEST_MANIFESTS += ['tests/mochitest.ini']
 MOCHITEST_CHROME_MANIFESTS += ['tests/chrome/chrome.ini']
 
 CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # 'type cast': conversion from 'unsigned int' to 'void *' of greater size
+    CXXFLAGS += ['-wd4312']