Bug 1269517 - Remove header checks from old-configure that are no longer needed. r=glandium
authorChris Manchester <cmanchester@mozilla.com>
Tue, 26 Jul 2016 15:27:19 -0700
changeset 306810 b50c01f263a5c8f2d55b2bad0603a70b10ae4981
parent 306809 2081a003f2d83f456ae6a8d1bfa77157508960b7
child 306811 550fc29355f102a40f897b958fee7c2776a99fb3
push id20130
push usercbook@mozilla.com
push dateWed, 27 Jul 2016 14:41:09 +0000
treeherderfx-team@714cca6d49d0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1269517
milestone50.0a1
Bug 1269517 - Remove header checks from old-configure that are no longer needed. r=glandium This patch removes the checks for compat.h, sys/bittypes.h, gnu/libc-version.h, X11/XKBlib.h, sys/sysmacros.h, and sys/cdefs.h from old-configure, because they are not checked meaningfully in the tree. The check for memory.h is removed, because while there are checks for HAVE_MEMORY_H in the tree, they are in places this is set by a third party build system. The check for io.h is also removed, because while there are checks for HAVE_IO_H, they're only relevant on windows, where this is set manually in old-configure. MozReview-Commit-ID: MOI50CP00k
build/autoconf/mozcommonheader.m4
js/src/old-configure.in
old-configure.in
--- a/build/autoconf/mozcommonheader.m4
+++ b/build/autoconf/mozcommonheader.m4
@@ -1,9 +1,8 @@
 dnl This Source Code Form is subject to the terms of the Mozilla Public
 dnl License, v. 2.0. If a copy of the MPL was not distributed with this
 dnl file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 AC_DEFUN(MOZ_CHECK_COMMON_HEADERS,
-	MOZ_CHECK_HEADERS(sys/byteorder.h compat.h getopt.h sys/bitypes.h \
-        memory.h unistd.h gnu/libc-version.h nl_types.h malloc.h \
-        X11/XKBlib.h io.h cpuid.h)
+	MOZ_CHECK_HEADERS(sys/byteorder.h getopt.h unistd.h nl_types.h \
+        malloc.h cpuid.h)
 )
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -1244,18 +1244,16 @@ if test "x$enable_dtrace" = "xyes"; then
   if test -n "$HAVE_DTRACE"; then
       AC_DEFINE(INCLUDE_MOZILLA_DTRACE)
   else
       AC_MSG_ERROR([dtrace enabled but sys/sdt.h not found]);
   fi
 fi
 AC_SUBST(HAVE_DTRACE)
 
-MOZ_CHECK_HEADERS(sys/cdefs.h)
-
 MOZ_LINUX_PERF_EVENT
 
 dnl Checks for libraries.
 dnl ========================================================
 AC_CHECK_LIB(c_r, gethostbyname_r)
 
 dnl We don't want to link with libdl even if it's present on OS X, since
 dnl it's not used and not part of the default installation. OS/2 has dlfcn
--- a/old-configure.in
+++ b/old-configure.in
@@ -1577,17 +1577,17 @@ bitrig*|dragonfly*|freebsd*|openbsd*)
     ;;
 esac
 MOZ_CHECK_COMMON_HEADERS
 
 dnl These are all the places some variant of statfs can be hiding.
 MOZ_CHECK_HEADERS(sys/statvfs.h sys/statfs.h sys/vfs.h sys/mount.h)
 
 dnl Quota support
-MOZ_CHECK_HEADERS(sys/quota.h sys/sysmacros.h)
+MOZ_CHECK_HEADERS(sys/quota.h)
 MOZ_CHECK_HEADERS([linux/quota.h],,,[#include <sys/socket.h>])
 
 dnl SCTP support - needs various network include headers
 MOZ_CHECK_HEADERS([linux/if_addr.h linux/rtnetlink.h],,,[#include <sys/socket.h>])
 MOZ_CHECK_HEADERS(sys/queue.h)
 
 MOZ_CHECK_HEADERS(sys/types.h netinet/in.h byteswap.h)