Bug 1107814 - Part 1: Mark more directories as FAIL_ON_WARNINGS for all compilers. r=gps
authorChris Peterson <cpeterson@mozilla.com>
Thu, 04 Dec 2014 16:24:03 -0800
changeset 218807 b14b9b335d4e1cf2a6e6ee0af1739b49506906ac
parent 218806 54e57eca5929cc83276535ae0c4d41f54ed84e48
child 218808 2147895c5dc47c9a416991711c82c41ea7ca888b
push id10304
push usercbook@mozilla.com
push dateTue, 09 Dec 2014 12:18:28 +0000
treeherderfx-team@19855f676807 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1107814
milestone37.0a1
Bug 1107814 - Part 1: Mark more directories as FAIL_ON_WARNINGS for all compilers. r=gps
accessible/base/moz.build
accessible/generic/moz.build
accessible/html/moz.build
accessible/mac/moz.build
accessible/xul/moz.build
caps/moz.build
chrome/moz.build
dom/media/android/moz.build
dom/media/systemservices/moz.build
dom/media/webspeech/recognition/moz.build
dom/plugins/ipc/interpose/moz.build
dom/wifi/moz.build
dom/xul/templates/moz.build
extensions/auth/moz.build
extensions/cookie/moz.build
extensions/permissions/moz.build
extensions/pref/autoconfig/src/moz.build
gfx/tests/gtest/moz.build
gfx/ycbcr/moz.build
intl/chardet/moz.build
intl/locale/mac/moz.build
intl/locale/moz.build
intl/lwbrk/moz.build
intl/strres/moz.build
intl/unicharutil/moz.build
intl/unicharutil/util/internal/moz.build
modules/libjar/zipwriter/moz.build
modules/libpref/moz.build
profile/dirserviceprovider/moz.build
tools/profiler/tests/gtest/moz.build
xpcom/reflect/xptinfo/moz.build
xpcom/sample/moz.build
xpcom/string/moz.build
--- a/accessible/base/moz.build
+++ b/accessible/base/moz.build
@@ -92,8 +92,10 @@ else:
     ]
 
 FINAL_LIBRARY = 'xul'
 
 if CONFIG['MOZ_ENABLE_GTK']:
     CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
 
 include('/ipc/chromium/chromium-config.mozbuild')
+
+FAIL_ON_WARNINGS = True
--- a/accessible/generic/moz.build
+++ b/accessible/generic/moz.build
@@ -52,8 +52,10 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'co
 else:
     LOCAL_INCLUDES += [
         '/accessible/other',
     ]
 
 FINAL_LIBRARY = 'xul'
 
 include('/ipc/chromium/chromium-config.mozbuild')
+
+FAIL_ON_WARNINGS = True
--- a/accessible/html/moz.build
+++ b/accessible/html/moz.build
@@ -38,8 +38,10 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'co
         '/accessible/mac',
     ]
 else:
     LOCAL_INCLUDES += [
         '/accessible/other',
     ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/accessible/mac/moz.build
+++ b/accessible/mac/moz.build
@@ -33,8 +33,10 @@ LOCAL_INCLUDES += [
     '/accessible/xul',
     '/layout/generic',
     '/layout/xul',
     '/widget',
     '/widget/cocoa',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/accessible/xul/moz.build
+++ b/accessible/xul/moz.build
@@ -43,8 +43,10 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'co
         '/accessible/mac',
     ]
 else:
     LOCAL_INCLUDES += [
         '/accessible/other',
     ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/caps/moz.build
+++ b/caps/moz.build
@@ -33,8 +33,9 @@ MSVC_ENABLE_PGO = True
 
 LOCAL_INCLUDES += [
     '/dom/base',
     '/js/xpconnect/src',
 ]
 
 FINAL_LIBRARY = 'xul'
 
+FAIL_ON_WARNINGS = True
--- a/chrome/moz.build
+++ b/chrome/moz.build
@@ -37,8 +37,10 @@ GENERATED_INCLUDES += [
 LOCAL_INCLUDES += [
     '/netwerk/base/src',
     '/netwerk/protocol/res',
     '/xpcom/components'
 ]
 
 if CONFIG['MOZ_ENABLE_GTK']:
     CXXFLAGS += CONFIG['TK_CFLAGS']
+
+FAIL_ON_WARNINGS = True
--- a/dom/media/android/moz.build
+++ b/dom/media/android/moz.build
@@ -20,8 +20,10 @@ UNIFIED_SOURCES += [
 ]
 
 LOCAL_INCLUDES += [
     '/dom/base',
     '/dom/html',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/dom/media/systemservices/moz.build
+++ b/dom/media/systemservices/moz.build
@@ -35,8 +35,10 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk
             'frameworks/wilhelm/include',
             'system/media/wilhelm/include',
         ]
     ]
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/dom/media/webspeech/recognition/moz.build
+++ b/dom/media/webspeech/recognition/moz.build
@@ -38,8 +38,10 @@ UNIFIED_SOURCES += [
 
 LOCAL_INCLUDES += [
     '/dom/base',
 ]
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/dom/plugins/ipc/interpose/moz.build
+++ b/dom/plugins/ipc/interpose/moz.build
@@ -8,8 +8,10 @@ SharedLibrary('plugin_child_interpose')
 
 UNIFIED_SOURCES += [ "%s.mm" % (LIBRARY_NAME) ]
 
 UNIFIED_SOURCES += [
     'plugin_child_quirks.mm',
 ]
 
 OS_LIBS += ['-framework Carbon']
+
+FAIL_ON_WARNINGS = True
--- a/dom/wifi/moz.build
+++ b/dom/wifi/moz.build
@@ -33,8 +33,10 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk
     UNIFIED_SOURCES = [
         'WifiCertService.cpp',
         'WifiHotspotUtils.cpp',
         'WifiProxyService.cpp',
         'WifiUtils.cpp',
     ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/dom/xul/templates/moz.build
+++ b/dom/xul/templates/moz.build
@@ -50,8 +50,10 @@ MSVC_ENABLE_PGO = True
 
 LOCAL_INCLUDES += [
     '/dom/base',
     '/dom/xul',
     '/layout/xul/tree/',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/extensions/auth/moz.build
+++ b/extensions/auth/moz.build
@@ -20,8 +20,10 @@ if CONFIG['OS_ARCH'] == 'WINNT':
     ]
     DEFINES['USE_SSPI'] = True
 else:
     UNIFIED_SOURCES += [
         'nsAuthSambaNTLM.cpp',
     ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/extensions/cookie/moz.build
+++ b/extensions/cookie/moz.build
@@ -22,8 +22,10 @@ UNIFIED_SOURCES += [
     'nsPopupWindowManager.cpp',
 ]
 
 MSVC_ENABLE_PGO = True
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/extensions/permissions/moz.build
+++ b/extensions/permissions/moz.build
@@ -5,8 +5,10 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 UNIFIED_SOURCES += [
     'nsContentBlocker.cpp',
     'nsModuleFactory.cpp',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/extensions/pref/autoconfig/src/moz.build
+++ b/extensions/pref/autoconfig/src/moz.build
@@ -7,8 +7,10 @@
 UNIFIED_SOURCES += [
     'nsAutoConfig.cpp',
     'nsConfigFactory.cpp',
     'nsJSConfigTriggers.cpp',
     'nsReadConfig.cpp',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/gfx/tests/gtest/moz.build
+++ b/gfx/tests/gtest/moz.build
@@ -18,17 +18,17 @@ UNIFIED_SOURCES += [
     # Hangs on linux in ApplyGdkScreenFontOptions
     #'gfxFontSelectionTest.cpp',
     'TestTextures.cpp',
     # Test works but it doesn't assert anything
     #'gfxTextRunPerfTest.cpp',
     'TestTiledLayerBuffer.cpp',
 ]
 
-# Because of gkmedia on windows we wont find these
+# Because of gkmedia on windows we won't find these
 # symbols in xul.dll.
 if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'windows':
     UNIFIED_SOURCES += [ '%s/gfx/2d/unittest/%s' % (TOPSRCDIR, p) for p in [
         'TestBase.cpp',
         'TestBugs.cpp',
         'TestPoint.cpp',
         'TestScaling.cpp',
     ]]
@@ -43,8 +43,10 @@ LOCAL_INCLUDES += [
     '/gfx/2d',
     '/gfx/2d/unittest',
     '/gfx/layers',
 ]
 
 FINAL_LIBRARY = 'xul-gtest'
 
 CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
+
+FAIL_ON_WARNINGS = True
--- a/gfx/ycbcr/moz.build
+++ b/gfx/ycbcr/moz.build
@@ -65,8 +65,10 @@ if CONFIG['CPU_ARCH'] == 'arm' and CONFI
     SOURCES += [
         'yuv_row_arm.s',
     ]
     SOURCES += [
         'yuv_convert_arm.cpp',
     ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/intl/chardet/moz.build
+++ b/intl/chardet/moz.build
@@ -12,8 +12,10 @@ EXPORTS += [
 ]
 
 UNIFIED_SOURCES += [
     'nsChardetModule.cpp',
     'nsCyrillicDetector.cpp',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/intl/locale/mac/moz.build
+++ b/intl/locale/mac/moz.build
@@ -12,8 +12,9 @@ UNIFIED_SOURCES += [
 
 FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '..',
     '../../icu/source/common',
     '../../icu/source/i18n',
 ]
 
+FAIL_ON_WARNINGS = True
--- a/intl/locale/moz.build
+++ b/intl/locale/moz.build
@@ -58,8 +58,10 @@ LOCAL_INCLUDES += [
 
 RESOURCE_FILES += [
     'langGroups.properties',
     'language.properties',
 ]
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'qt':
     CXXFLAGS += CONFIG['MOZ_QT_CFLAGS']
+
+FAIL_ON_WARNINGS = True
--- a/intl/lwbrk/moz.build
+++ b/intl/lwbrk/moz.build
@@ -45,8 +45,10 @@ else:
     ]
 
 MSVC_ENABLE_PGO = True
 
 FINAL_LIBRARY = 'xul'
 
 if CONFIG['MOZ_WIDGET_GTK']:
     CXXFLAGS += CONFIG['MOZ_PANGO_CFLAGS']
+
+FAIL_ON_WARNINGS = True
--- a/intl/strres/moz.build
+++ b/intl/strres/moz.build
@@ -16,8 +16,10 @@ XPIDL_MODULE = 'intl'
 UNIFIED_SOURCES += [
     'nsStringBundle.cpp',
     'nsStringBundleTextOverride.cpp',
 ]
 
 MSVC_ENABLE_PGO = True
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/intl/unicharutil/moz.build
+++ b/intl/unicharutil/moz.build
@@ -26,8 +26,10 @@ UNIFIED_SOURCES += [
     'nsCaseConversionImp2.cpp',
     'nsCategoryImp.cpp',
     'nsEntityConverter.cpp',
     'nsSaveAsCharset.cpp',
     'nsUnicodeNormalizer.cpp',
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/intl/unicharutil/util/internal/moz.build
+++ b/intl/unicharutil/util/internal/moz.build
@@ -8,8 +8,10 @@ include('../objs.mozbuild')
 
 UNIFIED_SOURCES += intl_unicharutil_util_cppsrcs
 
 FINAL_LIBRARY = 'xul'
 
 LOCAL_INCLUDES += [
     '..',
 ]
+
+FAIL_ON_WARNINGS = True
--- a/modules/libjar/zipwriter/moz.build
+++ b/modules/libjar/zipwriter/moz.build
@@ -19,8 +19,10 @@ UNIFIED_SOURCES += [
     'nsZipWriter.cpp',
     'StreamFunctions.cpp',
     'ZipWriterModule.cpp',
 ]
 
 MSVC_ENABLE_PGO = True
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/modules/libpref/moz.build
+++ b/modules/libpref/moz.build
@@ -36,8 +36,10 @@ SOURCES += [
 MSVC_ENABLE_PGO = True
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
 
 DEFINES['OS_ARCH'] = CONFIG['OS_ARCH']
 DEFINES['MOZ_WIDGET_TOOLKIT'] = CONFIG['MOZ_WIDGET_TOOLKIT']
+
+FAIL_ON_WARNINGS = True
--- a/profile/dirserviceprovider/moz.build
+++ b/profile/dirserviceprovider/moz.build
@@ -17,8 +17,10 @@ if CONFIG['MOZ_PROFILELOCKING']:
 
 Library('profdirserviceprovidersa_s')
 
 FORCE_STATIC_LIB = True
 
 DEFINES['XPCOM_GLUE'] = 1
 
 DISABLE_STL_WRAPPING = True
+
+FAIL_ON_WARNINGS = True
--- a/tools/profiler/tests/gtest/moz.build
+++ b/tools/profiler/tests/gtest/moz.build
@@ -14,8 +14,10 @@ LOCAL_INCLUDES += [
 ]
 
 UNIFIED_SOURCES += [
     'JSStreamWriterTest.cpp',
     'ThreadProfileTest.cpp',
 ]
 
 FINAL_LIBRARY = 'xul-gtest'
+
+FAIL_ON_WARNINGS = True
--- a/xpcom/reflect/xptinfo/moz.build
+++ b/xpcom/reflect/xptinfo/moz.build
@@ -29,8 +29,10 @@ EXPORTS.mozilla += [
 
 LOCAL_INCLUDES += [
     '/dom/base',
 ]
 
 MSVC_ENABLE_PGO = True
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True
--- a/xpcom/sample/moz.build
+++ b/xpcom/sample/moz.build
@@ -35,8 +35,10 @@ XPCOMBinaryComponent('xpcomsample')
 
 RESOURCE_FILES.samples += [
     'xpconnect-sample.html',
 ]
 
 # Need to link with CoreFoundation on Mac
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
     OS_LIBS += CONFIG['TK_LIBS']
+
+FAIL_ON_WARNINGS = True
--- a/xpcom/string/moz.build
+++ b/xpcom/string/moz.build
@@ -52,8 +52,10 @@ UNIFIED_SOURCES += [
 # nsUTF8Utils.cpp.
 if CONFIG['INTEL_ARCHITECTURE']:
     SOURCES += ['nsUTF8UtilsSSE2.cpp']
     SOURCES['nsUTF8UtilsSSE2.cpp'].flags += CONFIG['SSE2_FLAGS']
 
 MSVC_ENABLE_PGO = True
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True