Bug 1303668 - Failing to find a symbols url should be a warning instead of a exception. r=whimboo
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Fri, 23 Sep 2016 13:53:30 -0400
changeset 315758 a7c3db5394f216f41c4bd92bd4f70004fed11afe
parent 315757 c81754c082f08d5e95595cb1ee09d67f17eaa7b0
child 315759 0aae35666a87b50dee855c64df1f4f2d42905e32
push id20634
push usercbook@mozilla.com
push dateFri, 30 Sep 2016 10:10:13 +0000
treeherderfx-team@afe79b010d13 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswhimboo
bugs1303668
milestone52.0a1
Bug 1303668 - Failing to find a symbols url should be a warning instead of a exception. r=whimboo Failing to find symbols in this case should be turned into a warning rather than dumping the traceback since we're going to rely on mozcrash doing the right thing later on. This will reduce unnecessary reporting of symbols not being available. MozReview-Commit-ID: GXO01B7vzGV
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -195,17 +195,17 @@ class TestingMixin(VirtualenvMixin, Buil
             symbols_url = self.query_prefixed_build_dir_url('.crashreporter-symbols.zip')
 
             # Check if the URL exists. If not, use none to allow mozcrash to auto-check for symbols
             try:
                 if symbols_url:
                     self._urlopen(symbols_url, timeout=120)
                     self.symbols_url = symbols_url
             except (urllib2.HTTPError, urllib2.URLError, socket.error, socket.timeout):
-                self.exception("Can't figure out symbols_url from installer_url: %s!" % self.installer_url, level=WARNING)
+                self.warning("Can't figure out symbols_url from installer_url: %s!" % self.installer_url)
 
         # If no symbols URL can be determined let minidump_stackwalk query the symbols.
         # As of now this only works for Nightly and release builds.
         if not self.symbols_url:
             self.warning("No symbols_url found. Let minidump_stackwalk query for symbols.")
 
         return self.symbols_url