Bug 1304046 - Update geckodriver command line arguments for v0.11, r=ato
authorJames Graham <james@hoppipolla.co.uk>
Fri, 23 Sep 2016 13:25:34 +0100
changeset 315761 9fd9536c6fbb6cab78949fe7e8161116aede0883
parent 315760 66d217ff1f0148ee60b8012899325a69ad8e3b92
child 315762 f07b305e3d1142f86eca2b730815f3dbe347f733
push id20634
push usercbook@mozilla.com
push dateFri, 30 Sep 2016 10:10:13 +0000
treeherderfx-team@afe79b010d13 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1304046
milestone52.0a1
Bug 1304046 - Update geckodriver command line arguments for v0.11, r=ato MozReview-Commit-ID: QIBvXwOd2c
testing/web-platform/harness/wptrunner/webdriver_server.py
--- a/testing/web-platform/harness/wptrunner/webdriver_server.py
+++ b/testing/web-platform/harness/wptrunner/webdriver_server.py
@@ -69,16 +69,19 @@ class WebDriverServer(object):
         self.logger.debug(
             "Waiting for server to become accessible: %s" % self.url)
         try:
             wait_for_service((self.host, self.port))
         except:
             self.logger.error(
                 "WebDriver HTTP server was not accessible "
                 "within the timeout:\n%s" % traceback.format_exc())
+            if self._proc.poll():
+                self.logger.error("Webdriver server process exited with code %i" %
+                                  self._proc.returncode)
             raise
 
         if block:
             self._proc.wait()
 
     def stop(self):
         if self.is_alive:
             return self._proc.kill()
@@ -145,18 +148,18 @@ class GeckoDriverServer(WebDriverServer)
         env["RUST_BACKTRACE"] = "1"
         WebDriverServer.__init__(self, logger, binary, host=host, port=port, env=env)
         self.marionette_port = marionette_port
 
     def make_command(self):
         return [self.binary,
                 "--connect-existing",
                 "--marionette-port", str(self.marionette_port),
-                "--webdriver-host", self.host,
-                "--webdriver-port", str(self.port)]
+                "--host", self.host,
+                "--port", str(self.port)]
 
 
 def cmd_arg(name, value=None):
     prefix = "-" if platform.system() == "Windows" else "--"
     rv = prefix + name
     if value is not None:
         rv += "=" + value
     return rv