Bug 443410 – filefield author doesn't know how to write efficient CSS. r=gavin
authorneil@parkwaycc.co.uk <neil@httl.net>
Sat, 12 Jul 2008 11:21:50 +0200
changeset 15847 9e98808652ff1bd79cf4864219835557dc71a254
parent 15846 1d847cc0dbf6056e01e1b62edab3e1b3dd58fe53
child 15848 2b156d138832872219e6df09159f140a7aab2875
push idunknown
push userunknown
push dateunknown
reviewersgavin
bugs443410
milestone1.9.1a1pre
Bug 443410 – filefield author doesn't know how to write efficient CSS. r=gavin
browser/themes/gnomestripe/browser/preferences/preferences.css
browser/themes/winstripe/browser/preferences/preferences.css
toolkit/mozapps/preferences/preferences.xml
--- a/browser/themes/gnomestripe/browser/preferences/preferences.css
+++ b/browser/themes/gnomestripe/browser/preferences/preferences.css
@@ -98,21 +98,21 @@ filefield {
 }
 
 .fileFieldContentBox {
   background-color: -moz-Dialog;
   color: -moz-DialogText;
   margin: 1px;
 }
 
-filefield[disabled="true"] .fileFieldContentBox {
+.fileFieldContentBox[disabled="true"] {
   opacity: 0.5;
 }
 
-filefield[disabled="true"] .fileFieldIcon {
+.fileFieldIcon[disabled="true"] {
   opacity: 0.2;
 }
 
 .fileFieldIcon {
   width: 16px;
   height: 16px;
   margin-top: 2px;
   margin-bottom: 2px;
--- a/browser/themes/winstripe/browser/preferences/preferences.css
+++ b/browser/themes/winstripe/browser/preferences/preferences.css
@@ -125,21 +125,21 @@ filefield {
 }
 
 .fileFieldContentBox {
   background-color: -moz-Dialog;
   color: -moz-DialogText;
   margin: 1px;
 }
 
-filefield[disabled="true"] .fileFieldContentBox {
+.fileFieldContentBox[disabled="true"] {
   opacity: 0.5;
 }
 
-filefield[disabled="true"] .fileFieldIcon {
+.fileFieldIcon[disabled="true"] {
   opacity: 0.2;
 }
 
 .fileFieldIcon {
   width: 16px;
   height: 16px;
   margin-top: 2px;
   margin-bottom: 2px;
--- a/toolkit/mozapps/preferences/preferences.xml
+++ b/toolkit/mozapps/preferences/preferences.xml
@@ -3,18 +3,18 @@
 <bindings id="PreferencesSkinBindings"
           xmlns="http://www.mozilla.org/xbl"
           xmlns:xbl="http://www.mozilla.org/xbl"
           xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
 
   <binding id="fileField" extends="chrome://global/content/bindings/general.xml#control-item">
     <content>
       <xul:stringbundle anonid="bundle" src="chrome://mozapps/locale/preferences/preferences.properties"/>
-      <xul:hbox class="fileFieldContentBox" align="center" flex="1">
-        <xul:image class="fileFieldIcon" xbl:inherits="src=image"/>
+      <xul:hbox class="fileFieldContentBox" align="center" flex="1" xbl:inherits="disabled">
+        <xul:image class="fileFieldIcon" xbl:inherits="src=image,disabled"/>
         <xul:textbox class="fileFieldLabel" xbl:inherits="value=label,disabled,accesskey,tabindex" flex="1" readonly="true"/>
       </xul:hbox>
     </content>
     <implementation implements="nsIDOMXULLabeledControlElement">
       <property name="label" onget="return this.getAttribute('label');">
         <setter>
           this.setAttribute('label', val); 
           var elt = document.getAnonymousElementByAttribute(this, "class", "fileFieldLabel");