Bug 1130273 - PerformanceView._onClearButtonClick listener is never removed from _clearButton, r=jsantell
authorVictor Porof <vporof@mozilla.com>
Fri, 06 Feb 2015 13:21:48 -0500
changeset 227860 8d3c748186062dfe4696bd5a682a7915f0be1a90
parent 227859 f9153e3f838a798251fbfe72b4144b25920494f5
child 227861 e4ed2f7b72c5ee5a6392cea5115fbab24a465b19
push id11205
push uservporof@mozilla.com
push dateFri, 06 Feb 2015 19:16:34 +0000
treeherderfx-team@dee2c8135242 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjsantell
bugs1130273
milestone38.0a1
Bug 1130273 - PerformanceView._onClearButtonClick listener is never removed from _clearButton, r=jsantell
browser/devtools/performance/performance-view.js
--- a/browser/devtools/performance/performance-view.js
+++ b/browser/devtools/performance/performance-view.js
@@ -70,16 +70,17 @@ let PerformanceView = {
   /**
    * Unbinds events and destroys subviews.
    */
   destroy: Task.async(function* () {
     for (let button of $$(".record-button")) {
       button.removeEventListener("click", this._onRecordButtonClick);
     }
     this._importButton.removeEventListener("click", this._onImportButtonClick);
+    this._clearButton.removeEventListener("click", this._onClearButtonClick);
 
     PerformanceController.off(EVENTS.RECORDING_WILL_START, this._onRecordingWillStart);
     PerformanceController.off(EVENTS.RECORDING_WILL_STOP, this._onRecordingWillStop);
     PerformanceController.off(EVENTS.RECORDING_STARTED, this._unlockRecordButton);
     PerformanceController.off(EVENTS.RECORDING_STOPPED, this._onRecordingStopped);
     PerformanceController.off(EVENTS.RECORDING_SELECTED, this._onRecordingSelected);
 
     yield ToolbarView.destroy();