Bug 379482: Crash decompiling float setter, r=brendan, r=igor
authorcrowder@fiverocks.com
Tue, 08 May 2007 22:45:09 -0700
changeset 1302 895a950f221fd56ff01deb1b5bcf08eacade3c88
parent 1301 f619fe3093ef6c3d1fb32074d5c230cffb9110fc
child 1303 6559070b0e56d95148199380c3b644b1ab7024b7
push idunknown
push userunknown
push dateunknown
reviewersbrendan, igor
bugs379482
milestone1.9a5pre
Bug 379482: Crash decompiling float setter, r=brendan, r=igor
js/src/jsopcode.c
--- a/js/src/jsopcode.c
+++ b/js/src/jsopcode.c
@@ -3974,17 +3974,18 @@ Decompile(SprintStack *ss, jsbytecode *p
                               (lastop == JSOP_GETTER || lastop == JSOP_SETTER)
                               ? " " : "",
                               (lastop == JSOP_GETTER) ? js_getter_str :
                               (lastop == JSOP_SETTER) ? js_setter_str :
                               "",
                               rval);
 #else
                 if (lastop == JSOP_GETTER || lastop == JSOP_SETTER) {
-                    if (!ATOM_IS_IDENTIFIER(atom) ||
+                    if (!ATOM_IS_STRING(atom) ||
+                        !ATOM_IS_IDENTIFIER(atom) ||
                         ATOM_IS_KEYWORD(atom) ||
                         strncmp(rval, js_function_str, 8) ||
                         rval[8] != ' ') {
                         todo = Sprint(&ss->sprinter, "%s%s%s %s:%s", lval,
                                       (lval[1] != '\0') ? ", " : "", xval,
                                       (lastop == JSOP_GETTER) ? js_getter_str :
                                       (lastop == JSOP_SETTER) ? js_setter_str :
                                       "",