Bug 616440 - Detail view blocks scrolling with page-up, page-down, and arrow keys. r=Unfocused
authorAngie Ngo <angietngo@gmail.com>, Rich Gomez <rwgmez@gmail.com>
Thu, 10 May 2012 14:34:42 +1200
changeset 93402 85c4026e625d251f655296033935beeb4af94517
parent 93401 cf261bc52162d18cdbba65abd049750b1600c2eb
child 93712 f80568dba0102302c05d1f92f87eea78b53c4a91
push id746
push userbmcbride@mozilla.com
push dateThu, 10 May 2012 02:38:39 +0000
treeherderfx-team@85c4026e625d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersUnfocused
bugs616440
milestone15.0a1
Bug 616440 - Detail view blocks scrolling with page-up, page-down, and arrow keys. r=Unfocused
toolkit/mozapps/extensions/content/extensions.js
toolkit/mozapps/extensions/content/extensions.xul
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -635,16 +635,17 @@ var gViewController = {
 
     gCategories.select(aViewId, aPreviousView);
 
     this.currentViewId = aViewId;
     this.currentViewObj = viewObj;
 
     this.viewPort.selectedPanel = this.currentViewObj.node;
     this.viewPort.selectedPanel.setAttribute("loading", "true");
+    this.currentViewObj.node.focus();
 
     if (aViewId == aPreviousView)
       this.currentViewObj.refresh(view.param, ++this.currentViewRequest, aState);
     else
       this.currentViewObj.show(view.param, ++this.currentViewRequest, aState);
   },
 
   // Moves back in the document history and removes the current history entry
--- a/toolkit/mozapps/extensions/content/extensions.xul
+++ b/toolkit/mozapps/extensions/content/extensions.xul
@@ -235,17 +235,17 @@
     </richlistbox>
 
     <box id="view-port-container" class="main-content" flex="1">
 
       <!-- view port -->
       <deck id="view-port" flex="1" selectedIndex="0">
 
         <!-- discover view -->
-        <deck id="discover-view" flex="1" class="view-pane" selectedIndex="0">
+        <deck id="discover-view" flex="1" class="view-pane" selectedIndex="0" tabindex="0">
           <vbox id="discover-loading" align="center" pack="stretch" flex="1" class="alert-container">
             <spacer class="alert-spacer-before"/>
             <hbox class="alert loading" align="center">
               <image/>
               <label value="&loading.label;"/>
             </hbox>
             <spacer class="alert-spacer-after"/>
           </vbox>
@@ -265,17 +265,17 @@
             </hbox>
             <spacer class="alert-spacer-after"/>
           </vbox>
           <browser id="discover-browser" type="content" flex="1"
                    disablehistory="true" homepage="about:blank"/>
         </deck>
 
         <!-- search view -->
-        <vbox id="search-view" flex="1" class="view-pane">
+        <vbox id="search-view" flex="1" class="view-pane" tabindex="0">
           <hbox class="view-header global-warning-container" align="center">
             <!-- global warnings -->
             <hbox class="global-warning" flex="1">
               <hbox class="global-warning-safemode" flex="1" align="center"
                     tooltiptext="&warning.safemode.label;">
                 <image class="warning-icon"/>
                 <label class="global-warning-text" flex="1" crop="end"
                        value="&warning.safemode.label;"/>
@@ -340,17 +340,17 @@
           <richlistbox id="search-list" class="list" flex="1">
             <hbox pack="center">
               <label id="search-allresults-link" class="text-link"/>
             </hbox>
           </richlistbox>
         </vbox>
 
         <!-- list view -->
-        <vbox id="list-view" flex="1" class="view-pane" align="stretch">
+        <vbox id="list-view" flex="1" class="view-pane" align="stretch" tabindex="0">
           <hbox class="view-header global-warning-container">
             <!-- global warnings -->
             <hbox class="global-warning" flex="1">
               <hbox class="global-warning-safemode" flex="1" align="center"
                     tooltiptext="&warning.safemode.label;">
                 <image class="warning-icon"/>
                 <label class="global-warning-text" flex="1" crop="end"
                        value="&warning.safemode.label;"/>
@@ -396,17 +396,17 @@
                       command="cmd_goToDiscoverPane"/>
             </vbox>
             <spacer class="alert-spacer-after"/>
           </vbox>
           <richlistbox id="addon-list" class="list" flex="1"/>
         </vbox>
 
         <!-- updates view -->
-        <vbox id="updates-view" flex="1" class="view-pane">
+        <vbox id="updates-view" flex="1" class="view-pane" tabindex="0">
           <hbox class="view-header global-warning-container" align="center">
             <!-- global warnings -->
             <hbox class="global-warning" flex="1">
               <hbox class="global-warning-safemode" flex="1" align="center"
                     tooltiptext="&warning.safemode.label;">
                 <image class="warning-icon"/>
                 <label class="global-warning-text" flex="1" crop="end"
                        value="&warning.safemode.label;"/>
@@ -452,17 +452,17 @@
             <button id="update-selected-btn" hidden="true"
                     label="&updates.updateSelected.label;"
                     tooltiptext="&updates.updateSelected.tooltip;"/>
           </hbox>
           <richlistbox id="updates-list" class="list" flex="1"/>
         </vbox>
 
         <!-- detail view -->
-        <scrollbox id="detail-view" flex="1" class="view-pane addon-view" orient="vertical">
+        <scrollbox id="detail-view" flex="1" class="view-pane addon-view" orient="vertical" tabindex="0">
           <!-- global warnings -->
           <hbox class="global-warning-container global-warning">
             <hbox class="global-warning-safemode" flex="1" align="center"
                   tooltiptext="&warning.safemode.label;">
               <image class="warning-icon"/>
               <label class="global-warning-text" flex="1" crop="end"
                      value="&warning.safemode.label;"/>
             </hbox>