Bug 1170884 - Add title to menu item. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 16 Jun 2015 19:36:23 -0700
changeset 249192 759bfacec785851971bba8381d6bc7e938de27a2
parent 249191 9213957d166dfb840ee60259bead690dcd2850cf
child 249193 de50d9ec609e84e9feb2a78a4b1369a0eb85f6a1
push id13606
push usermichael.l.comella@gmail.com
push dateWed, 17 Jun 2015 15:57:51 +0000
treeherderfx-team@de50d9ec609e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
Bug 1170884 - Add title to menu item. r=mhaigh Part of android lint's "MenuTitle" warning. This is a stub (according to the comments) so we don't actually need a title. I was going to suppress the lint output but since the title is the empty string on v11+ where this value is used, I figured an empty string title should suffice.
--- a/mobile/android/base/resources/menu/preferences_search_menu.xml
+++ b/mobile/android/base/resources/menu/preferences_search_menu.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <!-- Stub to preserve IDs. -->
 <menu xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:id="@+id/restore_defaults" />
+    <item android:id="@+id/restore_defaults"
+          android:title="" />