Bug 1198331 - Titles in sidebar aren't cropped and cross borders between tabs (titles are to long in some locales). r=pbrosset
authorRaphaël Lustin <raphael@lustin.fr>
Mon, 28 Sep 2015 15:25:00 +0200
changeset 265293 6e82a342d591
parent 265292 313b18c62566
child 265294 32dc4f8f3aa0
push id15447
push usercbook@mozilla.com
push dateThu, 01 Oct 2015 07:18:11 +0000
treeherderfx-team@6e82a342d591 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbrosset
bugs1198331
milestone44.0a1
Bug 1198331 - Titles in sidebar aren't cropped and cross borders between tabs (titles are to long in some locales). r=pbrosset
devtools/client/framework/sidebar.js
devtools/client/netmonitor/netmonitor.xul
--- a/devtools/client/framework/sidebar.js
+++ b/devtools/client/framework/sidebar.js
@@ -220,16 +220,17 @@ ToolSidebar.prototype = {
     iframe.setAttribute("src", url);
     iframe.tooltip = "aHTMLTooltip";
 
     // Creating the tab and adding it to the tabbox
     let tab = this._panelDoc.createElementNS(XULNS, "tab");
     this._tabbox.tabs.appendChild(tab);
     tab.setAttribute("label", ""); // Avoid showing "undefined" while the tab is loading
     tab.setAttribute("id", this.TAB_ID_PREFIX + id);
+    tab.setAttribute("crop", "end");
 
     // Add the tab to the allTabs menu if exists
     let allTabsItem = this._addItemToAllTabsMenu(id, tab, selected);
 
     let onIFrameLoaded = (event) => {
       let doc = event.target;
       let win = doc.defaultView;
       tab.setAttribute("label", doc.title);
--- a/devtools/client/netmonitor/netmonitor.xul
+++ b/devtools/client/netmonitor/netmonitor.xul
@@ -314,28 +314,35 @@
                        data-key="body"/>
             </vbox>
           </vbox>
           <tabbox id="event-details-pane"
                   class="devtools-sidebar-tabs"
                   handleCtrlTab="false">
             <tabs>
               <tab id="headers-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.headers;"/>
               <tab id="cookies-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.cookies;"/>
               <tab id="params-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.params;"/>
               <tab id="response-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.response;"/>
               <tab id="timings-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.timings;"/>
               <tab id="security-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.security;"/>
               <tab id="preview-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.preview;"/>
             </tabs>
             <tabpanels flex="1">
               <tabpanel id="headers-tabpanel"
                         class="tabpanel-content">
                 <vbox flex="1">
                   <hbox id="headers-summary-url"
                         class="tabpanel-summary-container"