Bug 1035067: Don't hint we expect a track if we're not going to receive it r=ehugg
authorRandell Jesup <rjesup@jesup.org>
Mon, 07 Jul 2014 14:45:36 -0400
changeset 192759 667abb03c12379904e2243b69a777eb2854db377
parent 192758 261d818388d28fa95170cf9eddeb43809ee7415b
child 192760 23b19a772a42a93e263ef0fd1717a0d886d694a3
push id7651
push usercbook@mozilla.com
push dateTue, 08 Jul 2014 13:28:32 +0000
treeherderfx-team@05cfda67b9db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehugg
bugs1035067
milestone33.0a1
Bug 1035067: Don't hint we expect a track if we're not going to receive it r=ehugg
media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
--- a/media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
+++ b/media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
@@ -5257,17 +5257,20 @@ gsmsdp_negotiate_media_lines (fsm_fcb_t 
                     gsmsdp_set_rtcp_mux_attribute (SDP_ATTR_RTCP_MUX, media->level,
                                                    sdp_p->src_sdp, TRUE);
                   }
 
                   if (notify_stream_added) {
                       /*
                        * Add track to remote streams in dcb
                        */
-                      if (SDP_MEDIA_APPLICATION != media_type) {
+                      if (SDP_MEDIA_APPLICATION != media_type &&
+                          /* Do not expect to receive media if we're sendonly! */
+                          (media->direction == SDP_DIRECTION_SENDRECV ||
+                           media->direction == SDP_DIRECTION_RECVONLY)) {
                           int pc_stream_id = -1;
 
                           /* This is a hack to keep all the media in a single
                              stream.
                              TODO(ekr@rtfm.com): revisit when we have media
                              assigned to streams in the SDP */
                           if (!created_media_stream){
                               lsm_rc = lsm_add_remote_stream (dcb_p->line,