Bug 980438 - Make progress bar thinner and darker. r=lucsar
authorBrian Nicholson <bnicholson@mozilla.com>
Fri, 07 Mar 2014 09:03:42 -0800
changeset 172491 524608e2ef23b4dbe0b6659e7769fdc1fd0ef4b7
parent 172490 749fb9b52dd70e7724e0727e307238a6e5d9b33f
child 172492 cc50c0d103cbc1be642f438ddbfea1793e2eb623
push id5530
push userbnicholson@mozilla.com
push dateFri, 07 Mar 2014 17:03:53 +0000
treeherderfx-team@524608e2ef23 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslucsar
bugs980438
milestone30.0a1
Bug 980438 - Make progress bar thinner and darker. r=lucsar
mobile/android/base/resources/drawable-hdpi/progress.9.png
mobile/android/base/resources/drawable-mdpi/progress.9.png
mobile/android/base/resources/drawable-xhdpi/progress.9.png
mobile/android/base/resources/layout-large-v11/browser_toolbar.xml
mobile/android/base/resources/layout/browser_toolbar.xml
mobile/android/base/resources/layout/gecko_app.xml
index ae39f6583c7ebdc21b64b8e07f169e8b7f5f1e58..42566ff2e3322f62ecb36bb3b6b8a4f094abc11e
GIT binary patch
literal 451
zc$@*l0X+VRP)<h;3K|Lk000e1NJLTq001cf001Be1^@s6k8e>v0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUzWl2OqR9M69n9EATKoo|*X?n4^bLV^X
zA>8;9g7k&lWbd1}Ev^Mo#7#voUO>f5=6BJPc1TlgW3?&GfuEC^keqK0XU@PlNjT@k
z#2gheNjN}N1Iu&PkjsRuy48?1WDWVJkV$_vggfyp$apaF{oZ(-oc7Abae*3vve@2~
zn%B3GI^LZb>HcK6C`c6eOf8^kY8cQ5@M?MkK10wlkVPP&GJsa#Gqp_}^O0rm8AyOT
z;L%{yDM%enm#Q>kk|yJ)v(yDZ?SkN2rmiV`?&jv3mbnDD1}=di@Bq9QL24dId@%MP
zs~~v?9weKyck&wh(YJzB_79tvkmm~Nz(8*;o0WqEX%9FDZh)66LS7&p{*=kz)?_EB
z$)Z{;s?%tpnq1QE&hPA5yE|J{WbJ0Y-Mz#<*~lsDmCf8j%J)g)0ovX#1Nna^&U&5Q
t>k7F-t06ZJvcAFC9LR#JziJUm?hD*qSqwLXHrfCH002ovPDHLkV1f={&Ab2r
index 31d7f0bd004d28cd419ecc14458ab327038d4869..370898c4a4b6460acca43de7c87a5b11bf83d18c
GIT binary patch
literal 426
zc$@*M0agBqP)<h;3K|Lk000e1NJLTq000~S000&U1^@s6)0X`50000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUzOi4sRR7l6&mO)O#Fc3xG#3`lQT#`F*
z1}=~l7vT&n*dnoDQ-nkXi&9l>=CkOyvZ6o>sIAnIzJBB=|9d=RJ0=M;6Pqv&7?LnR
zhc+rbPhxn?IFaG(>Nsvq`#(b~P!-6l=7BC)`xp+1rh+p@Kpm)}5m&$>umsjki)X_j
z(Gpo~RB*;cU>uwxt2r<O-hdBa(X^~f!z_L=Aaog+1j^@0Z@i9-X23J>1WbYVre$dW
ztDE``nW@9%REWym5*?L9k}KgPIkj9{#w|%oblR+nsN@(@Cox631s=lmwQ2dxhC+rM
z<eLh}4IHExi+6Hu88;+BC#3wHKnfjQ1NXoq@Y1x*f0JP?C&`uh?-~A3!*Nl=q1p}A
zHSMh7jxOzY=yzS3Czycst}flR533&XUaWhQ+It@!_oO-d+v3b`{N7L0VcjJA0!H`s
U{aZymmjD0&07*qoM6N<$g1vFKga7~l
index f9cfb79c91e5faf762e0d0140b39700b01da8502..93546b15fb9bc0cd40c8ccd80ddf1270f24ca226
GIT binary patch
literal 572
zc$@(|0>k}@P)<h;3K|Lk000e1NJLTq001@s001fo1^@s6_)(}m0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUz-bqA3RA}Dqn!Qp2F%ZYI$DI~d+VLK?
zK7fVK!4p{e7B=+0fiK{UjfJI^mD;G|2!0_tj9E8#8_31naexSiyEA__At9GvlG!W+
zfQSkJP~{C&jV)y|zV09)HUSf`B?4PT6EFc2FaZ-V0h`_0=h;&>_EHbM<6M0fOUG($
z&k2kt9vpd^$!pByCqj`CgyD?+1oXhX74Dwi*6s{$wF6*y)Xa7ILojd@vB2>*r`4n{
z$KxWv!0}Ouw`!CqVweHxgVbj~;P){IhKJ?x#eC}N0wJ)9YRu#tfl0>&^@Pi=w`B`v
zfSyT@X5C3|q)*efxzhyN2%HG4n?XhVkl1;ct2i(@e}bX1)taMquioIJ_d+tq=!SGf
zdLX@;oht&vaXXfFMU^iPJ@-R3s%xiBt5KWwJT;(p`yn4L^v1(sfAVKk*k?Gid;L`b
zGlgAxy(Ha}dIGlOU?)^KsB#pi4IXaPiwmM!GA82Lz>yRLkHiTcCL-REt}6wPiuYJ3
z+=moRa6iQ*ixLOI{X4^TSmoh<ju$li(gkfZj{)Ch)h_4-r&MLT4qi%yd?amJr7NXW
zE1LxS)@jv_>z{+w*aS?#1WdrD2a{hk1x&!^2v+b1mU>gsSNm`1d+`kRa$@2D0000<
KMNUMnLSTX$K>q0f
--- a/mobile/android/base/resources/layout-large-v11/browser_toolbar.xml
+++ b/mobile/android/base/resources/layout-large-v11/browser_toolbar.xml
@@ -102,15 +102,16 @@
                android:layout_width="fill_parent"
                android:layout_height="2dp"
                android:layout_alignParentBottom="true"
                android:background="@color/url_bar_shadow"
                android:contentDescription="@null"/>
 
     <org.mozilla.gecko.toolbar.ToolbarProgressView android:id="@+id/progress"
                                                    android:layout_width="fill_parent"
-                                                   android:layout_height="2dp"
+                                                   android:layout_height="14dp"
+                                                   android:layout_marginBottom="-7dp"
                                                    android:layout_alignBottom="@id/shadow"
                                                    android:src="@drawable/progress"
                                                    android:background="@null"
                                                    android:visibility="gone" />
 
 </merge>
--- a/mobile/android/base/resources/layout/browser_toolbar.xml
+++ b/mobile/android/base/resources/layout/browser_toolbar.xml
@@ -102,16 +102,16 @@
                android:layout_width="fill_parent"
                android:layout_height="2dp"
                android:layout_alignParentBottom="true"
                android:background="@color/url_bar_shadow"
                android:contentDescription="@null"/>
 
     <org.mozilla.gecko.toolbar.ToolbarProgressView android:id="@+id/progress"
                                                    android:layout_width="fill_parent"
-                                                   android:layout_height="16dp"
-                                                   android:layout_marginBottom="-8dp"
+                                                   android:layout_height="14dp"
+                                                   android:layout_marginBottom="-7dp"
                                                    android:layout_alignBottom="@id/shadow"
                                                    android:src="@drawable/progress"
                                                    android:background="@null"
                                                    android:visibility="gone" />
 
 </merge>
--- a/mobile/android/base/resources/layout/gecko_app.xml
+++ b/mobile/android/base/resources/layout/gecko_app.xml
@@ -89,16 +89,20 @@
 
         <org.mozilla.gecko.widget.GeckoViewFlipper android:id="@id/browser_actionbar"
                 android:layout_width="fill_parent"
                 android:layout_height="@dimen/browser_toolbar_height"
                 android:clickable="true"
                 android:clipChildren="false"
                 android:focusable="true">
 
+            <!-- clipChildren="false" allows the child ToolbarProgressView to be drawn
+                 outside of BrowserToolbar's boundaries. Likewise, we need this property
+                 on BrowserToolbar's parent ViewFlipper, then on its parent MainLayout
+                 to allow the progress to overlap the content LayerView. -->
             <org.mozilla.gecko.toolbar.BrowserToolbar
                 android:id="@+id/browser_toolbar"
                 style="@style/BrowserToolbar"
                 android:layout_width="fill_parent"
                 android:layout_height="@dimen/browser_toolbar_height"
                 android:clickable="true"
                 android:focusable="true"
                 android:clipChildren="false"