Bug 1034908: Mark js::ErrorCopier construct as 'explicit', as per review comments. r=jorendorff
authorJim Blandy <jimb@mozilla.com>
Mon, 07 Jul 2014 11:52:40 -0700
changeset 192762 4d02030db21b6553d7de66febaf11a1822b11a02
parent 192761 9579d613f56a9bb3bd34cd9b6145df0fce005e5e
child 192763 778627b321e98aa5fcf81f72c5bc2f034271ebf8
push id7651
push usercbook@mozilla.com
push dateTue, 08 Jul 2014 13:28:32 +0000
treeherderfx-team@05cfda67b9db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1034908
milestone33.0a1
Bug 1034908: Mark js::ErrorCopier construct as 'explicit', as per review comments. r=jorendorff
js/src/jscompartment.h
--- a/js/src/jscompartment.h
+++ b/js/src/jscompartment.h
@@ -584,17 +584,17 @@ class AutoCompartment
  * the exception happens to be an Error object, copy it to the origin compartment
  * instead of wrapping it.
  */
 class ErrorCopier
 {
     mozilla::Maybe<AutoCompartment> &ac;
 
   public:
-    ErrorCopier(mozilla::Maybe<AutoCompartment> &ac)
+    explicit ErrorCopier(mozilla::Maybe<AutoCompartment> &ac)
       : ac(ac) {}
     ~ErrorCopier();
 };
 
 /*
  * AutoWrapperVector and AutoWrapperRooter can be used to store wrappers that
  * are obtained from the cross-compartment map. However, these classes should
  * not be used if the wrapper will escape. For example, it should not be stored