Bug 1130278 - The 'show-platform-data' pref is irrelevant for memory call trees, r=jsantell
authorVictor Porof <vporof@mozilla.com>
Fri, 06 Feb 2015 13:23:18 -0500
changeset 227862 44685f89442cd073dbb2ab575fe3dce7ad2de768
parent 227861 e4ed2f7b72c5ee5a6392cea5115fbab24a465b19
child 227863 bfc3a426a823168f4eabafcac595393afb944605
push id11205
push uservporof@mozilla.com
push dateFri, 06 Feb 2015 19:16:34 +0000
treeherderfx-team@dee2c8135242 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjsantell
bugs1130278
milestone38.0a1
Bug 1130278 - The 'show-platform-data' pref is irrelevant for memory call trees, r=jsantell
browser/devtools/performance/views/details-memory-call-tree.js
--- a/browser/devtools/performance/views/details-memory-call-tree.js
+++ b/browser/devtools/performance/views/details-memory-call-tree.js
@@ -3,17 +3,17 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
 /**
  * CallTree view containing memory allocation sites, controlled by DetailsView.
  */
 let MemoryCallTreeView = Heritage.extend(DetailsSubview, {
 
-  rerenderPrefs: ["invert-call-tree", "show-platform-data"],
+  rerenderPrefs: ["invert-call-tree"],
 
   rangeChangeDebounceTime: 100, // ms
 
   /**
    * Sets up the view with event binding.
    */
   initialize: function () {
     DetailsSubview.initialize.call(this);
@@ -55,21 +55,20 @@ let MemoryCallTreeView = Heritage.extend
   },
 
   /**
    * Called when the recording is stopped and prepares data to
    * populate the call tree.
    */
   _prepareCallTree: function (allocations, { startTime, endTime }, options) {
     let samples = RecordingUtils.getSamplesFromAllocations(allocations);
-    let contentOnly = !PerformanceController.getPref("show-platform-data");
     let invertTree = PerformanceController.getPref("invert-call-tree");
 
     let threadNode = new ThreadNode(samples,
-      { startTime, endTime, contentOnly, invertTree });
+      { startTime, endTime, invertTree });
 
     // If we have an empty profile (no samples), then don't invert the tree, as
     // it would hide the root node and a completely blank call tree space can be
     // mis-interpreted as an error.
     options.inverted = invertTree && threadNode.samples > 0;
 
     return threadNode;
   },