Bug 1293603 (part 1) - Add |override| to CollectReports() declarations missing it. r=erahm.
authorNicholas Nethercote <nnethercote@mozilla.com>
Mon, 08 Aug 2016 11:04:11 +1000
changeset 308875 4417b2d37bc5b768181b792daccb56c3d29a5d11
parent 308874 911fc6cbfad0df1b456ff4447fd81414ebf66c1e
child 308876 b09d90288666fb3afb11877fc45527b904ef23db
push id20279
push usercbook@mozilla.com
push dateWed, 10 Aug 2016 14:04:43 +0000
treeherderfx-team@531100c1d950 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1293603
milestone51.0a1
Bug 1293603 (part 1) - Add |override| to CollectReports() declarations missing it. r=erahm.
gfx/layers/ipc/SharedBufferManagerParent.cpp
gfx/thebes/gfxWindowsPlatform.cpp
xpcom/base/AvailableMemoryTracker.cpp
--- a/gfx/layers/ipc/SharedBufferManagerParent.cpp
+++ b/gfx/layers/ipc/SharedBufferManagerParent.cpp
@@ -37,17 +37,17 @@ uint64_t SharedBufferManagerParent::sBuf
 
 #ifdef MOZ_WIDGET_GONK
 class GrallocReporter final : public nsIMemoryReporter
 {
 public:
   NS_DECL_ISUPPORTS
 
   NS_IMETHOD CollectReports(nsIHandleReportCallback* aHandleReport,
-                            nsISupports* aData, bool aAnonymize)
+                            nsISupports* aData, bool aAnonymize) override
   {
     if (SharedBufferManagerParent::sManagerMonitor) {
       SharedBufferManagerParent::sManagerMonitor->Lock();
     }
     map<base::ProcessId, SharedBufferManagerParent*>::iterator it;
     for (it = SharedBufferManagerParent::sManagers.begin(); it != SharedBufferManagerParent::sManagers.end(); it++) {
       base::ProcessId pid = it->first;
       SharedBufferManagerParent *mgr = it->second;
--- a/gfx/thebes/gfxWindowsPlatform.cpp
+++ b/gfx/thebes/gfxWindowsPlatform.cpp
@@ -121,17 +121,17 @@ static const int kSupportedFeatureLevels
 class GfxD2DVramReporter final : public nsIMemoryReporter
 {
     ~GfxD2DVramReporter() {}
 
 public:
     NS_DECL_ISUPPORTS
 
     NS_IMETHOD CollectReports(nsIHandleReportCallback* aHandleReport,
-                              nsISupports* aData, bool aAnonymize)
+                              nsISupports* aData, bool aAnonymize) override
     {
         nsresult rv;
 
         rv = MOZ_COLLECT_REPORT(
             "gfx-d2d-vram-draw-target", KIND_OTHER, UNITS_BYTES,
             Factory::GetD2DVRAMUsageDrawTarget(),
             "Video memory used by D2D DrawTargets.");
         NS_ENSURE_SUCCESS(rv, rv);
@@ -179,17 +179,17 @@ class GPUAdapterReporter final : public 
 
     ~GPUAdapterReporter() {}
 
 public:
     NS_DECL_ISUPPORTS
 
     NS_IMETHOD
     CollectReports(nsIMemoryReporterCallback* aCb,
-                   nsISupports* aClosure, bool aAnonymize)
+                   nsISupports* aClosure, bool aAnonymize) override
     {
         HANDLE ProcessHandle = GetCurrentProcess();
 
         int64_t dedicatedBytesUsed = 0;
         int64_t sharedBytesUsed = 0;
         int64_t committedBytesUsed = 0;
         IDXGIAdapter *DXGIAdapter;
 
--- a/xpcom/base/AvailableMemoryTracker.cpp
+++ b/xpcom/base/AvailableMemoryTracker.cpp
@@ -339,17 +339,17 @@ LowMemoryEventsPhysicalDistinguishedAmou
 class LowEventsReporter final : public nsIMemoryReporter
 {
   ~LowEventsReporter() {}
 
 public:
   NS_DECL_ISUPPORTS
 
   NS_IMETHOD CollectReports(nsIHandleReportCallback* aHandleReport,
-                            nsISupports* aData, bool aAnonymize)
+                            nsISupports* aData, bool aAnonymize) override
   {
     nsresult rv;
 
     // We only do virtual-memory tracking on 32-bit builds.
     if (sizeof(void*) == 4) {
       rv = MOZ_COLLECT_REPORT(
         "low-memory-events/virtual", KIND_OTHER, UNITS_COUNT_CUMULATIVE,
         LowMemoryEventsVirtualDistinguishedAmount(),