Bug 1170884 - Remove obsolete layout params. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Fri, 12 Jun 2015 17:27:03 -0700
changeset 249189 43b338ccbaa972c660e97d186b5245fa1b5d5baa
parent 249188 002f738e36f0eb4aa3d20f3b7a0b1244395daff2
child 249190 67b89eefbb5642cbb7f8bf610ef44d0864bf974b
push id13606
push usermichael.l.comella@gmail.com
push dateWed, 17 Jun 2015 15:57:51 +0000
treeherderfx-team@de50d9ec609e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1170884
milestone41.0a1
Bug 1170884 - Remove obsolete layout params. r=mhaigh Via the ObsoleteLayoutParam android Lint warning. Fixed automagically by Android Studio.
mobile/android/base/resources/layout/keyguard_widget.xml
mobile/android/base/resources/layout/notification_progress.xml
mobile/android/base/resources/layout/notification_progress_text.xml
mobile/android/base/resources/layout/search_widget.xml
mobile/android/base/resources/layout/tab_history_item_row.xml
mobile/android/base/resources/layout/web_app.xml
--- a/mobile/android/base/resources/layout/keyguard_widget.xml
+++ b/mobile/android/base/resources/layout/keyguard_widget.xml
@@ -16,17 +16,16 @@
         android:background="@drawable/widget_button_left"
         android:layout_height="match_parent"
         android:src="@drawable/widget_icon"/>
 
     <LinearLayout android:id="@+id/new_tab_button"
         android:layout_width="0dp"
         android:layout_weight="1"
         android:layout_height="match_parent"
-        android:layout_centerVertical="true"
         android:contentDescription="@string/new_tab"
         android:gravity="center"
         android:orientation="horizontal"
         android:background="@drawable/widget_button_right">
 
         <TextView android:id="@+id/new_tab_button_label"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
--- a/mobile/android/base/resources/layout/notification_progress.xml
+++ b/mobile/android/base/resources/layout/notification_progress.xml
@@ -41,13 +41,12 @@
                   android:paddingLeft="3dp"/>
         <ProgressBar android:id="@+id/notification_progressbar"
                      style="?android:attr/progressBarStyleHorizontal"
                      android:layout_width="match_parent"
                      android:layout_height="wrap_content"
                      android:layout_marginTop="1dip"
                      android:layout_marginBottom="1dip"
                      android:layout_marginLeft="4dip"
-                     android:layout_marginRight="10dip"
-                     android:layout_centerHorizontal="true"/>
+                     android:layout_marginRight="10dip" />
     </LinearLayout>
 
 </LinearLayout>
--- a/mobile/android/base/resources/layout/notification_progress_text.xml
+++ b/mobile/android/base/resources/layout/notification_progress_text.xml
@@ -32,18 +32,17 @@
 
     <ProgressBar android:id="@+id/notification_progressbar"
                  style="?android:attr/progressBarStyleHorizontal"
                  android:layout_width="match_parent"
                  android:layout_height="16dip"
                  android:layout_marginTop="1dip"
                  android:layout_marginBottom="1dip"
                  android:layout_marginLeft="10dip"
-                 android:layout_marginRight="10dip"
-                 android:layout_centerHorizontal="true" />
+                 android:layout_marginRight="10dip" />
 
     <TextView android:id="@+id/notification_text"
               android:textAppearance="@android:style/TextAppearance.StatusBar.EventContent"
               android:layout_width="match_parent"
               android:layout_height="wrap_content"
               android:paddingLeft="4dp"/>
 
 </LinearLayout>
--- a/mobile/android/base/resources/layout/search_widget.xml
+++ b/mobile/android/base/resources/layout/search_widget.xml
@@ -41,17 +41,16 @@
             android:textColor="@color/toolbar_icon_grey"/>
 
     </LinearLayout>
 
     <LinearLayout android:id="@+id/new_tab_button"
         android:layout_width="0dp"
         android:layout_weight="1"
         android:layout_height="match_parent"
-        android:layout_centerVertical="true"
         android:contentDescription="@string/new_tab"
         android:gravity="center"
         android:orientation="horizontal"
         android:background="@drawable/widget_button_right">
 
         <TextView android:id="@+id/new_tab_button_label"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
--- a/mobile/android/base/resources/layout/tab_history_item_row.xml
+++ b/mobile/android/base/resources/layout/tab_history_item_row.xml
@@ -38,17 +38,16 @@
                    android:layout_gravity="center_horizontal"
                    android:background="@color/tab_history_timeline_separator" />
 
     </LinearLayout>
 
     <org.mozilla.gecko.widget.FadedSingleColorTextView
             android:id="@+id/tab_history_title"
             style="@style/Widget.TwoLinePageRow.Title"
-            android:layout_centerVertical="true"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical"
             android:paddingRight="@dimen/tab_history_title_margin_right"
             android:text="@+id/tab_history_title"
             android:textSize="@dimen/tab_history_title_text_size"
             android:textColor="@color/text_and_tabs_tray_grey"
             gecko:fadeWidth="@dimen/tab_history_title_fading_width"/>
--- a/mobile/android/base/resources/layout/web_app.xml
+++ b/mobile/android/base/resources/layout/web_app.xml
@@ -18,17 +18,16 @@
                   android:layout_height="wrap_content"
                   android:singleLine="true"/>
 
     </LinearLayout>
 
     <RelativeLayout android:id="@+id/gecko_layout"
                     android:layout_width="match_parent"
                     android:layout_height="match_parent"
-                    android:layout_weight="1"
                     android:layout_below="@+id/webapp_titlebar">
 
         <include layout="@layout/shared_ui_components"/>
 
         <RelativeLayout android:id="@+id/splashscreen"
                         android:layout_width="match_parent"
                         android:layout_height="match_parent" >