No bug - Fix eslint warnings which popped up with delay. r=eslint-fix
authorSebastian Hengst <archaeopteryx@coole-files.de>
Fri, 07 Oct 2016 16:58:58 +0200
changeset 317071 3745b8ba92b1faf5da9762831b72de987b962b68
parent 317070 7e8ddcf9716aea87e598333e2970437c94173334
child 317072 7421808509ca9f14e1543d4876d15a07c183c967
push id20681
push userphilringnalda@gmail.com
push dateSat, 08 Oct 2016 23:57:20 +0000
treeherderfx-team@7a7ba250bb2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseslint-fix
milestone52.0a1
No bug - Fix eslint warnings which popped up with delay. r=eslint-fix
browser/components/originattributes/test/browser/browser_favicon_firstParty.js
security/manager/ssl/tests/unit/test_pinning_dynamic.js
--- a/browser/components/originattributes/test/browser/browser_favicon_firstParty.js
+++ b/browser/components/originattributes/test/browser/browser_favicon_firstParty.js
@@ -150,17 +150,17 @@ function* openTab(aURL) {
   gBrowser.selectedTab = tab;
   tab.ownerGlobal.focus();
 
   let browser = gBrowser.getBrowserForTab(tab);
   yield BrowserTestUtils.browserLoaded(browser);
   return {tab, browser};
 }
 
-function* assignCookiesUnderFirstParty(aURL, aFirstParty, aCookieValue){
+function* assignCookiesUnderFirstParty(aURL, aFirstParty, aCookieValue) {
   // Open a tab under the given aFirstParty, and this tab will have an
   // iframe which loads the aURL.
   let tabInfo = yield openTabInFirstParty(aURL, aFirstParty);
 
   // Add cookies into the iframe.
   yield ContentTask.spawn(tabInfo.browser, aCookieValue, function* (value) {
     content.document.cookie = value;
   });
--- a/security/manager/ssl/tests/unit/test_pinning_dynamic.js
+++ b/security/manager/ssl/tests/unit/test_pinning_dynamic.js
@@ -92,17 +92,16 @@ function checkDefaultSiteHPKPStatus() {
 function checkStateRead(aSubject, aTopic, aData) {
   if (aData == SSS_STATE_FILE_NAME) {
     gSSSStateSeen = true;
   } else if (aData == PRELOAD_STATE_FILE_NAME) {
     gPreloadStateSeen = true;
   } else {
     throw new Error("Observed data should either be the Site Security " +
                     "Service state file name or the preload file name");
-    return;
   }
 
   if (!gSSSStateSeen || !gPreloadStateSeen) {
     return;
   }
 
   notEqual(gSSService, null, "SiteSecurityService should be initialized");