Bug 1258505 - Fix verification of total_chunks argument; r=maja_zf
authorAnjana Vakil <anjanavakil@gmail.com>
Wed, 29 Jun 2016 18:03:46 +0200
changeset 303286 34ef0f60e636a595d884a4fd642a943e50500012
parent 303285 6b8a445ab25b197256bd044ecd9abc3fd849168a
child 303287 254fadf6315928bca4ef93466e6c75524e8a6b5e
push id19839
push usercbook@mozilla.com
push dateFri, 01 Jul 2016 09:19:59 +0000
treeherderfx-team@499d8875de7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf
bugs1258505
milestone50.0a1
Bug 1258505 - Fix verification of total_chunks argument; r=maja_zf In BaseMarionetteArguments.verify_usage, require total_chunks > 1, as described in error message (not >= 1 as previously). MozReview-Commit-ID: 1EftQpfHpo9
testing/marionette/harness/marionette/runner/base.py
--- a/testing/marionette/harness/marionette/runner/base.py
+++ b/testing/marionette/harness/marionette/runner/base.py
@@ -420,17 +420,17 @@ class BaseMarionetteArguments(ArgumentPa
 
         if args.total_chunks is not None and args.this_chunk is None:
             self.error('You must specify which chunk to run.')
 
         if args.this_chunk is not None and args.total_chunks is None:
             self.error('You must specify how many chunks to split the tests into.')
 
         if args.total_chunks is not None:
-            if not 1 <= args.total_chunks:
+            if not 1 < args.total_chunks:
                 self.error('Total chunks must be greater than 1.')
             if not 1 <= args.this_chunk <= args.total_chunks:
                 self.error('Chunk to run must be between 1 and %s.' % args.total_chunks)
 
         if args.jsdebugger:
             args.app_args.append('-jsdebugger')
             args.socket_timeout = None