Bug 395330 - Active downloads don't appear in download manager. r=sdwilsh, blocking-ff3=mconnor
authoredward.lee@engineering.uiuc.edu
Mon, 01 Oct 2007 12:12:26 -0700
changeset 6489 34cea343610811c2eb9eb781c3c35ece45063fb1
parent 6488 3fb9ac000453006e5249bdd37e44a7a0099b44e4
child 6490 eb6d51c38dc771309955da95a9fda79dd1ab831c
push idunknown
push userunknown
push dateunknown
reviewerssdwilsh
bugs395330
milestone1.9a9pre
Bug 395330 - Active downloads don't appear in download manager. r=sdwilsh, blocking-ff3=mconnor
toolkit/components/downloads/src/nsDownloadManager.cpp
--- a/toolkit/components/downloads/src/nsDownloadManager.cpp
+++ b/toolkit/components/downloads/src/nsDownloadManager.cpp
@@ -1790,22 +1790,20 @@ nsDownload::OnProgressChange64(nsIWebPro
         if (chan) {
           rv = chan->GetReferrer(getter_AddRefs(mReferrer));
           if (NS_FAILED(rv))
             mReferrer = nsnull;
         }
       }
     }
 
-    // Fetch the entityID
+    // Fetch the entityID, but if we can't get it, don't panic (non-resumable)
     nsCOMPtr<nsIResumableChannel> resumableChannel(do_QueryInterface(aRequest));
-    if (resumableChannel) {
-      rv = resumableChannel->GetEntityID(mEntityID);
-      NS_ENSURE_SUCCESS(rv, rv);
-    }
+    if (resumableChannel)
+      (void)resumableChannel->GetEntityID(mEntityID);
 
     // Update the state and the database
     rv = SetState(nsIDownloadManager::DOWNLOAD_DOWNLOADING);
     NS_ENSURE_SUCCESS(rv, rv);
   }
 
   // filter notifications since they come in so frequently
   PRTime now = PR_Now();