Bug 1110461 - Disable estimated reading time in reading list. r=mcomella
authorMargaret Leibovic <margaret.leibovic@gmail.com>
Thu, 11 Dec 2014 13:44:49 -0800
changeset 219765 295f228e8a9bbc02d894d3525a8465feb78462d7
parent 219764 a7770ec46f0401c0a855e68f656ad8362be77ffc
child 219766 c34f43a2a07270afd41cb004928f7814815e7a94
child 219914 249dbdbe09e0ed9d6abe081289a76beb55e4b847
push id10414
push usermleibovic@mozilla.com
push dateTue, 16 Dec 2014 00:37:24 +0000
treeherderfx-team@295f228e8a9b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1110461
milestone37.0a1
Bug 1110461 - Disable estimated reading time in reading list. r=mcomella
mobile/android/base/home/ReadingListRow.java
mobile/android/base/resources/layout/reading_list_row_view.xml
--- a/mobile/android/base/home/ReadingListRow.java
+++ b/mobile/android/base/home/ReadingListRow.java
@@ -56,23 +56,25 @@ public class ReadingListRow extends Line
         }
 
         final int titleIndex = cursor.getColumnIndexOrThrow(ReadingListItems.TITLE);
         title.setText(cursor.getString(titleIndex));
 
         final int excerptIndex = cursor.getColumnIndexOrThrow(ReadingListItems.EXCERPT);
         excerpt.setText(cursor.getString(excerptIndex));
 
+        /* Disabled until UX issues are fixed (see bug 1110461).
         final int lengthIndex = cursor.getColumnIndexOrThrow(ReadingListItems.LENGTH);
         final int minutes = getEstimatedReadTime(cursor.getInt(lengthIndex));
         if (minutes <= 60) {
             readTime.setText(resources.getString(R.string.reading_list_time_minutes, minutes));
         } else {
             readTime.setText(resources.getString(R.string.reading_list_time_over_an_hour));
         }
+        */
     }
 
     /**
      * Calculates the estimated time to read an article based on its length.
      *
      * @param length of the article (in characters)
      * @return estimated time to read the article (in minutes)
      */
--- a/mobile/android/base/resources/layout/reading_list_row_view.xml
+++ b/mobile/android/base/resources/layout/reading_list_row_view.xml
@@ -29,11 +29,12 @@
 
     </LinearLayout>
 
     <TextView
         android:id="@+id/read_time"
         android:layout_width="64dp"
         android:layout_height="match_parent"
         android:gravity="center"
+        android:visibility="gone"
         style="@style/Widget.ReadingListRow.ReadTime" />
 
 </merge>