Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r=poiru
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 18:41:48 -0700
changeset 288681 27a4c68860fd1a25a85751b0b01352b9cba5ee05
parent 288680 727ac6e2c2273a0902e710ae8a388078fe3c45cc
child 288682 c19d7ab6f3bac7d10cef454fc480893004d3fe75
push id18174
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:44:58 +0000
treeherderfx-team@dd0baa33759d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspoiru
bugs1256514
milestone48.0a1
Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 9gOSotjaQsN
intl/unicharutil/util/internal/moz.build
--- a/intl/unicharutil/util/internal/moz.build
+++ b/intl/unicharutil/util/internal/moz.build
@@ -18,8 +18,14 @@ LOCAL_INCLUDES += [
     '..',
 ]
 
 if CONFIG['ENABLE_INTL_API']:
     CXXFLAGS += CONFIG['MOZ_ICU_CFLAGS']
     LOCAL_INCLUDES += CONFIG['MOZ_ICU_INCLUDES']
 
 DIST_INSTALL = True
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # 'noexcept' used with no exception handling mode specified;
+    # termination on exception is not guaranteed. Specify /EHsc
+    CXXFLAGS += ['-wd4577']