Bug 1170884 - Change inner LinearLayout to wrap_content. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 23 Jun 2015 10:39:55 -0700
changeset 250101 170d033d4e15e6130beb90dc795da76ed2dac534
parent 250100 fde6d2f7d6bca3ff14f49190f49c02abc7bcf61c
child 250102 257dc5010bad8257c3da5da41279ad2c3b06f3a3
push id13695
push usermichael.l.comella@gmail.com
push dateWed, 24 Jun 2015 18:08:56 +0000
treeherderfx-team@170d033d4e15 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1170884
milestone41.0a1
Bug 1170884 - Change inner LinearLayout to wrap_content. r=mhaigh Inside a ScrollView. According to Android Lint: ScrollView children must set their layout_width or layout_height attributes to wrap_content rather than fill_parent or match_parent in the scrolling dimension --- Who am I to argue?
mobile/android/base/resources/layout-mdpi/firstrun_welcome_fragment.xml
--- a/mobile/android/base/resources/layout-mdpi/firstrun_welcome_fragment.xml
+++ b/mobile/android/base/resources/layout-mdpi/firstrun_welcome_fragment.xml
@@ -6,17 +6,17 @@
 
 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
             android:layout_height="wrap_content"
             android:layout_width="match_parent"
             android:orientation="vertical"
             android:fillViewport="true">
 
     <LinearLayout android:layout_width="match_parent"
-                  android:layout_height="match_parent"
+                  android:layout_height="wrap_content"
                   android:minHeight="@dimen/firstrun_min_height"
                   android:orientation="vertical">
 
        <LinearLayout android:layout_width="match_parent"
                      android:layout_height="0dp"
                      android:layout_weight="21"
                      android:orientation="vertical"
                      android:gravity="center"