Bug 1244479 - ensure search and clear icons in Synced Tabs sidebar are always visible. r=Gijs
authorMark Hammond <mhammond@skippinet.com.au>
Wed, 17 Feb 2016 17:54:00 +0100
changeset 284572 0d9a089756b5c5497ab6936baec6b3182cdd35b9
parent 284571 b4a09e08d866e0793347dfaf7aaf54c75ee5a349
child 284573 5fafc520af0c3d10df3378a48021eeacd7c0b631
push id17678
push usercbook@mozilla.com
push dateThu, 18 Feb 2016 10:42:22 +0000
treeherderfx-team@5fafc520af0c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1244479
milestone47.0a1
Bug 1244479 - ensure search and clear icons in Synced Tabs sidebar are always visible. r=Gijs
browser/themes/linux/syncedtabs/sidebar.css
browser/themes/osx/syncedtabs/sidebar.css
browser/themes/shared/syncedtabs/sidebar.inc.css
--- a/browser/themes/linux/syncedtabs/sidebar.css
+++ b/browser/themes/linux/syncedtabs/sidebar.css
@@ -45,16 +45,17 @@ html {
   height: 16px;
 }
 
 .textbox-search-icon {
   background-image: url(moz-icon://stock/gtk-find?size=menu);
   background-repeat: no-repeat;
   width: 16px;
   height: 16px;
+  display: block;
 }
 
 .textbox-search-icon[searchbutton]:not([disabled]) ,
 .textbox-search-clear:not([disabled]) {
   cursor: pointer;
 }
 
 .item.client .item-twisty-container {
--- a/browser/themes/osx/syncedtabs/sidebar.css
+++ b/browser/themes/osx/syncedtabs/sidebar.css
@@ -66,24 +66,19 @@ html {
   border-bottom-left-radius: 2px;
   background-color: #FFF;
   color: #000;
   -moz-user-select: text;
   text-shadow: none;
 }
 
 .search-box.compact > .textbox-input-box > .textbox-search-icons > .textbox-search-clear {
-  width: 11px;
-  height: 11px;
-  background-image: url(chrome://global/skin/icons/searchfield-small-cancel.png);
+  background-image: url(chrome://global/skin/icons/searchfield-cancel.svg);
   background-repeat: no-repeat;
-}
-
-.search-box.compact > .textbox-input-box > .textbox-search-icons > .textbox-search-clear:active:hover {
-  background-position: 11px 0;
+  background-size: 11px 11px;
 }
 
 .search-box.compact > .textbox-input-box > .textbox-search-icons > .textbox-search-icon {
   display: none;
 }
 
 .search-box[focused="true"] {
   -moz-border-top-colors: -moz-mac-focusring -moz-mac-focusring #000000;
--- a/browser/themes/shared/syncedtabs/sidebar.inc.css
+++ b/browser/themes/shared/syncedtabs/sidebar.inc.css
@@ -118,16 +118,21 @@ body {
 
 .textbox-input-box {
   display: flex;
   flex-direction: row;
 }
 
 .tabsFilter {
   flex: 1;
+  /* min-width of anything to override the implicit "-moz-min-content" value.
+     0px is safe as the sidebar itself has a constrained size meaning we will
+     never actually hit this minimum
+  */
+  min-width: 0px;
 }
 
 .sync-state > p {
   padding-inline-end: 10px;
   padding-inline-start: 10px;
   color: #888;
 }