Bug 894147 - Follow-up: Remove leaky debugging code from BrowserElementParent.jsm. r=me.
authorJustin Lebar <justin.lebar@gmail.com>
Thu, 18 Jul 2013 15:04:45 -0700
changeset 139138 0d19bdaf4f2b2e5c6a5a00edc03186ad84008be5
parent 139137 96fbc8fbf6272d663decff688326b26c6bdd7aff
child 139139 32d34779852ba6e5bcba9cbf640a036bf5e40b74
push id1890
push userryanvm@gmail.com
push dateFri, 19 Jul 2013 17:44:21 +0000
treeherderfx-team@20848adc9980 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs894147
milestone25.0a1
Bug 894147 - Follow-up: Remove leaky debugging code from BrowserElementParent.jsm. r=me. The second version of bug 894147 to land on b2g18 (after it was backed out once) already incorporates this fix.
dom/browser-element/BrowserElementParent.jsm
--- a/dom/browser-element/BrowserElementParent.jsm
+++ b/dom/browser-element/BrowserElementParent.jsm
@@ -102,17 +102,17 @@ function BrowserElementParent(frameLoade
 
   // Messages we receive are handed to functions which take a (data) argument,
   // where |data| is the message manager's data object.
   // We use a single message and dispatch to various function based
   // on data.msg_name
   let mmCalls = {
     "hello": this._recvHello,
     "contextmenu": this._fireCtxMenuEvent,
-    "locationchange": this._gotLocationChange,
+    "locationchange": this._fireEventFromMsg,
     "loadstart": this._fireEventFromMsg,
     "loadend": this._fireEventFromMsg,
     "titlechange": this._fireEventFromMsg,
     "iconchange": this._fireEventFromMsg,
     "close": this._fireEventFromMsg,
     "securitychange": this._fireEventFromMsg,
     "error": this._fireEventFromMsg,
     "scroll": this._fireEventFromMsg,
@@ -607,21 +607,16 @@ BrowserElementParent.prototype = {
   },
 
   _fireFatalError: function() {
     let evt = this._createEvent('error', {type: 'fatal'},
                                 /* cancelable = */ false);
     this._frameElement.dispatchEvent(evt);
   },
 
-  _gotLocationChange: function(data) {
-    this[data._payload_] = 'BEP location';
-    this._fireEventFromMsg(data);
-  },
-
   observe: function(subject, topic, data) {
     switch(topic) {
     case 'oop-frameloader-crashed':
       if (this._isAlive() && subject == this._frameLoader) {
         this._fireFatalError();
       }
       break;
     case 'ask-children-to-exit-fullscreen':