Bug 1078213 - Search bar binding shouldn't set IDs for menuitems. r=MattN
authorBlair McBride <bmcbride@mozilla.com>
Wed, 08 Oct 2014 11:58:04 +1300
changeset 209213 0554ceb29cdcac1eaad3a4c6d94f995aa79b80cd
parent 209212 6ee8bbf1b8f2e652ed2bbdfeaf155183ff533ee2
child 209214 1b31dbd88b6aca327da7a645b033525631119429
push id9209
push userbmcbride@mozilla.com
push dateTue, 07 Oct 2014 23:00:33 +0000
treeherderfx-team@0554ceb29cdc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN
bugs1078213
milestone35.0a1
Bug 1078213 - Search bar binding shouldn't set IDs for menuitems. r=MattN
browser/components/search/content/search.xml
--- a/browser/components/search/content/search.xml
+++ b/browser/components/search/content/search.xml
@@ -392,17 +392,16 @@
           const kXULNS =
                "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
 
           var engines = this.engines;
           for (var i = engines.length - 1; i >= 0; --i) {
             var menuitem = document.createElementNS(kXULNS, "menuitem");
             var name = engines[i].name;
             menuitem.setAttribute("label", name);
-            menuitem.setAttribute("id", name);
             menuitem.setAttribute("class", "menuitem-iconic searchbar-engine-menuitem menuitem-with-favicon");
             // Since this menu is rebuilt by the observer method whenever a new
             // engine is selected, the "selected" attribute does not need to be
             // explicitly cleared anywhere.
             if (engines[i] == this.currentEngine)
               menuitem.setAttribute("selected", "true");
             var tooltip = this._stringBundle.getFormattedString("searchtip", [name]);
             menuitem.setAttribute("tooltiptext", tooltip);