Bug 1313517: Always compute start time with ADTS. r=kamidphish
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 27 Oct 2016 20:12:29 +1100
changeset 319915 011fe8bad1ebd4d0cc8ff267c9841b101098536d
parent 319914 2aa6df19f5f214bb3d28db836ba259ca6afb6ff3
child 319916 e44413534c507e766b701bc4bf359345d71e9f3d
push id20749
push userryanvm@gmail.com
push dateSat, 29 Oct 2016 13:21:21 +0000
treeherderfx-team@1b170b39ed6b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskamidphish
bugs1313517
milestone52.0a1
Bug 1313517: Always compute start time with ADTS. r=kamidphish This was originally copied from the MP3Demuxer and was only required to work around an issue now fixed. Only MSE should set ShoultComputeStartTime to false, even if the ADTS demuxer always returns a first sample with a time of 0. MozReview-Commit-ID: DMRLpxC5mU1
dom/media/ADTSDemuxer.h
--- a/dom/media/ADTSDemuxer.h
+++ b/dom/media/ADTSDemuxer.h
@@ -27,17 +27,16 @@ public:
   // MediaDataDemuxer interface.
   explicit ADTSDemuxer(MediaResource* aSource);
   RefPtr<InitPromise> Init() override;
   bool HasTrackType(TrackInfo::TrackType aType) const override;
   uint32_t GetNumberTracks(TrackInfo::TrackType aType) const override;
   already_AddRefed<MediaTrackDemuxer> GetTrackDemuxer(
     TrackInfo::TrackType aType, uint32_t aTrackNumber) override;
   bool IsSeekable() const override;
-  bool ShouldComputeStartTime() const override { return false; }
 
 private:
   bool InitInternal();
 
   RefPtr<MediaResource> mSource;
   RefPtr<ADTSTrackDemuxer> mTrackDemuxer;
 };