searching for reviewer(poiru)
0ed826f3d2775d8d5eacb76fc39703db3670c622: Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r=poiru
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 21:44:22 -0700 - rev 288715
Push 18174 by cbook@mozilla.com at Tue, 15 Mar 2016 09:44:58 +0000
Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r=poiru The previous disabling of this warning on just Key.cpp was not sufficient because another file from the unified sources list appears to include the header exhibiting the warning. MozReview-Commit-ID: rR2XXigTJU
b56407b86b1340cfed2fb5b010f1ab53c7d32226: Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r=poiru
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 21:24:54 -0700 - rev 288706
Push 18174 by cbook@mozilla.com at Tue, 15 Mar 2016 09:44:58 +0000
Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: CnmHTfEZpBK
8882a15789b0eb9d5ff5bd1728fd38b2c9cc4d6b: Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r=poiru
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 18:03:39 -0700 - rev 288683
Push 18174 by cbook@mozilla.com at Tue, 15 Mar 2016 09:44:58 +0000
Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 2MIqvI3qCsZ
c19d7ab6f3bac7d10cef454fc480893004d3fe75: Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r=poiru
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 17:56:28 -0700 - rev 288682
Push 18174 by cbook@mozilla.com at Tue, 15 Mar 2016 09:44:58 +0000
Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: 70QwT9y6eb2
27a4c68860fd1a25a85751b0b01352b9cba5ee05: Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r=poiru
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 18:41:48 -0700 - rev 288681
Push 18174 by cbook@mozilla.com at Tue, 15 Mar 2016 09:44:58 +0000
Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 9gOSotjaQsN
1d23be50020a5a73760b1e4fe85ac06f522692ab: Bug 1254967 - Actually test if dia2.h exists instead of assuming the existence. r=poiru
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 11 Mar 2016 07:25:33 +0900 - rev 288159
Push 18135 by cbook@mozilla.com at Fri, 11 Mar 2016 15:58:58 +0000
Bug 1254967 - Actually test if dia2.h exists instead of assuming the existence. r=poiru
990eeaa39c299b43c06b5b9b04951c8cf8b8b421: Bug 1197461 - Tests for Permissions.revoke. r=poiru,baku
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 02 Mar 2016 21:09:56 +0000 - rev 286522
Push 17963 by cbook@mozilla.com at Thu, 03 Mar 2016 10:56:30 +0000
Bug 1197461 - Tests for Permissions.revoke. r=poiru,baku
59b8d765123ce48d13db01a00a3d3fc628ad67e8: Bug 1197461 - e10s support for Permissions.revoke. r=poiru
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 02 Mar 2016 21:09:48 +0000 - rev 286521
Push 17963 by cbook@mozilla.com at Thu, 03 Mar 2016 10:56:30 +0000
Bug 1197461 - e10s support for Permissions.revoke. r=poiru
e978b825517d6d06d1071d179d5f0d89a069733c: Bug 1197461 - Implement Permissions.revoke. r=poiru,baku
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 02 Mar 2016 21:09:38 +0000 - rev 286520
Push 17963 by cbook@mozilla.com at Thu, 03 Mar 2016 10:56:30 +0000
Bug 1197461 - Implement Permissions.revoke. r=poiru,baku
d776c61906c17234f60c8df54ed4f913959eb5eb: Bug 1197461 - Tests for Permissions.revoke. r=poiru,baku
Marco Castelluccio <mcastelluccio@mozilla.com> - Tue, 09 Feb 2016 17:46:36 +0000 - rev 284313
Push 17622 by cbook@mozilla.com at Tue, 16 Feb 2016 11:22:48 +0000
Bug 1197461 - Tests for Permissions.revoke. r=poiru,baku
c046a81ab5a373e8ce2c2a8c16aca43eedf4914f: Bug 1197461 - Implement Permissions.revoke. r=poiru,baku
Marco Castelluccio <mcastelluccio@mozilla.com> - Tue, 09 Feb 2016 17:46:23 +0000 - rev 284312
Push 17622 by cbook@mozilla.com at Tue, 16 Feb 2016 11:22:48 +0000
Bug 1197461 - Implement Permissions.revoke. r=poiru,baku
36f11da8d2d9a649a0fafb4ce85ee41b552239ff: Bug 1121760 (part 6) - Move all remaining PL_DHash*() functions into PLDHashTable. r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 14 Sep 2015 14:23:47 -0700 - rev 262746
Push 15207 by kwierso@gmail.com at Wed, 16 Sep 2015 18:04:49 +0000
Bug 1121760 (part 6) - Move all remaining PL_DHash*() functions into PLDHashTable. r=poiru.
50772808876106e59a15b8300eeb311a3a3b10d7: Bug 1121760 (part 5) - Remove PL_DHashMarkTableImmutable(). r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 14 Sep 2015 14:23:27 -0700 - rev 262745
Push 15207 by kwierso@gmail.com at Wed, 16 Sep 2015 18:04:49 +0000
Bug 1121760 (part 5) - Remove PL_DHashMarkTableImmutable(). r=poiru.
f957524fc6248406f1029dac87869ea3e77fd75d: Bug 1121760 (part 4) - Remove PL_DHashTableRawRemove(). r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 14 Sep 2015 14:23:26 -0700 - rev 262744
Push 15207 by kwierso@gmail.com at Wed, 16 Sep 2015 18:04:49 +0000
Bug 1121760 (part 4) - Remove PL_DHashTableRawRemove(). r=poiru.
108f4bf0585b22a5d5d44c280a8e1c463ae329ef: Bug 1121760 (part 3) - Remove PL_DHashTableRemove(). r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 14 Sep 2015 14:23:24 -0700 - rev 262743
Push 15207 by kwierso@gmail.com at Wed, 16 Sep 2015 18:04:49 +0000
Bug 1121760 (part 3) - Remove PL_DHashTableRemove(). r=poiru.
16597175b6f3678f38020fdf4c4a7f4debf38d2e: Bug 1121760 (part 2) - Remove PL_DHashTableAdd(). r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 14 Sep 2015 14:23:12 -0700 - rev 262742
Push 15207 by kwierso@gmail.com at Wed, 16 Sep 2015 18:04:49 +0000
Bug 1121760 (part 2) - Remove PL_DHashTableAdd(). r=poiru.
e37d0c2d053a28f4361a495a4ec20d8488406d64: Bug 1121760 (part 1) - Remove PL_DHashTableSearch(). r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 21 May 2015 00:34:25 -0700 - rev 262741
Push 15207 by kwierso@gmail.com at Wed, 16 Sep 2015 18:04:49 +0000
Bug 1121760 (part 1) - Remove PL_DHashTableSearch(). r=poiru.
de90e543e4f237e08d3938284a2a9cd229abb9e5: Bug 1190608, part 5 - Sink the declaration of i in nsXULElement.cpp. r=poiru
Andrew McCreight <continuation@gmail.com> - Tue, 04 Aug 2015 13:06:15 -0700 - rev 256210
Push 14432 by cbook@mozilla.com at Wed, 05 Aug 2015 11:36:57 +0000
Bug 1190608, part 5 - Sink the declaration of i in nsXULElement.cpp. r=poiru
93bc28d6facd9abd380159b511eb6bd2567b73bb: Bug 1190608, part 4 - Brace a few ifs in nsXULElement.cpp. r=poiru
Andrew McCreight <continuation@gmail.com> - Tue, 04 Aug 2015 13:06:14 -0700 - rev 256209
Push 14432 by cbook@mozilla.com at Wed, 05 Aug 2015 11:36:57 +0000
Bug 1190608, part 4 - Brace a few ifs in nsXULElement.cpp. r=poiru
f1579da7f21e0e2fa602061092d2f82ecc3a7dcc: Bug 1190608, part 3 - Remove some infallible new checks in nsXULElement.cpp. r=poiru
Andrew McCreight <continuation@gmail.com> - Tue, 04 Aug 2015 13:06:14 -0700 - rev 256208
Push 14432 by cbook@mozilla.com at Wed, 05 Aug 2015 11:36:57 +0000
Bug 1190608, part 3 - Remove some infallible new checks in nsXULElement.cpp. r=poiru
99a5c0692c09f351c949f2fe6b0d30dc80dac8b6: Bug 1190608, part 2 - Tuck elses in nsXULElement.cpp. r=poiru
Andrew McCreight <continuation@gmail.com> - Tue, 04 Aug 2015 13:06:14 -0700 - rev 256207
Push 14432 by cbook@mozilla.com at Wed, 05 Aug 2015 11:36:57 +0000
Bug 1190608, part 2 - Tuck elses in nsXULElement.cpp. r=poiru
9f3ba882cb9c9334a2eba8760d7f10aa22dce00b: Bug 1190608, part 1 - Delete trailing whitespace in nsXULElement.cpp and nsXULPrototypeCache.cpp. r=poiru
Andrew McCreight <continuation@gmail.com> - Tue, 04 Aug 2015 13:06:14 -0700 - rev 256206
Push 14432 by cbook@mozilla.com at Wed, 05 Aug 2015 11:36:57 +0000
Bug 1190608, part 1 - Delete trailing whitespace in nsXULElement.cpp and nsXULPrototypeCache.cpp. r=poiru Also, change the mode line for nsXULElement.cpp to match reality, which is 4 space indentation.
751d493a4f255ceeb49e2857df2ac3fea2537e9c: Bug 1184695 - Fix some indentation in nsHashPropertyBag. r=poiru
Andrew McCreight <continuation@gmail.com> - Thu, 16 Jul 2015 17:50:43 -0700 - rev 253428
Push 14079 by ryanvm@gmail.com at Fri, 17 Jul 2015 14:29:31 +0000
Bug 1184695 - Fix some indentation in nsHashPropertyBag. r=poiru
98b61e7948cf64dc3411c148d710b80bcc643519: Bug 1182926 - Fix "observer-service-suspect" bustage. r=poiru.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 12 Jul 2015 15:55:27 -0700 - rev 252564
Push 13987 by kwierso@gmail.com at Mon, 13 Jul 2015 23:03:21 +0000
Bug 1182926 - Fix "observer-service-suspect" bustage. r=poiru.
bbda4b92523f7e6bb24b53433901ea1d259fc6e4: Bug 1178317 - eliminate large static constructor from ShimInterfaceInfo.cpp; r=poiru
Nathan Froyd <froydnj@mozilla.com> - Mon, 29 Jun 2015 10:59:59 -0400 - rev 250626
Push 13779 by cbook@mozilla.com at Tue, 30 Jun 2015 12:25:57 +0000
Bug 1178317 - eliminate large static constructor from ShimInterfaceInfo.cpp; r=poiru Constructing kComponentsInterfaceShimMap required a static constructor on some compilers, due to a non-constexpr constructor and the necessity of copying non-constexpr things like nsIID. This static constructor is large (several kilobytes of object code on x86-64) and completely unnecessary. To fix this, let's add a constexpr (well, MOZ_CONSTEXPR) constructor to ComponentsInterfaceShimEntry. This change alone doesn't completely solve our problem, because the nsIID member still needs to be copied. But doing that copying is silly: we only use the IID for constructing a ShimInterfaceInfo in ShimInterfaceInfo::MaybeConstruct, and the ShimInterfaceInfo constructor takes a const reference. So let's store a const reference in ComponentsInterfaceShimEntry, too, and make that structure significantly smaller in the process.
0fb582f7086de57af63ce8652e10a52dba000a80: Bug 1178363 - make nsTimerImpl::GetGeneration a private method; r=poiru
Nathan Froyd <froydnj@mozilla.com> - Mon, 29 Jun 2015 13:09:11 -0400 - rev 250625
Push 13779 by cbook@mozilla.com at Tue, 30 Jun 2015 12:25:57 +0000
Bug 1178363 - make nsTimerImpl::GetGeneration a private method; r=poiru Since GetGeneration() is only called by nsTimerEvent, it doesn't need to be public.
0edaf3f59b4d340ad6276e385169ec97b39bb8a6: Bug 1178363 - make nsTimerImpl::PostTimerEvent a private method; r=poiru
Nathan Froyd <froydnj@mozilla.com> - Mon, 29 Jun 2015 10:33:30 -0400 - rev 250624
Push 13779 by cbook@mozilla.com at Tue, 30 Jun 2015 12:25:57 +0000
Bug 1178363 - make nsTimerImpl::PostTimerEvent a private method; r=poiru PostTimerEvent is only called by the timer thread, which is already able to access private members of nsTimerImpl; there's no reason for PostTimerEvent to be public.
3eb2d9a5bfe5752fc4c3c004f38c56ee42600e4d: Bug 1178363 - make MOZ_TASK_TRACER-dependent bits of nsTimerImpl private; r=poiru
Nathan Froyd <froydnj@mozilla.com> - Thu, 18 Jun 2015 12:02:23 -0400 - rev 250623
Push 13779 by cbook@mozilla.com at Tue, 30 Jun 2015 12:25:57 +0000
Bug 1178363 - make MOZ_TASK_TRACER-dependent bits of nsTimerImpl private; r=poiru GetTracedTask() is only called from nsTimerImpl itself, so it doesn't need to be public. GetTLSTraceInfo() is called from the timer thread, which has access to our private members already.
782ec69db4e320dd9e7295732360fef29e3d4fca: Bug 1178363 - make nsTimerImpl::Fire a private method; r=poiru
Nathan Froyd <froydnj@mozilla.com> - Thu, 18 Jun 2015 12:00:56 -0400 - rev 250622
Push 13779 by cbook@mozilla.com at Tue, 30 Jun 2015 12:25:57 +0000
Bug 1178363 - make nsTimerImpl::Fire a private method; r=poiru This method is only called by nsTimerEvent, which is an implementation detail of nsTimerImpl.
d8477bd43531caed9c250ae9795f4d91aad24fe3: Bug 1178363 - make nsTimerImpl::SetDelayInternal a private method; r=poiru
Nathan Froyd <froydnj@mozilla.com> - Wed, 17 Jun 2015 21:40:18 -0400 - rev 250621
Push 13779 by cbook@mozilla.com at Tue, 30 Jun 2015 12:25:57 +0000
Bug 1178363 - make nsTimerImpl::SetDelayInternal a private method; r=poiru Nothing outside nsTimerImpl uses it, and with a name like "SetDelayInternal", nothing should.
1f9f41d4dbab5f4c980bc628fdaa339d5f81d06c: Bug 1167418 - Check fallible AppendElements call in FontFaceSet. r=poiru
Cameron McCormack <cam@mcc.id.au> - Wed, 27 May 2015 10:41:11 +1000 - rev 245794
Push 13198 by kwierso@gmail.com at Thu, 28 May 2015 00:24:10 +0000
Bug 1167418 - Check fallible AppendElements call in FontFaceSet. r=poiru
3de3af63a33f315e94b29963667184b9e067574a: Bug 1100184 - Flatten netwerk/streamconv/(public|src)/ directories. r=mcmanus, r=poiru
James Kitchener <jkitch.bug@internode.on.net> - Sat, 03 Jan 2015 17:42:00 -0500 - rev 224866
Push 10916 by cbook@mozilla.com at Wed, 21 Jan 2015 13:36:00 +0000
Bug 1100184 - Flatten netwerk/streamconv/(public|src)/ directories. r=mcmanus, r=poiru
4ec37503ea6a752baf92e053ede5f0ff7750ff36: Bug 1100184 - Flatten netwerk/base/{public,src}/ directories. r=mcmanus, r=poiru
James Kitchener <jkitch.bug@internode.on.net> - Tue, 20 Jan 2015 03:58:00 -0500 - rev 224865
Push 10916 by cbook@mozilla.com at Wed, 21 Jan 2015 13:36:00 +0000
Bug 1100184 - Flatten netwerk/base/{public,src}/ directories. r=mcmanus, r=poiru
8f48ab6499cfa2f071d8bb3c550884e94dbc7803: Bug 1055286 - Flatten editor/libeditor/text to editor/libeditor; r=poiru
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 18 Aug 2014 20:59:37 -0400 - rev 200254
Push 8272 by emorley@mozilla.com at Tue, 19 Aug 2014 14:17:45 +0000
Bug 1055286 - Flatten editor/libeditor/text to editor/libeditor; r=poiru
a357afff88300587c1905f01819c777f461af7eb: Bug 1055105 - Flatten editor/libeditor/html to editor/libeditor; r=poiru
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 18 Aug 2014 17:28:17 -0400 - rev 200240
Push 8272 by emorley@mozilla.com at Tue, 19 Aug 2014 14:17:45 +0000
Bug 1055105 - Flatten editor/libeditor/html to editor/libeditor; r=poiru
f05a36b5b90df34e0d5973641d160fdd7787df68: Bug 1042469 - Flatten editor/libeditor/base to editor/libeditor; r=poiru
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 15 Aug 2014 10:03:48 -0400 - rev 199794
Push 8236 by ryanvm@gmail.com at Fri, 15 Aug 2014 21:07:37 +0000
Bug 1042469 - Flatten editor/libeditor/base to editor/libeditor; r=poiru