searching for reviewer(neil)
74724ded165f579d12fe6bacf49e08c4f27e1c87: Bug 1266724, add null check of defaultView, r=neil
Akshay Jain - Fri, 27 May 2016 09:19:53 -0400 - rev 299376
Push 19437 by cbook@mozilla.com at Mon, 30 May 2016 13:34:14 +0000
Bug 1266724, add null check of defaultView, r=neil
d820bfb71d3a431acf00e4a6036a3d7cf9e0bbae: Bug 1197913 - Keep the last hovered item highlighted after moving the cursor outside the <select> drop-down list on Windows. r=neil
Ting-Yu Chou <janus926@gmail.com> - Fri, 25 Mar 2016 17:10:16 +0800 - rev 290676
Push 18408 by cbook@mozilla.com at Tue, 29 Mar 2016 12:40:23 +0000
Bug 1197913 - Keep the last hovered item highlighted after moving the cursor outside the <select> drop-down list on Windows. r=neil MozReview-Commit-ID: 1mWm5ltckHl
b1df2d21ba2d695ba751cafdf40829504e09fc64: Bug 1249226 - Use weak reference to keep popup's previous focus to avoid leak. r=neil
Ting-Yu Chou <janus926@gmail.com> - Wed, 09 Mar 2016 10:54:04 +0800 - rev 287478
Push 18103 by mozilla@noorenberghe.ca at Wed, 09 Mar 2016 22:58:05 +0000
Bug 1249226 - Use weak reference to keep popup's previous focus to avoid leak. r=neil MozReview-Commit-ID: 8VUexyKMbJr
62cc4b503870cf7be4ae0c530a3d7ab99c8585b9: Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r=neil
Kris Maglione <maglione.k@gmail.com> - Wed, 10 Feb 2016 20:12:00 -0800 - rev 284857
Push 17715 by maglione.k@gmail.com at Sat, 20 Feb 2016 07:37:13 +0000
Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r=neil MozReview-Commit-ID: 9OiVjcJy99g
d61da023339cd16d65aa60c93ce463617f10a5c8: Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r=neil
Kris Maglione <maglione.k@gmail.com> - Mon, 08 Feb 2016 14:36:04 -0800 - rev 283768
Push 17546 by maglione.k@gmail.com at Wed, 10 Feb 2016 23:10:32 +0000
Bug 1213895: Part 1 - Correctly support crop="none" in XUL labels. r=neil
f5bd302550b101d5beba853e596c4d7604d4aa48: Bug 950936 - Introduce ui.popup.disable_autohide pref to ease debugging popups. r=neil
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 28 Jan 2016 10:11:31 -0800 - rev 282098
Push 17281 by apoirot@mozilla.com at Thu, 28 Jan 2016 18:13:50 +0000
Bug 950936 - Introduce ui.popup.disable_autohide pref to ease debugging popups. r=neil
7c8fa9fad7b53245ec3703b96a46e3626d3d3cdb: Bug 950936 - Introduce ui.popup.disable_autohide pref to ease debugging popups. r=neil
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 18 Jan 2016 03:10:42 -0800 - rev 280325
Push 17065 by apoirot@mozilla.com at Mon, 18 Jan 2016 11:11:11 +0000
Bug 950936 - Introduce ui.popup.disable_autohide pref to ease debugging popups. r=neil
4a9a6f9a2cf4e1243ed9d0224acd0edec3841f5b: Bug 1190382 - don't send useless KeyboardEvent properties, r=neil
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 02 Dec 2015 15:25:29 +0000 - rev 275635
Push 16563 by gijskruitbosch@gmail.com at Fri, 04 Dec 2015 12:48:47 +0000
Bug 1190382 - don't send useless KeyboardEvent properties, r=neil
bb12e45c0dd8664c8d28c7094a4d25ab4275f5f7: Bug 1225682 - Don't use nsAuto{,C}String as class member variables in xpfe/. r=neil
Mike Hommey <mh+mozilla@glandium.org> - Thu, 19 Nov 2015 18:32:05 +0900 - rev 275161
Push 16506 by cbook@mozilla.com at Wed, 02 Dec 2015 14:23:03 +0000
Bug 1225682 - Don't use nsAuto{,C}String as class member variables in xpfe/. r=neil
432bea2c0c685740470dd5e1e25dd90ecba395c1: Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil
Marco Bonardo <mbonardo@mozilla.com> - Tue, 10 Nov 2015 20:18:24 +0100 - rev 271905
Push 16171 by mak77@bonardo.net at Tue, 10 Nov 2015 19:18:54 +0000
Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil
e1d1d11909a4feceb354c9ba8fdbbdb840aeaf73: Bug 1186790 - Replace nsBaseHashtable::EnumerateRead() calls in xpfe/ with iterators. r=neil.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 01 Nov 2015 19:50:57 -0800 - rev 271485
Push 16118 by cbook@mozilla.com at Fri, 06 Nov 2015 12:59:41 +0000
Bug 1186790 - Replace nsBaseHashtable::EnumerateRead() calls in xpfe/ with iterators. r=neil.
6fff7b56c8659f0ea90fefdb772095f633295723: Bug 1180761, cancel the event earlier so that space doesn't trigger checkbox change and scroll, r=neil
Neil Deakin <neil@mozilla.com> - Tue, 29 Sep 2015 14:49:32 -0400 - rev 265109
Push 15432 by cbook@mozilla.com at Wed, 30 Sep 2015 11:55:00 +0000
Bug 1180761, cancel the event earlier so that space doesn't trigger checkbox change and scroll, r=neil
015e96e1fef00c20fd1753c8764b6f65570d7fef: Bug 1141703 - make datepicker look disabled when it is readonly, similar to other text widgets. r=Neil
aceman <acelists@atlas.sk> - Tue, 26 May 2015 14:31:00 +0200 - rev 265078
Push 15429 by cbook@mozilla.com at Wed, 30 Sep 2015 08:13:03 +0000
Bug 1141703 - make datepicker look disabled when it is readonly, similar to other text widgets. r=Neil
837fa5b51ffafe2816b644440561ce2ad2a50cc5: Bug 1191897, add a flag for popups which allow shortcut keys to not be consumed, fixes shortcuts not working when an e10s select popup is open, r=neil
Neil Deakin <neil@mozilla.com> - Thu, 17 Sep 2015 11:20:33 -0400 - rev 263088
Push 15232 by kwierso@gmail.com at Thu, 17 Sep 2015 22:26:04 +0000
Bug 1191897, add a flag for popups which allow shortcut keys to not be consumed, fixes shortcuts not working when an e10s select popup is open, r=neil
147f228aeb8cfa616a37a5fbef00005f9ad0b2b9: Bug 1177381 - View source from error console uses deprecated API. r=neil
Ian Neal <iann_bugzilla@blueyonder.co.co.uk> - Mon, 27 Jul 2015 10:07:00 -0400 - rev 254799
Push 14250 by ryanvm@gmail.com at Mon, 27 Jul 2015 19:44:33 +0000
Bug 1177381 - View source from error console uses deprecated API. r=neil
46c5af10adc53ac786e2ac758d98a996c1d8054a: Bug 1177000, only consider popups of the same type when determining whether a popup shouldn't reopen, this allows dropdown buttons in popup to reopen properly, r=neil
Neil Deakin <neil@mozilla.com> - Mon, 13 Jul 2015 06:07:49 -0400 - rev 252578
Push 13987 by kwierso@gmail.com at Mon, 13 Jul 2015 23:03:21 +0000
Bug 1177000, only consider popups of the same type when determining whether a popup shouldn't reopen, this allows dropdown buttons in popup to reopen properly, r=neil
9d39c3d0f11251851c92ef4148922770c5ce48e2: Bug 617811 - cycleCell in <tree> should only be called for left clicks. r=neil
Phoenix <pppx@i.com.ua> - Tue, 30 Jun 2015 22:47:16 +0300 - rev 250942
Push 13813 by ryanvm@gmail.com at Wed, 01 Jul 2015 20:40:07 +0000
Bug 617811 - cycleCell in <tree> should only be called for left clicks. r=neil
11373e6e556f02838d8e037c13d4b4c4b3597f9b: Bug 1149745, on Windows, menulist should select the value when the cursor keys are used to navigate items, r=neil
Neil Deakin <neil@mozilla.com> - Fri, 26 Jun 2015 09:32:25 -0700 - rev 250428
Push 13765 by cbook@mozilla.com at Mon, 29 Jun 2015 12:24:37 +0000
Bug 1149745, on Windows, menulist should select the value when the cursor keys are used to navigate items, r=neil
fd26eba375aeacbc8fa2612282cf68175857b8aa: Bug 1171219 - Support for badged toolbarbuttons with panels (r=neil)
Bill McCloskey <billm@mozilla.com> - Wed, 03 Jun 2015 11:48:20 -0700 - rev 247982
Push 13461 by cbook@mozilla.com at Wed, 10 Jun 2015 13:25:40 +0000
Bug 1171219 - Support for badged toolbarbuttons with panels (r=neil)
9c8afe52c600eea9eeb2633bfbb13c2d5a0efe47: Bug 1047713, e10s optgroup support, r=neil,felipe
Neil Deakin <neil@mozilla.com> - Fri, 05 Jun 2015 08:33:28 -0400 - rev 247415
Push 13390 by kwierso@gmail.com at Fri, 05 Jun 2015 23:05:40 +0000
Bug 1047713, e10s optgroup support, r=neil,felipe
1921222e708e8b070b8ef5db215d5bec2217d375: Bug 1159490 - Allow cut/copy event dispatch unconditionally in HTML documents. r=neil
Michael Layzell <michael@thelayzells.com> - Wed, 13 May 2015 08:44:00 +0200 - rev 245651
Push 13177 by kwierso@gmail.com at Tue, 26 May 2015 23:26:28 +0000
Bug 1159490 - Allow cut/copy event dispatch unconditionally in HTML documents. r=neil
5dcf471886e68db300d8de9ee50a48cf454d1e8e: Bug 1141703 - Make month buttons in datepicker do nothing if the widget is readonly and make the widget look disabled. r=Neil
aceman <acelists@atlas.sk> - Thu, 12 Mar 2015 11:21:00 -0400 - rev 245595
Push 13164 by ryanvm@gmail.com at Tue, 26 May 2015 15:41:42 +0000
Bug 1141703 - Make month buttons in datepicker do nothing if the widget is readonly and make the widget look disabled. r=Neil
d192c8d0ddb6c27b994cbe1dcd5772ed99b081c6: Bug 250091, support page up and page down in menulists, r=neil
Neil Deakin <neil@mozilla.com> - Wed, 20 May 2015 13:11:06 -0400 - rev 244849
Push 13061 by kwierso@gmail.com at Thu, 21 May 2015 01:32:04 +0000
Bug 250091, support page up and page down in menulists, r=neil
f703c5483fa01bb6251c826cb2f7417d655ae611: Bug 1160770 - Unnecessary return in tabScrolling property in XPFE autocomplete.xml NPOTB r=Neil DONTBUILD
Philip Chee <philip.chee@gmail.com> - Sun, 03 May 2015 00:15:40 +0800 - rev 242138
Push 12704 by philringnalda@gmail.com at Sat, 02 May 2015 17:20:25 +0000
Bug 1160770 - Unnecessary return in tabScrolling property in XPFE autocomplete.xml NPOTB r=Neil DONTBUILD
52c23bbb3009047e549acdb1875332174ecf1c58: Bug 1138336 - Adapt nsIScriptError so it can display log messages with filename and line number; r=jst,neil,past
Geoff Lankow <geoff@darktrojan.net> - Tue, 28 Apr 2015 18:39:47 +1200 - rev 241442
Push 12629 by ryanvm@gmail.com at Tue, 28 Apr 2015 19:43:29 +0000
Bug 1138336 - Adapt nsIScriptError so it can display log messages with filename and line number; r=jst,neil,past
6a441288685a323df3ea6bb847c32e6338fe067c: MBUg 1002232, mve tooltip test into a window to prevent the browser tooltip from interfering with it, r=neil
Neil Deakin <neil@mozilla.com> - Mon, 09 Mar 2015 10:11:51 -0400 - rev 232597
Push 11667 by kwierso@gmail.com at Tue, 10 Mar 2015 02:14:18 +0000
MBUg 1002232, mve tooltip test into a window to prevent the browser tooltip from interfering with it, r=neil
f235e9568add834a05398e69dc6659815e2bd342: Bug 1131052, assign label values to the months so that the frames don't get recreated when the value is set, prevents the correct month from being displayed, r=neil
Neil Deakin <neil@mozilla.com> - Fri, 13 Feb 2015 15:06:29 -0500 - rev 229165
Push 11345 by cbook@mozilla.com at Mon, 16 Feb 2015 15:19:30 +0000
Bug 1131052, assign label values to the months so that the frames don't get recreated when the value is set, prevents the correct month from being displayed, r=neil
d3171c9db3c6e20f92d4659d749f4d300787dd88: Bug 1116865, add an attribute to popups to allow them to not rollup when clicking on the anchor, this is used for the new search field, r=neil, felipe
Neil Deakin <neil@mozilla.com> - Mon, 02 Feb 2015 15:53:53 -0500 - rev 227121
Push 11120 by cbook@mozilla.com at Tue, 03 Feb 2015 14:35:12 +0000
Bug 1116865, add an attribute to popups to allow them to not rollup when clicking on the anchor, this is used for the new search field, r=neil, felipe
f15991d2f3b313d72d4a55b55eb7ca8159cc899a: Bug 1116278 - Make JS callers of ios.newChannel call ios.newChannel2 in browser/components/feeds (r=neil)
Christoph Kerschbaumer <mozilla@christophkerschbaumer.com> - Mon, 26 Jan 2015 19:55:28 -0800 - rev 226300
Push 11039 by ryanvm@gmail.com at Wed, 28 Jan 2015 20:05:03 +0000
Bug 1116278 - Make JS callers of ios.newChannel call ios.newChannel2 in browser/components/feeds (r=neil)
845a77a120995233ad04d68b90442b0f01083f1c: Bug 1100219 - Avoid lots of unnecessary string copying in ProtocolParser. r=neil.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 18 Nov 2014 18:42:43 -0800 - rev 216420
Push 10037 by cbook@mozilla.com at Wed, 19 Nov 2014 12:52:31 +0000
Bug 1100219 - Avoid lots of unnecessary string copying in ProtocolParser. r=neil.
e51b51f049d95ee749da8d859d0395d79b60e14a: Bug 1074557 - Remove the lock in nsWindowMediator. r=Neil
Brian Marshall <bmarsd@gmail.com> - Thu, 16 Oct 2014 15:45:17 -0700 - rev 212342
Push 9568 by philringnalda@gmail.com at Sun, 26 Oct 2014 17:52:47 +0000
Bug 1074557 - Remove the lock in nsWindowMediator. r=Neil
d32376a43283bef59d0b60531fa0c6f327737dac: Bug 1061147, embedding/content process tooltips shouldn't autohide, r=neil
Neil Deakin <neil@mozilla.com> - Thu, 09 Oct 2014 12:21:15 -0400 - rev 209710
Push 9259 by kwierso@gmail.com at Fri, 10 Oct 2014 04:39:02 +0000
Bug 1061147, embedding/content process tooltips shouldn't autohide, r=neil
e048332ea3067fc4031ef72c57259b9a28075373: Bug 1076765 - fix undefined mRadioChildren property in radio.xml. r=Neil
aceman <acelists@atlas.sk> - Fri, 03 Oct 2014 09:11:00 +0200 - rev 208941
Push 9173 by cbook@mozilla.com at Mon, 06 Oct 2014 13:52:21 +0000
Bug 1076765 - fix undefined mRadioChildren property in radio.xml. r=Neil
c94ca8f85baff718ded14b3258c181b16ce4c046: Bug 1006040, animate star panel when pressing escape, add argument to hidePopup to allow indication of whether the popup is being cancelled or not, r=neil
Neil Deakin <neil@mozilla.com> - Wed, 24 Sep 2014 12:15:49 -0400 - rev 207067
Push 8970 by ryanvm@gmail.com at Wed, 24 Sep 2014 21:13:34 +0000
Bug 1006040, animate star panel when pressing escape, add argument to hidePopup to allow indication of whether the popup is being cancelled or not, r=neil
8e2aa21fc19fdc4fd3d79343af033fb2f8a8ac69: Bug 1053166 Part 2 Remove trailing whitespace in blank lines and comments r=Neil DONTBUILD NPOTDB
Philip Chee <philip.chee@gmail.com> - Fri, 12 Sep 2014 00:30:37 +0800 - rev 204895
Push 8691 by ryanvm@gmail.com at Thu, 11 Sep 2014 22:25:11 +0000
Bug 1053166 Part 2 Remove trailing whitespace in blank lines and comments r=Neil DONTBUILD NPOTDB
102668136c5f52d27db4a59be4444bf59bd8f240: Bug 1063469 - fix some trivial "assignment to undeclared variable" in extApplication.js. r=Neil
aceman <acelists@atlas.sk> - Wed, 10 Sep 2014 07:49:00 +0100 - rev 204502
Push 8652 by cbook@mozilla.com at Wed, 10 Sep 2014 13:16:27 +0000
Bug 1063469 - fix some trivial "assignment to undeclared variable" in extApplication.js. r=Neil
2ecfd77b0b8c74f16ecf556ca7e0fa2050c459a9: Bug 1020548 - update aria-orientation impl to ARIA 1.1, r=tbsaunde, sr=neil
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 11 Aug 2014 08:13:44 -0400 - rev 198897
Push 8144 by ryanvm@gmail.com at Mon, 11 Aug 2014 21:19:37 +0000
Bug 1020548 - update aria-orientation impl to ARIA 1.1, r=tbsaunde, sr=neil
1be6287cde8ab511283559b1f7a3645d4af6c7bd: Bug 251903 - Autoscroll does not function as expected when in an iframe. r=Neil
Martijn Wargers <mwargers@mozilla.com> - Wed, 23 Jul 2014 13:57:54 +0200 - rev 197692
Push 8037 by ryanvm@gmail.com at Mon, 04 Aug 2014 20:24:04 +0000
Bug 251903 - Autoscroll does not function as expected when in an iframe. r=Neil
963723a2077d585c2cb00025622ed30bdd3d1148: Bug 1047873 - Flatten xpfe/appshell/{public,src}/ directories. r=Neil
Birunthan Mohanathas <birunthan@mohanathas.com> - Sat, 02 Aug 2014 13:44:23 -0700 - rev 197582
Push 8037 by ryanvm@gmail.com at Mon, 04 Aug 2014 20:24:04 +0000
Bug 1047873 - Flatten xpfe/appshell/{public,src}/ directories. r=Neil
1340475e69545864d57c0fb4d5ed4cbf2fb58584: Bug 251903 - autoscroll does not function as expected when in an iframe. r=neil
Martijn Wargers <mwargers@mozilla.com> - Wed, 23 Jul 2014 13:57:54 +0200 - rev 195914
Push 7905 by cbook@mozilla.com at Fri, 25 Jul 2014 07:51:03 +0000
Bug 251903 - autoscroll does not function as expected when in an iframe. r=neil
c1ddceb19abc60b28624e6efe7099e6715456de9: Bug 1038635 - zoom doesn't work in the email composer. r=neil
Magnus Melin <mkmelin+mozilla@iki.fi> - Fri, 18 Jul 2014 13:02:14 +0300 - rev 194893
Push 7810 by ryanvm@gmail.com at Fri, 18 Jul 2014 20:08:45 +0000
Bug 1038635 - zoom doesn't work in the email composer. r=neil
5a5d9f2a29ca0ab220d582a4e3fd8465423accbd: Bug 1037264 - Add an 8-bit short-lived string cache. r=neil
Bobby Holley <bobbyholley@gmail.com> - Tue, 15 Jul 2014 16:30:51 -0700 - rev 194308
Push 7759 by cbook@mozilla.com at Wed, 16 Jul 2014 14:01:39 +0000
Bug 1037264 - Add an 8-bit short-lived string cache. r=neil
4bbe15384faa748131d0c248fbc5d89f705b5462: Bug 1037264 - Factor out short-lived string buffer into a templated helper class. r=neil
Bobby Holley <bobbyholley@gmail.com> - Tue, 15 Jul 2014 16:30:50 -0700 - rev 194307
Push 7759 by cbook@mozilla.com at Wed, 16 Jul 2014 14:01:39 +0000
Bug 1037264 - Factor out short-lived string buffer into a templated helper class. r=neil
c93d64f6a76a4b4b9b5513272362fce2a4fee426: Bug 1027057, use nsLayoutUtils::HasCurrentAnimations to check for transitions when hiding the popup, r=neil
Neil Deakin <neil@mozilla.com> - Mon, 14 Jul 2014 13:39:04 -0400 - rev 193946
Push 7733 by cbook@mozilla.com at Tue, 15 Jul 2014 14:19:19 +0000
Bug 1027057, use nsLayoutUtils::HasCurrentAnimations to check for transitions when hiding the popup, r=neil
f32dd267971e261704d3cd9a61edb9dd2cfc79b7: Bug 1026310, set the open state only once the opening transition is finished, rename the internal popup states to be clearer, fix UITour.jsm to check the showing state, r=MattN,neil
Neil Deakin <neil@mozilla.com> - Mon, 14 Jul 2014 13:39:04 -0400 - rev 193943
Push 7733 by cbook@mozilla.com at Tue, 15 Jul 2014 14:19:19 +0000
Bug 1026310, set the open state only once the opening transition is finished, rename the internal popup states to be clearer, fix UITour.jsm to check the showing state, r=MattN,neil
a0f06500edd1713c44e70507d2b0efea8cfdfb10: Bug 1036777 - Fix string casts to be safe per-XPIDL. r=neil
Bobby Holley <bobbyholley@gmail.com> - Fri, 11 Jul 2014 19:21:23 -0700 - rev 193745
Push 7719 by cbook@mozilla.com at Mon, 14 Jul 2014 13:24:23 +0000
Bug 1036777 - Fix string casts to be safe per-XPIDL. r=neil These types map to nsAString and nsACString respectively.
9f6e47d8296d2df67a2ef4e5b5ee5717712d004c: Bug 1036777 - Stop relying on useAllocator for 'in' string classes in ConvertIndependentParam. r=neil
Bobby Holley <bobbyholley@gmail.com> - Fri, 11 Jul 2014 19:21:22 -0700 - rev 193743
Push 7719 by cbook@mozilla.com at Mon, 14 Jul 2014 13:24:23 +0000
Bug 1036777 - Stop relying on useAllocator for 'in' string classes in ConvertIndependentParam. r=neil
a5a361e955d19f8e89d73d759cbb1415d066e95c: Bug 1027993 - Remove plstr.h usages under xpfe. r=neil
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Jun 2014 13:58:43 +0900 - rev 189994
Push 7399 by ryanvm@gmail.com at Mon, 23 Jun 2014 14:59:50 +0000
Bug 1027993 - Remove plstr.h usages under xpfe. r=neil
0e9d11e5302ac3a421a0de44283b47b9465fb42e: Bug 994117, delay popupshown event until after the opening transition has finished, if one exists, which also fixes the issue causing bug 989991, so enable the animation on the main panel, r=neil
Neil Deakin <neil@mozilla.com> - Mon, 16 Jun 2014 14:43:07 -0400 - rev 188956
Push 7321 by cbook@mozilla.com at Tue, 17 Jun 2014 12:35:52 +0000
Bug 994117, delay popupshown event until after the opening transition has finished, if one exists, which also fixes the issue causing bug 989991, so enable the animation on the main panel, r=neil
24f124582f70a64103835464160441bc0a449c69: Bug 870205 - Fix intermittent browser_bug295977_autoscroll_overflow.js. r=neil
Drew Willcoxon <adw@mozilla.com> - Thu, 05 Jun 2014 10:50:33 -0700 - rev 186808
Push 7148 by dwillcoxon@mozilla.com at Thu, 05 Jun 2014 17:50:54 +0000
Bug 870205 - Fix intermittent browser_bug295977_autoscroll_overflow.js. r=neil