searching for reviewer(mats)
a0008dd33cf4ef5a733c431c163dbd3793234a2f: Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319895
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats MozReview-Commit-ID: LFQfKPlR9Gv
75b58c4e61e6e51ca6d738b3a3d599476e4e9b89: Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319894
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats Right now, there's only one flag in this new class (with no usages until a later patch). This flag suppresses a hack, which otherwise makes us transparently reverse the child list & flex axes in some circumstances, to prevent bottom-to-top child ordering. (We don't want that hack when we're dealing with individual abspos children, since it only makes things more complicated.) MozReview-Commit-ID: HYUf0vjlfiJ
fb7655f3e1cf3bf9635da9e434eb7da6cf6800f9: Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319893
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats Right now, this method has only one stub impl, in nsContainerFrame; a later patch will add a more interesting (overriding) impl in nsFlexContainerFrame. MozReview-Commit-ID: 3U3vTTX4vdm
8088e5a9e6e322731d4a3008642b54a1fc0774b1: Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319892
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats (We'll react to the ReflowInput flags and do the actual CSS Box Alignment in a later patch in this series.) MozReview-Commit-ID: EZd7npWSzQI
eea6479452f0be2d7ee98f6d537106f6fe8a0d50: Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319891
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats MozReview-Commit-ID: GZ35iZ2E1Iz
eb4b52bf06ec8c1f5b33cfba7255a0d4bb64c168: Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319890
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats MozReview-Commit-ID: 5tvCIEhAsPH
539db74e4a889a6dc0605f91ff40ab7e748b996d: Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319889
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats MozReview-Commit-ID: 1Eh2CreOLTC
f57f9ac1435edc2d581c4645fa818ffd665d68f7: Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319888
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats MozReview-Commit-ID: 5rGemcMMOhl
2162d5c9fb54f3e1b993add441287216534b0b9c: Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319887
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats This patch also: * Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore. * Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly). MozReview-Commit-ID: 8canWfXk6Kf
7aa8199183fca08ca7d9b309fa01580affb45da7: Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319886
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats MozReview-Commit-ID: 5lXUsusLryC
86a391e3e1638407465610b0dc5b5fc4694a0a08: Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:25 -0700 - rev 319885
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats This patch makes the following specific changes: (1) Adds an early-return to both versions of the IsOrderLEQ function, to treat placeholder children as LEQ everything (including each other). This will tend to sort them to the beginning of the child list, which is unimportant but fine. More importantly, though: this means our "order"-sorting code won't reorder placeholders *with respect to each other* (since our sort algorithm is stable). So their painting order won't be affected by the "order" property, which is required by the spec. (2) Drops some nsPlaceholderFrame::GetRealFrameFor() calls -- they're unnecessary, since any placeholder frames will have prompted us to return earlier. One caveat to (2): this patch does leave a few "nsPlaceholderFrame::GetRealFrameFor()" calls in place, *for the moment*. These remaining calls are for handling placeholders that are wrapped, i.e. inside of anonymous flex items. These calls are still needed to avoid assertion-failures (i.e. to get a consistent ordering) at this point, but they'll be removed in a later patch in this same bug, when we stop wrapping placeholders in anonymous flex items. MozReview-Commit-ID: 1R6NW30Kxgv
ae632144724fc5efae24a32acab2d7d938384123: Bug 1313421 part 2: Use flex container's FlexLine linked-list to determine the first flex item, rather than its child-frame list. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:48 -0700 - rev 319883
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313421 part 2: Use flex container's FlexLine linked-list to determine the first flex item, rather than its child-frame list. r=mats This shouldn't change our behavior right now, but it will make a difference after bug 1269045 -- when that bug lands, we'll have nsPlaceholderFrames (which are not flex items) in the child-frame list, which means we can't depend on its first entry being a flex item anymore. MozReview-Commit-ID: KRXYaK8R8bc
c565ba669d962165dc90b99f77b0b26d4acb4d92: Bug 1313421 part 1: Unconditionally cache a FlexItem's ascent, after it's been reflowed. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:41 -0700 - rev 319882
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313421 part 1: Unconditionally cache a FlexItem's ascent, after it's been reflowed. r=mats This removes a (very minor) optimization. The optimization was simply that we avoided storing this nscoord value, if we could tell that we weren't ever going to need it. Now it's becoming a bit more complicated to prove that we'll never need it, so we might as well just store it unconditionally. MozReview-Commit-ID: 94FFc9SO516
46a855ae9e4b59c29580aca18afc9648fbc5ed2a: Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats
Xidorn Quan <me@upsuper.org> - Tue, 25 Oct 2016 17:25:10 +1100 - rev 319531
Push 20745 by philringnalda@gmail.com at Thu, 27 Oct 2016 01:57:01 +0000
Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats MozReview-Commit-ID: J5Fp0iAEnkg
9b715399e5859fd5a7382199f5999c87cef39287: Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats
Xidorn Quan <me@upsuper.org> - Tue, 25 Oct 2016 17:25:10 +1100 - rev 319511
Push 20745 by philringnalda@gmail.com at Thu, 27 Oct 2016 01:57:01 +0000
Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats MozReview-Commit-ID: J5Fp0iAEnkg
9a8d5add5a55f368055c7425dd95a3a722d81b2b: Bug 1311865: Refactor the grid "same sides" code into a simpler WritingMode::ParallelAxisHasSamePolarity() utility function. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 17:45:07 -0700 - rev 318908
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1311865: Refactor the grid "same sides" code into a simpler WritingMode::ParallelAxisHasSamePolarity() utility function. r=mats MozReview-Commit-ID: G9FRriSlZaG
713fd01584d9616f9483bf6204ee230d3cd9108c: Bug 1309982. Check if presshell is destroying before proceeding to do more work in PresShell::ReconstructFrames. r=mats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 20 Oct 2016 16:42:16 -0500 - rev 318884
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1309982. Check if presshell is destroying before proceeding to do more work in PresShell::ReconstructFrames. r=mats PresShell::Destroy calls destroy on the frame constructor/manager, which clears it's local presshell pointer, thus causing us to crash.
06d4b91875087e77e8a6569b5df9db9b1ade7569: Bug 1309119 part 4: Make the scrollframe, button, & fieldset anonymous inner boxes inherit -webkit-box container CSS properties. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 13:23:52 -0700 - rev 318872
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1309119 part 4: Make the scrollframe, button, & fieldset anonymous inner boxes inherit -webkit-box container CSS properties. r=mats (We already do this for the properties that we use to configure modern flexbox.) MozReview-Commit-ID: KStEZ42FIqB
40f9955c5b70c06021107a998932ad0c9474b554: Bug 1309119 part 3: Change nsCSSFrameConstructor to use nsFlexContainerFrame::IsLegacyBox instead of its own less-complete version. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 13:23:51 -0700 - rev 318871
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1309119 part 3: Change nsCSSFrameConstructor to use nsFlexContainerFrame::IsLegacyBox instead of its own less-complete version. r=mats MozReview-Commit-ID: 5sElULdTkOT
e437737fedc8fc8f6b0e94878f423a78fad13f84: Bug 1309119 part 2: Make nsFlexContainerFrame::IsLegacyBox assert that legacy -webkit-box elements are backed by nsFlexContainerFrame. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 13:23:51 -0700 - rev 318870
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1309119 part 2: Make nsFlexContainerFrame::IsLegacyBox assert that legacy -webkit-box elements are backed by nsFlexContainerFrame. r=mats MozReview-Commit-ID: 62VsCtKJg3C
b05f66ffb5529b94e7424f479e65e3a1099d5b36: Bug 1309119 part 1: Expose nsFlexContainerFrame helper-function IsLegacyBox as a static method. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 13:23:51 -0700 - rev 318869
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1309119 part 1: Expose nsFlexContainerFrame helper-function IsLegacyBox as a static method. r=mats MozReview-Commit-ID: 8fztWk2sp0L
35f88c160489ddf0c8db02a25c4816cffcf7e65d: Bug 1309119 part 0: Add reftest (variant of existing reftest webkit-box-anon-flex-items-1.html, with "overflow:hidden"). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 13:23:51 -0700 - rev 318868
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1309119 part 0: Add reftest (variant of existing reftest webkit-box-anon-flex-items-1.html, with "overflow:hidden"). r=mats This reftest currently has a "fails" annotation, which will be removed by a later patch in this series (the final part of the fix). MozReview-Commit-ID: 9s11bdd7sFc
db8c5ee6d069306d5b5553e0ec6f2bb6d2224036: Bug 1263357 - When the caret is placed after visible line break, associate caret with frame on the next line instead. r=mats
Jorg K <jorgk@jorgk.com> - Fri, 14 Oct 2016 14:21:00 -0400 - rev 318159
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1263357 - When the caret is placed after visible line break, associate caret with frame on the next line instead. r=mats
1a30ac62cb4e0fe211e865cf4cdd40e5bcb74f05: Bug 1192053 - Add support for vibrant tree rows in nsTreeBodyFrame.cpp. r=mats.
stefanh@inbox.com - Fri, 14 Oct 2016 22:45:22 +0200 - rev 318129
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1192053 - Add support for vibrant tree rows in nsTreeBodyFrame.cpp. r=mats.
b827ae5bb9e3fbbbc008d66bd9913e0754c900c9: Bug 1235922 Part 5: Extend flexbox "align-content" reftests to test new "space-evenly" value. r=mats
Brad Werth <bwerth@mozilla.com> - Sat, 15 Oct 2016 12:25:23 -0700 - rev 318080
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1235922 Part 5: Extend flexbox "align-content" reftests to test new "space-evenly" value. r=mats MozReview-Commit-ID: BtQUxkAr0nH
e709bed8b91826a2b2bd7f8dfc78491ba82f4f30: Bug 1235922 Part 4: Add support for "align-content: space-evenly" to flexbox layout. r=mats
Brad Werth <bwerth@mozilla.com> - Fri, 14 Oct 2016 17:17:33 -0700 - rev 318079
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1235922 Part 4: Add support for "align-content: space-evenly" to flexbox layout. r=mats MozReview-Commit-ID: 3ETuPrIURJ3
ae5fd22471440e2a29dd830a64c51b20c04840da: Bug 1235922 Part 3: Extend flexbox "justify-content" reftests to test new "space-evenly" value. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 11 Oct 2016 14:30:13 -0700 - rev 318078
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1235922 Part 3: Extend flexbox "justify-content" reftests to test new "space-evenly" value. r=mats MozReview-Commit-ID: JrUdzG5gWTU
c6b2288a20ec19052510571d6b18cee5e1d2f546: Bug 1235922 Part 2: Add support for "justify-content: space-evenly" to flexbox layout. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 14 Oct 2016 17:16:00 -0700 - rev 318077
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1235922 Part 2: Add support for "justify-content: space-evenly" to flexbox layout. r=mats MozReview-Commit-ID: 6Am15EIVAXH
af377e9d9ddb550370153f80707e2ea2350a05d3: Bug 1235922 Part 1: Introduce a helper-function to share code for justify-content and align-content space-around and space-between in flexbox layout. r=mats
Brad Werth <bwerth@mozilla.com> - Fri, 14 Oct 2016 17:23:36 -0700 - rev 318076
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1235922 Part 1: Introduce a helper-function to share code for justify-content and align-content space-around and space-between in flexbox layout. r=mats MozReview-Commit-ID: tncRJiojh
3ccac82a6bcff2da20a93b056a4a21663fc35652: Bug 1310015: Change MainAxisTracker to consistently use NS_STYLE_JUSTIFY constants. r=mats
Brad Werth <bwerth@mozilla.com> - Thu, 13 Oct 2016 14:20:48 -0700 - rev 318051
Push 20713 by cbook@mozilla.com at Mon, 17 Oct 2016 09:37:24 +0000
Bug 1310015: Change MainAxisTracker to consistently use NS_STYLE_JUSTIFY constants. r=mats MozReview-Commit-ID: F8VfIuZJqFa
8002cb8086cd19892c926d7d511db954bde8653b: Bug 1307853 - Add web platform test (in mochitest suite). r=mats
L. David Baron <dbaron@dbaron.org> - Thu, 13 Oct 2016 11:41:52 -0700 - rev 317895
Push 20704 by cbook@mozilla.com at Fri, 14 Oct 2016 10:29:22 +0000
Bug 1307853 - Add web platform test (in mochitest suite). r=mats This test failed with the initial (non-working) version of the patch, and passes with the patch. MozReview-Commit-ID: IPmd7Yh604Z
d61b47e3ac8a46f515978ac9cc2628485650b7f7: Bug 1307853 - Set inline-resize flag when the content-box size is changing (in addition to border-box). r=mats
L. David Baron <dbaron@dbaron.org> - Thu, 13 Oct 2016 11:41:52 -0700 - rev 317894
Push 20704 by cbook@mozilla.com at Fri, 14 Oct 2016 10:29:22 +0000
Bug 1307853 - Set inline-resize flag when the content-box size is changing (in addition to border-box). r=mats MozReview-Commit-ID: FjUwuQB8g5j
c14eb1c3496147a71c5157d5a7c90dfae3a37da7: Bug 1090031: Apply CSS 'align-content' in flex containers if they *could* wrap (rather than if they *have* wrapped). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Oct 2016 09:04:03 -0700 - rev 317702
Push 20699 by cbook@mozilla.com at Thu, 13 Oct 2016 09:59:46 +0000
Bug 1090031: Apply CSS 'align-content' in flex containers if they *could* wrap (rather than if they *have* wrapped). r=mats The spec says that single-line flex containers should stretch their one flex line to the flex container's cross size, and should ignore 'align-content'. Initially, the spec defined 'single-line' to include any flex container that happens to have only 1 line (even if it's got 'flex-wrap:wrap' or 'wrap-reverse'). But later, the term 'single-line' was intentionally redefined to *only* include flex containers that have 'flex-wrap: nowrap'. So, instead of checking the line-count, we should instead check 'flex-wrap', when deciding whether to stretch our one line & ignore 'align-content'. MozReview-Commit-ID: D2ZMIBS16ui
37e0c017b26862daf1f5508b9285c7c1b7e2ceef: Bug 1090031: Apply CSS 'align-content' in flex containers if they *could* wrap (rather than if they *have* wrapped). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Oct 2016 09:04:03 -0700 - rev 317689
Push 20699 by cbook@mozilla.com at Thu, 13 Oct 2016 09:59:46 +0000
Bug 1090031: Apply CSS 'align-content' in flex containers if they *could* wrap (rather than if they *have* wrapped). r=mats The spec says that single-line flex containers should stretch their one flex line to the flex container's cross size, and should ignore 'align-content'. Initially, the spec defined 'single-line' to include any flex container that happens to have only 1 line (even if it's got 'flex-wrap:wrap' or 'wrap-reverse'). But later, the term 'single-line' was intentionally redefined to *only* include flex containers that have 'flex-wrap: nowrap'. So, instead of checking the line-count, we should instead check 'flex-wrap', when deciding whether to stretch our one line & ignore 'align-content'. MozReview-Commit-ID: D2ZMIBS16ui
9a154874f694c3e5b54401d70034591b5861e71a: Bug 1301290 - Position resizer above own content but beneath overlapping content. r=mats
Alex Henrie <alexhenrie24@gmail.com> - Thu, 06 Oct 2016 08:44:00 -0600 - rev 316877
Push 20674 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:46:54 +0000
Bug 1301290 - Position resizer above own content but beneath overlapping content. r=mats
6ffa724dba7370437db8548018f8542e86d7d606: Bug 1307728 - convert LineReflowStatus to an enum class. r=mats
Jeremy Chen <jeremychen@mozilla.com> - Fri, 07 Oct 2016 00:36:07 +0800 - rev 316782
Push 20673 by philringnalda@gmail.com at Fri, 07 Oct 2016 03:23:33 +0000
Bug 1307728 - convert LineReflowStatus to an enum class. r=mats Since we're converting LineReflowStatus to an enum class, the "default:" branch of LineReflowStatusToString() could be removed as well. In this way, we can add protection at compile time (warning) instead of runtime (assertion). MozReview-Commit-ID: 8Ul0eCxqSTR
dc76dc5df6d9ca2c9a883d669724a38f569d7c13: Bug 1307728 - use LineReflowStatusToString to support debugging. r=mats
Jeremy Chen <jeremychen@mozilla.com> - Fri, 07 Oct 2016 00:36:07 +0800 - rev 316781
Push 20673 by philringnalda@gmail.com at Fri, 07 Oct 2016 03:23:33 +0000
Bug 1307728 - use LineReflowStatusToString to support debugging. r=mats This is a pre-patch that uses LineReflowStatusToString() function instead of LineReflowStatusNames array to support debugging. With this patch, we could easily regain debugging support from LineReflowStatusToString() while converting LineReflowStatus to an enum class. MozReview-Commit-ID: K2AzZ2zI69p
1a4288cc3cead7e7026ea5e2594b6041e69dd13b: bug 1307226 - extend clang crash workaround to work around similar crash in SetGridItemCount r=mats
David Keeler <dkeeler@mozilla.com> - Mon, 03 Oct 2016 14:08:54 -0700 - rev 316290
Push 20652 by cbook@mozilla.com at Tue, 04 Oct 2016 10:02:41 +0000
bug 1307226 - extend clang crash workaround to work around similar crash in SetGridItemCount r=mats MozReview-Commit-ID: 1fHN2mpYyxz
abd0f2b6a2d474ea961307cbc5255e332de4c14c: Bug 1300905 - When long-pressing on a selection, don't dismiss the selection and start a new one. Show the context menu instead. r=TYLin,mats
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 30 Sep 2016 09:36:10 -0400 - rev 316080
Push 20637 by philringnalda@gmail.com at Sat, 01 Oct 2016 06:28:47 +0000
Bug 1300905 - When long-pressing on a selection, don't dismiss the selection and start a new one. Show the context menu instead. r=TYLin,mats MozReview-Commit-ID: J0e9DqIDwnC
d40e2abb42d61e0411135c624f9fba88fe6c85c8: Bug 1306213: When resolving a flex item's "align-self: auto", use the flex container (not style-context parent) as the "align-items" source. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 28 Sep 2016 23:53:20 -0700 - rev 315789
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1306213: When resolving a flex item's "align-self: auto", use the flex container (not style-context parent) as the "align-items" source. r=mats (Normally, the style-context parent will *be* the flex container's style context, so this patch won't change behavior at all. But if a flex container has a "display:table" child, then there's an extra style context in the inheritance chain (due to how style inheritance works for nsTableWrapperFrame). And we don't want that extra style context to mess up the ability of a flex container's "align-items" property to actually align the flex items.) MozReview-Commit-ID: GFyxhEwM68S
c684f2f380767b95585e0daf0d88a412a1a674d3: Bug 1300877 - Expose removed grid auto-fit tracks to devtools API. r=mats, r=ehsan
Brad Werth <bwerth@mozilla.com> - Wed, 21 Sep 2016 11:49:29 -0700 - rev 315175
Push 20604 by ihsiao@mozilla.com at Mon, 26 Sep 2016 11:12:23 +0000
Bug 1300877 - Expose removed grid auto-fit tracks to devtools API. r=mats, r=ehsan MozReview-Commit-ID: 3E1au3BQyLw
d343d42820d93970f87058f05e34f02ee624a891: Bug 1278461 - Prevent an assert from tripping when removing an overflowed frame during a partial reflow. r=mats
Brad Werth <bwerth@mozilla.com> - Thu, 22 Sep 2016 12:37:35 -0700 - rev 315020
Push 20596 by cbook@mozilla.com at Fri, 23 Sep 2016 10:50:43 +0000
Bug 1278461 - Prevent an assert from tripping when removing an overflowed frame during a partial reflow. r=mats
058cf01f6cf2d2526c28b864a78afd4b97189b2a: Bug 1304540 part 2: Use nsCOMPtr/RefPtr (and their forget() API) instead of manual NS_ADDREF macros, in a few files within layout. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 21 Sep 2016 15:41:26 -0700 - rev 314917
Push 20596 by cbook@mozilla.com at Fri, 23 Sep 2016 10:50:43 +0000
Bug 1304540 part 2: Use nsCOMPtr/RefPtr (and their forget() API) instead of manual NS_ADDREF macros, in a few files within layout. r=mats MozReview-Commit-ID: SrJNtbwc1B
5fd3903b907579e41b9528e95ca403044da18d6b: Bug 1304540 part 1: minor code-cleanup in the neighborhood of some NS_ADDREF usages. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 21 Sep 2016 15:39:48 -0700 - rev 314916
Push 20596 by cbook@mozilla.com at Fri, 23 Sep 2016 10:50:43 +0000
Bug 1304540 part 1: minor code-cleanup in the neighborhood of some NS_ADDREF usages. r=mats DETAILS ON THE CLEANUP: * In nsFrameTraversal.cpp: - Whitespace fix. - Remove a useless nullptr assignment. - Use "=" to initialize a nsCOMPtr, per coding style guideline ("initialize variables with nsFoo aFoo = bFoo and not nsFoo aFoo(bFoo)"). * In nsPresShell.cpp: - Wrap a longish assignment to 2 lines (since next patch will make the first line longer, which would push the whole thing over 80 characters if it weren't wrapped). - Add braces around "if" body. * In nsTextFrame.cpp: - Remove a useless nullptr assignment. - Move the "metrics->GetThebesFontGroup()" call slightly earlier, so it happens *before* we've implicitly transferred ownership the object pointed to by "metrics". - Add a code-comment. MozReview-Commit-ID: LG6vgOmM9MK
87423892cc1ce99dc57f7f3395aac51afe21573f: Bug 1301856 - Spurious valgrind warning in in CSSParserImpl::ParseGridLine() with gcc 5.3. r=mats@mozilla.com.
Julian Seward <jseward@acm.org> - Wed, 14 Sep 2016 15:04:30 +0200 - rev 313951
Push 20540 by cbook@mozilla.com at Thu, 15 Sep 2016 10:08:00 +0000
Bug 1301856 - Spurious valgrind warning in in CSSParserImpl::ParseGridLine() with gcc 5.3. r=mats@mozilla.com.
31fe1120ff9ab9c7290c07d671a463b50c65f364: Bug 1281446 - Resolved value of grid-template-columns/rows now lists removed auto-fit tracks as 0px. r=mats
Brad Werth <bwerth@mozilla.com> - Thu, 08 Sep 2016 08:40:06 -0700 - rev 313365
Push 20495 by cbook@mozilla.com at Fri, 09 Sep 2016 10:22:18 +0000
Bug 1281446 - Resolved value of grid-template-columns/rows now lists removed auto-fit tracks as 0px. r=mats
cd249dba87c2660f93409a99ca9296386d230345: Bug 1297189 - Expose implicit grid areas via dev tools API. r=mats, r=bz
Brad Werth <bwerth@mozilla.com> - Fri, 02 Sep 2016 16:28:27 -0700 - rev 312939
Push 20470 by cbook@mozilla.com at Wed, 07 Sep 2016 15:25:31 +0000
Bug 1297189 - Expose implicit grid areas via dev tools API. r=mats, r=bz
459476bdc5d6512f4ad30e8c2bd53d4b52c06db8: Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Sep 2016 15:01:09 -0700 - rev 312529
Push 20450 by ryanvm@gmail.com at Sat, 03 Sep 2016 15:45:57 +0000
Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage. r=mats MozReview-Commit-ID: ETITppCzDjo
e11d9697af59672994c6cdc309c97564078b7dc1: Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 29 Aug 2016 15:36:45 +0800 - rev 311779
Push 20417 by ryanvm@gmail.com at Tue, 30 Aug 2016 13:55:34 +0000
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r=mats MozReview-Commit-ID: Jkf7sSqxG2d
c98b8c992c2f3dfc4789deab913ca942ae61f304: Bug 1289200 - Adds GridAreas to grid css dev tools API. r=bz, mats
Brad Werth <bwerth@mozilla.com> - Tue, 23 Aug 2016 13:34:51 -0700 - rev 310816
Push 20383 by gabriel.luong@gmail.com at Wed, 24 Aug 2016 13:10:44 +0000
Bug 1289200 - Adds GridAreas to grid css dev tools API. r=bz, mats