searching for reviewer(maja_zf)
04a3c1c6625c0b6517055502798cfafd1da89a38: Bug 1311676 - Allow MRO for Marionette testcase classes. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Thu, 20 Oct 2016 14:47:51 +0200 - rev 318862
Push 20732 by ryanvm@gmail.com at Fri, 21 Oct 2016 21:17:52 +0000
Bug 1311676 - Allow MRO for Marionette testcase classes. r=maja_zf MozReview-Commit-ID: KpxwIzFucSF
b9b472734bfa43b19779fb9cb984292956534a94: Bug 1261019 - Part 1: Remove support for running marionette tests as apps; r=maja_zf
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 30 Sep 2016 00:36:39 -0400 - rev 317877
Push 20704 by cbook@mozilla.com at Fri, 14 Oct 2016 10:29:22 +0000
Bug 1261019 - Part 1: Remove support for running marionette tests as apps; r=maja_zf
8fef52daf4b5be227469a5603da1211e50c895b6: Bug 1309035 - Addresses insufficient fix from Bug 1307016 by converting to unicode before ascii. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 11 Oct 2016 10:02:16 +1300 - rev 317486
Push 20695 by cbook@mozilla.com at Wed, 12 Oct 2016 10:07:01 +0000
Bug 1309035 - Addresses insufficient fix from Bug 1307016 by converting to unicode before ascii. r=maja_zf Bug 1307016 attempted to address issues with output not being ascii and thus being incompatible with terminals on test machines. However my changes in that bug introduced two issues: - They introduced a bug where field names were being read from an incorrect source. - They attempted to construct a string internally then converted that string to ascii replacing non-ascii chars. This is an issue as in python 2 strings are implicitly ascii, so the initial conversion to a string would fail if the underlying object couldn't be represented as ascii. Both of these issues are addressed here. The first by fixing the bad source in the code, the second by converting to unicode for the intermediate representation. MozReview-Commit-ID: HC6Fd9TLRe2
cada890e8220de534eaa185bcb4f486ceb9f8883: Bug 1291687 - Ensure string formatting is using `format()` instead of `%` for all Marionette py files: r=maja_zf
Francesco Pischedda <francesco.pischedda@gmail.com> - Wed, 28 Sep 2016 21:39:00 +0200 - rev 317069
Push 20681 by philringnalda@gmail.com at Sat, 08 Oct 2016 23:57:20 +0000
Bug 1291687 - Ensure string formatting is using `format()` instead of `%` for all Marionette py files: r=maja_zf MozReview-Commit-ID: LdB3uvuqva0
c0817cce76da48fb6bfb3ff4111bed9f5de4603a: Bug 1307016 - Have puppeteer __str__ encode fields to ascii. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 03 Oct 2016 11:56:50 +1300 - rev 316650
Push 20665 by cbook@mozilla.com at Thu, 06 Oct 2016 10:29:09 +0000
Bug 1307016 - Have puppeteer __str__ encode fields to ascii. r=maja_zf At least some of the environments the tests are running in do not appear to play nice with non-ascii characters. Some of the jenkins runs are currently unhappy due to this. This patch sees that all fields are encoded as ascii with non-compatible characters replaced. MozReview-Commit-ID: 6qSCyUujMLE
199c73e2737df4e74dce37cfa1d139f0ed873f02: Bug 1305598 - Ensure parent directory of virtualenv directory exists; r=maja_zf
Gregory Szorc <gps@mozilla.com> - Wed, 28 Sep 2016 13:41:51 -0700 - rev 315587
Push 20623 by cbook@mozilla.com at Thu, 29 Sep 2016 09:49:42 +0000
Bug 1305598 - Ensure parent directory of virtualenv directory exists; r=maja_zf The virtualenv is placed in the "work dir" by default. If we clobber the "work dir" at the beginning of the job, the parent directory of the virtualenv may not exist and virtualenv creation will fail because we set cwd to the work dir. Fix that by ensuring the work dir / cwd always exists when creating the virtualenv. MozReview-Commit-ID: FAZPP1Sm22k
a14b893971a6b4bdaa5d8283a1afac5ad8a846be: Bug 1305607 - Correct reading of baseURI from video element. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 27 Sep 2016 15:35:57 +1300 - rev 315396
Push 20616 by cbook@mozilla.com at Wed, 28 Sep 2016 14:38:03 +0000
Bug 1305607 - Correct reading of baseURI from video element. r=maja_zf Previous changes that I'd made broke the reporting of the baseURI on videos. This changeset aims to fix those breakages, and also puts the baseURI on the state snapshot. MozReview-Commit-ID: 8YgPpHzoX1E
cdb6410f3b71e713b6de2213201cd8180fa20658: Bug 1305370 - Bump firefox-puppeteer 52.0.0. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Mon, 26 Sep 2016 15:35:59 +0200 - rev 315258
Push 20607 by cbook@mozilla.com at Tue, 27 Sep 2016 09:27:46 +0000
Bug 1305370 - Bump firefox-puppeteer 52.0.0. r=maja_zf MozReview-Commit-ID: IdVUoenRYMh
89fc0a741450051c0243a264f0c8ee4ceb071395: Bug 1304961 - Retrieve buffered ranges in VideoPuppeteer. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 23 Sep 2016 17:52:57 +1200 - rev 315097
Push 20604 by ihsiao@mozilla.com at Mon, 26 Sep 2016 11:12:23 +0000
Bug 1304961 - Retrieve buffered ranges in VideoPuppeteer. r=maja_zf Update VideoPuppeteer and make small changes in YoutubePuppeteer to support retrieval of buffered ranges for wrapped video element. This will help diagnose test failures, particularly stalls we're having at the moment. Because the namedtuple storing state has all its fields logged the __str__ methods of the puppeteers don't need to be updated, the new field will be logged automatically. MozReview-Commit-ID: LYwXJfB71RE
9efa0b30eab2794efca785b24a19934d9a112dbd: Bug 1304961 - Rename variables storing played ranges to be more specific. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 23 Sep 2016 17:24:40 +1200 - rev 315096
Push 20604 by ihsiao@mozilla.com at Mon, 26 Sep 2016 11:12:23 +0000
Bug 1304961 - Rename variables storing played ranges to be more specific. r=maja_zf The played ranges being retrieved in VideoPuppeteer and YoutubePuppeteer were often referenced as some variation of 'time ranges'. This patch makes that more specific and references the played ranges as variations of 'played ranges'. This removes ambiguity if other time ranges are retrieved in future, such as the buffered ranges. MozReview-Commit-ID: CInjDCCIQkV
70c6f01a830b3a39eb8ac1abf828312de48579aa: Bug 1303497 - Fix failure in test_window_management.py for new window checks. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Thu, 22 Sep 2016 18:22:08 +0200 - rev 314919
Push 20596 by cbook@mozilla.com at Fri, 23 Sep 2016 10:50:43 +0000
Bug 1303497 - Fix failure in test_window_management.py for new window checks. r=maja_zf MozReview-Commit-ID: DbkRrRQvlTb
e3cff5e3ae3cc1b20d4861e7934e54c9e407a750: Bug 1300653 - Update youtube puppeteer to store snapshots of state to prevent racing. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 21 Sep 2016 15:38:41 +1200 - rev 314752
Push 20591 by cbook@mozilla.com at Thu, 22 Sep 2016 11:42:18 +0000
Bug 1300653 - Update youtube puppeteer to store snapshots of state to prevent racing. r=maja_zf This is follow up work to the VideoPuppeteer changes that have it take snapshots to prevent racing. For this work the motivations are the same: prevent racing by querying a stable snapshot of video state, rather than making sequential JS requests to the browser between which video state may change. Much of the YouTubePuppeteer has been made internal, so the class can encapsulate its snapshotting. The property methods have been rolled into the snapshotted data named tuple to make it clear they're derived from snapshotted data. A number of broken parts of the code have been removed or reworked: - Disabling autoplay was not working and has been removed. This is partially addressed by using embedded URLs (in another commit) -- embedded videos do not play next video automatically. However, there may be merit in reinstating a working version of this in future if possible - particularly for videos that can't be embedded, which we have some of in our tests. - Ad skipping was not working. The getOption('ad', 'displaystate') JS call appears to always report an ad is not skippable even if it is. Code related to skipping ads has been removed for now, and ads are waited out. This may also be something worth revisiting if a working implementation is possible. *** Review feedback: update YT puppeteer to use more concise calling conventions, compatibility with changes to VideoPuppeteer. MozReview-Commit-ID: CCxf9ItFYtl
2627ef51142249e474b1a8facefd36306c5f4987: Bug 1300653 - Update VideoPuppeteer to store state snapshots to prevent racing. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 21 Sep 2016 14:08:34 +1200 - rev 314751
Push 20591 by cbook@mozilla.com at Thu, 22 Sep 2016 11:42:18 +0000
Bug 1300653 - Update VideoPuppeteer to store state snapshots to prevent racing. r=maja_zf The tests that use VideoPuppeteer often expect the state queried by the puppeteer to be consistent if done closely in the code. However, this has not been the case, as there can be significant lags in the data returning from marionette. This means that if one line queries the current time of the underlying video, and the very next line queries the same thing, there can be significantly different results. This causes issues with tests making multiple sequential checks on the underlying video, and the state changing between checks. On test fails it means that the information logged my be inconsistent with the state that resulted in the test failing, as time passes between the fail check and the logging. This patch attempts to address this by having the VideoPuppeteer store a snapshot of state and examining that instead. This snap shot should be internally consistent. I've removed a large number of public members from the class, and moved a couple of the testing functions into the class. The thinking here is that the new logic complicates the internal state of the class, and I want to keep the interface slim to hide that complexity. *** Review feedback: Log interval, expected duration, stall wait time, and timeout times in VideoPuppeteer string. *** Review feedback: make video var script a class var instead of a staticmethod. *** Review feedback: move _fetch_state_script to be a property on VideoPuppeteer. *** Review feedback: simplify calling of _create_video_state_info with a dict. Fix played docstring. *** Review feedback: simplify _create_video_state_info using kwargs. MozReview-Commit-ID: 6mN56bFMge0
0a60d2f3b7027f9230d07e764fa2a48bf92140ee: Bug 1299207 - Remove unused imports in test_click.py; r=maja_zf
bhuvi96 <bhuvnesh13396@gmail.com> - Thu, 15 Sep 2016 21:51:21 +0530 - rev 314277
Push 20558 by philringnalda@gmail.com at Sat, 17 Sep 2016 21:01:25 +0000
Bug 1299207 - Remove unused imports in test_click.py; r=maja_zf MozReview-Commit-ID: 9dDvAcsbZnS
85647c98a7909549bc4e98167909a0363e4be6fc: Bug 1302958 - Dump the list of downloaded safebrowsing files if one file has not been downloaded. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Fri, 16 Sep 2016 12:33:07 +0200 - rev 314256
Push 20556 by kwierso@gmail.com at Fri, 16 Sep 2016 21:35:54 +0000
Bug 1302958 - Dump the list of downloaded safebrowsing files if one file has not been downloaded. r=maja_zf MozReview-Commit-ID: GavpDh915zY
8bce29dda76e4e5d09eb7d91ef4e335629d6861f: Bug 1302172 - [mozlint] Convert unittest tests to use pytest instead, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 09 Sep 2016 16:20:09 -0400 - rev 313924
Push 20540 by cbook@mozilla.com at Thu, 15 Sep 2016 10:08:00 +0000
Bug 1302172 - [mozlint] Convert unittest tests to use pytest instead, r=maja_zf MozReview-Commit-ID: D4bN62QbkKm
f282dae81f23849a2fec001df6970fcbd2ff7093: Bug 1290806 - Fix TestSwitchWindow.test_windows by waiting for the newly opened window. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Thu, 08 Sep 2016 18:00:36 +0200 - rev 313920
Push 20540 by cbook@mozilla.com at Thu, 15 Sep 2016 10:08:00 +0000
Bug 1290806 - Fix TestSwitchWindow.test_windows by waiting for the newly opened window. r=maja_zf MozReview-Commit-ID: 750cIdl27CZ
1f902d2cb8aea3362ef62ad1d4d875a9d31fb58f: Bug 1286075: add a (temporary) marionette-harness kind; r=maja_zf
Dustin J. Mitchell <dustin@mozilla.com> - Thu, 08 Sep 2016 00:32:50 +0000 - rev 313718
Push 20528 by ryanvm@gmail.com at Wed, 14 Sep 2016 00:48:16 +0000
Bug 1286075: add a (temporary) marionette-harness kind; r=maja_zf This has some notes for future work on the task, but will work for now. MozReview-Commit-ID: 7J4tQeKj3KJ
2caae0bb972b461e708f8e28ee2253c0f10f82ce: Bug 1286075: drop gecko.v1 routes from tc(Mn-h); r=maja_zf
Dustin J. Mitchell <dustin@mozilla.com> - Tue, 09 Aug 2016 14:22:59 +0000 - rev 313681
Push 20528 by ryanvm@gmail.com at Wed, 14 Sep 2016 00:48:16 +0000
Bug 1286075: drop gecko.v1 routes from tc(Mn-h); r=maja_zf v1 routes aren't used anymore, as far as I know, MozReview-Commit-ID: 8t0j8DXUxik
76d5fdf2aa3d24f254e48820938c1727440a1ae9: Bug 1301661 - Completely remove default value of 360s for socket_timeout r=maja_zf
Henrik Skupin <mail@hskupin.info> - Mon, 12 Sep 2016 13:03:06 +0200 - rev 313537
Push 20519 by kwierso@gmail.com at Tue, 13 Sep 2016 00:23:36 +0000
Bug 1301661 - Completely remove default value of 360s for socket_timeout r=maja_zf MozReview-Commit-ID: 2xaWEAgSsTC
91f2632c762821bae27aeb4d2066255ee0136d36: Bug 1301598 - Fix test_ssl_disabled_error_page.py to timeout after 30s for the page load r=maja_zf
Henrik Skupin <mail@hskupin.info> - Fri, 09 Sep 2016 10:12:07 +0200 - rev 313402
Push 20499 by philringnalda@gmail.com at Sat, 10 Sep 2016 07:18:37 +0000
Bug 1301598 - Fix test_ssl_disabled_error_page.py to timeout after 30s for the page load r=maja_zf MozReview-Commit-ID: EeNRLb2EzVI
d4060d4f4f6771608e0c4ee6fc62e430b6f244c0: Bug 1301153 - Split-up marionette_test module into distinct modules. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Wed, 07 Sep 2016 22:58:36 +0200 - rev 313314
Push 20495 by cbook@mozilla.com at Fri, 09 Sep 2016 10:22:18 +0000
Bug 1301153 - Split-up marionette_test module into distinct modules. r=maja_zf marionette_test.py is a bloated module which contains everything around the Marionette testcase classes. We should split this up into distinct modules, so each new module covers specific code. The two new modules introduced are errors, and decorators. This split would also be aligned to the structure of the driver. To not loose backward compatibility we have to keep the import from marionette_test. It means the new modules have to live in a sub folder named like that. MozReview-Commit-ID: DQg55M258ST
c0804fb00f7043440e9a317b5f5bca7660ab1440: Bug 1284238 - Test that manifest tests are filtered with correct settings; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Thu, 08 Sep 2016 14:20:28 +0200 - rev 313247
Push 20492 by kwierso@gmail.com at Thu, 08 Sep 2016 22:29:45 +0000
Bug 1284238 - Test that manifest tests are filtered with correct settings; r=maja_zf Add tests to ensure that the arguments passed to the call to `manifest.active_tests` from within `runner.add_test` are correct, based on the runner's settings for e.g. e10s and test tags. Add helper function for setup for these tests to avoid duplication. MozReview-Commit-ID: CsaDm7cSyZf
f58548c8be5435349920d00eebce9d471c118ee4: Bug 1284238 - Split manifest fixture into non/parametrized versions; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Thu, 08 Sep 2016 13:45:55 +0200 - rev 313246
Push 20492 by kwierso@gmail.com at Thu, 08 Sep 2016 22:29:45 +0000
Bug 1284238 - Split manifest fixture into non/parametrized versions; r=maja_zf Move the ManifestFixture class out of the `manifest_fixture` function, and rename that function to `manifest_with_tests`. Create a new, simpler manifest fixture without parametrization, called `manifest`. This allows us to use the mocking-out done in the ManifestFixture class in tests where we don't actually need the parametrization of the `active_tests` attribute. MozReview-Commit-ID: xuBn4QxApf
0569d570905b502abccc90b1b25436424766fc05: Bug 1285299 - Use pytest_mozlog plugin in Mn-h mozharness script; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Mon, 05 Sep 2016 16:44:40 +0200 - rev 313245
Push 20492 by kwierso@gmail.com at Thu, 08 Sep 2016 22:29:45 +0000
Bug 1285299 - Use pytest_mozlog plugin in Mn-h mozharness script; r=maja_zf Modify the mozharness script for the Marionette harness tests to use the new pytest_mozlog plugin, so that the logs produced will be parseable by Treeherder. Change the arguments passed to `pytest.main` to instruct pytest_mozlog to write log files in TBPL, mach, and raw (structured log) formats. Read the TBPL log into the mozharness script log itself, and upload all pytest-mozlog log files to the default blob upload dir as specified in the Mozharness BaseScript. MozReview-Commit-ID: HoEK2M1XGwN
60856a997b32a1866523c230e4a73509d78ea568: Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 05 Sep 2016 11:02:07 +1200 - rev 312888
Push 20470 by cbook@mozilla.com at Wed, 07 Sep 2016 15:25:31 +0000
Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP. r=maja_zf - Use format() instead of old style formatting (%s, etc). - Remove unneeded positional args on format strings. - Break some long lines for pep8 conformance. - Use brackets instead of \ to continue long lines. - Log interval on video puppeteer. - Remove an unneeded media source check. We have explicit media source checks in tests, and the media source prefix has changed, rendering the check broken. MozReview-Commit-ID: 4FPVoOD0P5B
431b256767ded293d7988f4da51773f54abc8e3e: Bug 1274943 - Ensure to wait for the update dialog after a forced fallback. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Tue, 06 Sep 2016 11:55:54 +0200 - rev 312825
Push 20466 by kwierso@gmail.com at Wed, 07 Sep 2016 00:37:21 +0000
Bug 1274943 - Ensure to wait for the update dialog after a forced fallback. r=maja_zf MozReview-Commit-ID: 7i9SwSbm0p0
8f3ac8b34fa9d8b6cdd1783022e257b18913b9cf: Bug 1299756 - VideoPuppeteer: Use played ranges in determining time remaining. Relax playback done check. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Sep 2016 14:51:19 +1200 - rev 312365
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1299756 - VideoPuppeteer: Use played ranges in determining time remaining. Relax playback done check. r=maja_zf The VideoPuppeteer now uses played ranges where possible to calculate the remaining time. It will also use the played ranges to determine the expected duration where possible. This is more accurate than using the time when the tests first poll the video. The first poll time was previously self._start_time, but I've renamed this to self._first_seen_time, to reduce ambiguity -- the video may have started playing before this time. The playback_done function has had it's remaining time check relaxed. Previously it was possible to skip over the window where a video would be considered complete, that window is now expanded so that if the start threshold is passed the video is considered played. A concrete example: the tests could play a 90 second video, but the duration of the test is set to 60 so only part of the video need be played back before the test completes. If a 1 second interval was used in the tests there would be a window between 59 to 61 seconds during which if the video were polled it would be considered complete. However, due to latency polling may not take place in this window, leading to racy fails. Now the tests will consider any point beyond 59 seconds to be complete. MozReview-Commit-ID: J6DpqCbZxUg
1f2c133d78b14c9b3faea5c31f70b94e90df0b8d: Bug 1299756 - Update VideoPuppeteer __str__ to output played ranges. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 01 Sep 2016 10:50:05 +1200 - rev 312364
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1299756 - Update VideoPuppeteer __str__ to output played ranges. r=maja_zf This is a quality of life change. Since VideoPuppeteer uses, and since I plan on using the played ranges of a video element more, it is useful to output them as part of the str representation. MozReview-Commit-ID: LwVPfVtFF1v
4686f24bce9724843410be75b309896d50ff33ea: Bug 1299042 - Fix test_safebrowsing_initial_download for OSError. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Thu, 01 Sep 2016 13:33:49 +0200 - rev 312335
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1299042 - Fix test_safebrowsing_initial_download for OSError. r=maja_zf MozReview-Commit-ID: 1ChV6HHXYg2
6795225dc65f98d2c5007e1bf8e0b7ffb2265e38: Bug 1298233 - Skip test for platform buildid in test_appinfo.py r=maja_zf
Henrik Skupin <mail@hskupin.info> - Wed, 31 Aug 2016 23:39:54 +0200 - rev 312241
Push 20438 by ryanvm@gmail.com at Thu, 01 Sep 2016 16:13:32 +0000
Bug 1298233 - Skip test for platform buildid in test_appinfo.py r=maja_zf MozReview-Commit-ID: 72TpI5mA3fW
50dd3cba071ef71cc867208bdb92c1972f1246f6: Bug 1213731 - Remove unused Youtube URLs, use embedded URLs where possible. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 30 Aug 2016 18:36:16 +1200 - rev 312165
Push 20438 by ryanvm@gmail.com at Thu, 01 Sep 2016 16:13:32 +0000
Bug 1213731 - Remove unused Youtube URLs, use embedded URLs where possible. r=maja_zf Many of the youtube URLs were not being used in tests. Many were are/also dead. Furthermore, non-embedded links are causing issues due to the next video auto play feature defaulting to on in youtube. This is a quick once over to remove unused links, prune some of the dead, and rewrite those that can be embedded to embedded URLs. In future I would like to see the embedded links and non embedded separated into their own files. However, theses changes are a halfway house that will not break compatibility downstream. MozReview-Commit-ID: 4aPMNjD3LC4
98465d11d072916826935273917cea32f4486359: Bug 1213731 - Rework Youtube puppeteer to work with both youtube and embedded youtube. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 30 Aug 2016 16:25:01 +1200 - rev 312164
Push 20438 by ryanvm@gmail.com at Thu, 01 Sep 2016 16:13:32 +0000
Bug 1213731 - Rework Youtube puppeteer to work with both youtube and embedded youtube. r=maja_zf Rework the Youtube puppeteer to look up player and video element based on class names, instead of ID. This means that the tests can work with embedded players. This has the benefit that we can use youtube embedded links (youtube.com/embedded/<videoId>), which do not suffer from auto play related issues (auto play jumping to another video). MozReview-Commit-ID: 9UFyL7di6gH
06d0df0b935d31f7d21067753885a2e9a88e0338: Bug 1298771 - Attach last-update.log to update results for Firefox UI update tests r=maja_zf
Henrik Skupin <mail@hskupin.info> - Mon, 29 Aug 2016 17:55:42 +0200 - rev 311944
Push 20424 by ryanvm@gmail.com at Wed, 31 Aug 2016 13:53:28 +0000
Bug 1298771 - Attach last-update.log to update results for Firefox UI update tests r=maja_zf MozReview-Commit-ID: DtNwBbPuHPy
4d6e4d9909924505ddfd7861c39f7b47c2652f81: Bug 1295492 - Add support for --binary argument to Marionette mach command. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Tue, 30 Aug 2016 10:53:07 +0200 - rev 311781
Push 20417 by ryanvm@gmail.com at Tue, 30 Aug 2016 13:55:34 +0000
Bug 1295492 - Add support for --binary argument to Marionette mach command. r=maja_zf MozReview-Commit-ID: 6tru2Ms135j
0d7beb4dc862e03cc2d5410cd789eef0b22698c4: Bug 1291796 - Minor fixes to harness unit tests; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Fri, 26 Aug 2016 15:52:29 +0200 - rev 311602
Push 20413 by kwierso@gmail.com at Tue, 30 Aug 2016 00:56:45 +0000
Bug 1291796 - Minor fixes to harness unit tests; r=maja_zf In test_marionette_runner.py, fix pytest warning raised when importing TestManifest class directly in global namespace. In test_marionette_arguments.py, improve readability by shortening/changing some names and removing unnecessary comments (not needed as code is self-explanatory). MozReview-Commit-ID: GDzxlEqb7MB
6a81df9a2129e940f62961e80203554c41c3109a: Bug 1291796 - Split Marionette harness tests by class; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Fri, 26 Aug 2016 15:47:09 +0200 - rev 311601
Push 20413 by kwierso@gmail.com at Tue, 30 Aug 2016 00:56:45 +0000
Bug 1291796 - Split Marionette harness tests by class; r=maja_zf Split the Marionette harness unit tests, all of which were previously located in the single module test_marionette_runner.py, into modules that each test a specific class or group of similar classes. This will make it easier to add and locate new tests in the future, based on the class they are testing. The new module structure within tests/harness_unit/ is: * test_marionette_harness.py - tests for MarionetteHarness and the command-line interface * test_marionette_arguments.py - tests for MarionetteArguments (future: BaseMarionetteArguments and RemoteMarionetteArguments) * test_marionette_runner.py - tests for MarionetteTestRunner and BaseMarionetteTestRunner (future: MarionetteTextTestRunner) * test_marionette_test_result.py - tests for MarionetteTestResult (future: MarionetteTest) * conftest.py - pytest fixtures used in multiple modules (fixtures specific to a single module are defined in that module) MozReview-Commit-ID: CGh6Aa07lfV
293fceb6b4885ef5bc26e69e3615cac8b9a555c6: Bug 1296562 - Revert order for crash and socket checks in do_process_check decorator. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Fri, 19 Aug 2016 09:22:32 +0200 - rev 310599
Push 20373 by ryanvm@gmail.com at Tue, 23 Aug 2016 14:12:11 +0000
Bug 1296562 - Revert order for crash and socket checks in do_process_check decorator. r=maja_zf MozReview-Commit-ID: Dd2Pl3FnbUP
30fa88c82366a358f412ca2cc3268142c8991f0d: Bug 1284847 - Add tests for _build_kwargs; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Fri, 19 Aug 2016 12:09:25 +0200 - rev 310392
Push 20355 by kwierso@gmail.com at Sat, 20 Aug 2016 01:41:12 +0000
Bug 1284847 - Add tests for _build_kwargs; r=maja_zf Add tests to test_marionette_runner.py to verify the functionality of the _build_kwargs method of BaseMarionetteTestRunner, which is used to generate the kwargs with which the driverclass (Marionette) constructor is called. Test that _build_kwargs generates the right dictionary based on the values of certain runner properties (binary, emulator, address, and workspace). Add helper fixtures to reduce duplication between the test_build_kwargs_* tests. MozReview-Commit-ID: EyyfaE52rzS
5bb3a92c58a28bd27482112ba7e3dce4d30b2781: Bug 1284847 - Test args passed to runner/driver classes; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Wed, 17 Aug 2016 18:38:56 +0200 - rev 310391
Push 20355 by kwierso@gmail.com at Sat, 20 Aug 2016 01:41:12 +0000
Bug 1284847 - Test args passed to runner/driver classes; r=maja_zf Add tests to test_marionette_runner.py to verify that: - when the MarionetteHarness constructor is called, the arguments to that call are passed on to the _runner_class constructor - when run_tests() is called on the runner, the output of _build_kwargs is passed on as arguments to the call to the driverclass constructor In combination with a test of the runner's _build_kwargs method, this should ensure that the driver class constructor is being called with the appropriate arguments based on the input to the harness class constructor. MozReview-Commit-ID: 4U3sXxHSIpS
a218d8647a97ea512f13ccbdd49d4fd404f716fb: Bug 1283791 - Firefox-ui-tests taskcluster tasks have to upload reports (html, xml) as artifacts. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Fri, 12 Aug 2016 13:42:38 +0200 - rev 309897
Push 20342 by kwierso@gmail.com at Thu, 18 Aug 2016 23:33:24 +0000
Bug 1283791 - Firefox-ui-tests taskcluster tasks have to upload reports (html, xml) as artifacts. r=maja_zf MozReview-Commit-ID: KNi71IFE3As
d44aec2485222012313b7a5bdcf295058d92a0cb: Bug 1295492 - Add support for --binary argument to Marionette mach command. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Tue, 16 Aug 2016 09:30:15 +0200 - rev 309696
Push 20333 by kwierso@gmail.com at Thu, 18 Aug 2016 00:26:40 +0000
Bug 1295492 - Add support for --binary argument to Marionette mach command. r=maja_zf MozReview-Commit-ID: 6tru2Ms135j
19455d8adc072d1b64d9a29af492258cd9c6480e: Bug 1292300 - Small readability/typo fixes; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Mon, 15 Aug 2016 14:38:36 +0200 - rev 309694
Push 20333 by kwierso@gmail.com at Thu, 18 Aug 2016 00:26:40 +0000
Bug 1292300 - Small readability/typo fixes; r=maja_zf Assorted small changes to the tests in `test_marionette_runner.py`, including: - Declare `return_value`, etc. as argument in call to `patch`, instead of on separate lines - Avoid a multi-line `assert` statement - Fix a typo in `test_add_test_directory` - Fix some minor pep8/flake8 style issues MozReview-Commit-ID: 2EkA41dJNms
751d0d59136070b6c46635fd0032a1138d2adf10: Bug 1292300 - Refactor manifest-related tests with fixtures; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Mon, 15 Aug 2016 16:35:00 +0200 - rev 309693
Push 20333 by kwierso@gmail.com at Thu, 18 Aug 2016 00:26:40 +0000
Bug 1292300 - Refactor manifest-related tests with fixtures; r=maja_zf Add `ManifestFixture` class and `manifest_fixture` method to provide a fixture that facilitates writing tests involving test manifests, to avoid duplication within/between tests by using pytest parametrization, and to improve readability. MozReview-Commit-ID: 9PwdPoolIIU
813d8dab6d2be9fb754a3dd2d1daa3fdcee6233e: Bug 1292300 - Make mock_runner fixture do more work; r=maja_zf
Anjana Vakil <anjanavakil@gmail.com> - Tue, 09 Aug 2016 17:30:50 +0200 - rev 309692
Push 20333 by kwierso@gmail.com at Thu, 18 Aug 2016 00:26:40 +0000
Bug 1292300 - Make mock_runner fixture do more work; r=maja_zf Remove some duplication in various tests by doing more of that work in the `mock_runner` fixture, including: - monkeypatch mozversion in the fixture so we don't have to patch mozversion.get_version in various places - mock additional attributes needed for certain tests Use the improved mock_runner fixture wherever `runner.run_tests` is called. MozReview-Commit-ID: GQlBR0Geic6
8a487cda5bac7e432d0b1729ed7f66a76551a142: Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Fri, 12 Aug 2016 14:23:13 +0200 - rev 309688
Push 20333 by kwierso@gmail.com at Thu, 18 Aug 2016 00:26:40 +0000
Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts. r=maja_zf MozReview-Commit-ID: EzN3wbuT5PN
bb7b33ca26fa10d442577f62909c27890de8d752: Bug 1284268 - Add a local ping server; r=maja_zf
André Reinald <areinald@mozilla.com> - Mon, 01 Aug 2016 21:37:06 +0200 - rev 309323
Push 20308 by kwierso@gmail.com at Mon, 15 Aug 2016 22:04:54 +0000
Bug 1284268 - Add a local ping server; r=maja_zf MozReview-Commit-ID: BprnSNceit9
5c6a56bb4a6cb28028b4206bcb3f2cb86baa0528: Bug 1284502 - Marionette harness should log exceptions from run() only once. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Mon, 25 Jul 2016 18:23:26 +0200 - rev 306543
Push 20110 by cbook@mozilla.com at Tue, 26 Jul 2016 09:59:54 +0000
Bug 1284502 - Marionette harness should log exceptions from run() only once. r=maja_zf Whenever an exception is raised while tests are executed, the log error message should only be printed once. As best this should happen in `cli()`, so that subclasses can better set their own behavior, and we safe us from re-raising the exception. MozReview-Commit-ID: 5NLBnJAjUMQ
bc563c2d69012ccbd04e754c8d0440fb8e66a9e5: Bug 1284405 - Better handling of --socket-timeout cli argument value. r=maja_zf
Nelson João Morais <njmorais@gmail.com> - Tue, 19 Jul 2016 23:34:46 +0100 - rev 306128
Push 20087 by cbook@mozilla.com at Fri, 22 Jul 2016 10:00:28 +0000
Bug 1284405 - Better handling of --socket-timeout cli argument value. r=maja_zf MozReview-Commit-ID: A9LjNJRe2Vm
2bb2126f4034aff15d68dd0d16eff0d861d47601: Bug 1279243 - Add quit_in_app() to marionette driver. r=maja_zf
André Reinald <areinald@mozilla.com> - Tue, 19 Jul 2016 17:13:43 +0200 - rev 305912
Push 20080 by cbook@mozilla.com at Thu, 21 Jul 2016 14:27:27 +0000
Bug 1279243 - Add quit_in_app() to marionette driver. r=maja_zf MozReview-Commit-ID: 4O1hnYVsUWX