searching for reviewer(gfritzsche)
9a76e10e545059ed06524afb34cad99344f0f190: Add GPU process histograms to Telemetry pings. (bug 1304494 part 4, r=gfritzsche)
David Anderson <danderson@mozilla.com> - Sun, 30 Oct 2016 22:35:57 -0700 - rev 320269
Push 20754 by cbook@mozilla.com at Mon, 31 Oct 2016 15:58:35 +0000
Add GPU process histograms to Telemetry pings. (bug 1304494 part 4, r=gfritzsche)
ebb6abdb33b9ec8b3b8bc50f41497dc038742591: Send accumulated GPU process telemetry to the UI process. (bug 1304494 part 3, r=gfritzsche)
David Anderson <danderson@mozilla.com> - Sun, 30 Oct 2016 22:35:57 -0700 - rev 320268
Push 20754 by cbook@mozilla.com at Mon, 31 Oct 2016 15:58:35 +0000
Send accumulated GPU process telemetry to the UI process. (bug 1304494 part 3, r=gfritzsche)
0129ae28198b74ecab5c277879acf25ead9401ba: Refactor TelemetryHistogram to support multiple child process types. (bug 1304494 part 2, r=gfritzsche)
David Anderson <danderson@mozilla.com> - Sun, 30 Oct 2016 22:35:57 -0700 - rev 320267
Push 20754 by cbook@mozilla.com at Mon, 31 Oct 2016 15:58:35 +0000
Refactor TelemetryHistogram to support multiple child process types. (bug 1304494 part 2, r=gfritzsche)
2963a5b02f01195f26c7d3bee68fb4bce9b7b26e: Ensure we start the Telemetry singleton in the GPU process. (bug 1304494 part 1, r=gfritzsche)
David Anderson <danderson@mozilla.com> - Sun, 30 Oct 2016 22:35:56 -0700 - rev 320266
Push 20754 by cbook@mozilla.com at Mon, 31 Oct 2016 15:58:35 +0000
Ensure we start the Telemetry singleton in the GPU process. (bug 1304494 part 1, r=gfritzsche)
464f24871b18d468555c25e2df9421e2de79df34: Bug 1308415 - Update about:telemetry to show keyed scalars. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Fri, 07 Oct 2016 03:35:00 -0400 - rev 317024
Push 20680 by ryanvm@gmail.com at Sat, 08 Oct 2016 03:06:51 +0000
Bug 1308415 - Update about:telemetry to show keyed scalars. r=gfritzsche
ee7990c78dd93fd3c1d708b06f5f848329df85fe: bug 1304519 - Ensure we hold a lock before accumulating. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 04 Oct 2016 15:02:46 -0400 - rev 316689
Push 20665 by cbook@mozilla.com at Thu, 06 Oct 2016 10:29:09 +0000
bug 1304519 - Ensure we hold a lock before accumulating. r=gfritzsche Lock calls to internal_Accumulate from functions that run without locks. This doesn't render TelemetryHistogram perfectly threadsafe. However, this does protect all accumulation sites. MozReview-Commit-ID: 16JUek8NiXI
f3f755f8c1e472b093b053688f7431eb3e8933e4: Bug 1306699 - Only invoke attribution code functionality in desktop Firefox; r=gfritzsche
Matt Howell <mhowell@mozilla.com> - Sun, 02 Oct 2016 10:48:47 -0700 - rev 316391
Push 20656 by kwierso@gmail.com at Wed, 05 Oct 2016 00:44:03 +0000
Bug 1306699 - Only invoke attribution code functionality in desktop Firefox; r=gfritzsche MozReview-Commit-ID: JMGuP9kI6gD
0bf376ad9b85c1eb5ec3707428151390788976a1: Bug 1292360 - Add attribution data to the telemetry environment block; r=gfritzsche, data-review=bsmedberg
Matt Howell <mhowell@mozilla.com> - Wed, 24 Aug 2016 10:01:10 -0700 - rev 315853
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1292360 - Add attribution data to the telemetry environment block; r=gfritzsche, data-review=bsmedberg MozReview-Commit-ID: 4sltJYJrrFS
d044a6f7756c18de820e0c239d649240ecdb0030: Bug 1305654 - Fix the SetMaximum C++ API for Scalars. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 27 Sep 2016 01:32:00 -0400 - rev 315479
Push 20616 by cbook@mozilla.com at Wed, 28 Sep 2016 14:38:03 +0000
Bug 1305654 - Fix the SetMaximum C++ API for Scalars. r=gfritzsche
46645a6bb7dc88603beb3ce3e55fd63a1d2fc75b: Bug 1292226 - Reject non-object ping payloads submitted to Telemetry. r=gfritzsche, data-r=bsmedberg
rthyberg <robertthyberg@gmail.com> - Thu, 22 Sep 2016 18:29:34 +0100 - rev 314891
Push 20595 by georg.fritzsche@googlemail.com at Thu, 22 Sep 2016 17:29:43 +0000
Bug 1292226 - Reject non-object ping payloads submitted to Telemetry. r=gfritzsche, data-r=bsmedberg
73c0774056bb42c4c5a27f65e01a24613ab7dd7c: Bug 1277806 - Add the missing C++ API for boolean scalars. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Wed, 14 Sep 2016 02:59:00 +0200 - rev 314720
Push 20583 by alessio.placitelli@gmail.com at Wed, 21 Sep 2016 16:38:21 +0000
Bug 1277806 - Add the missing C++ API for boolean scalars. r=gfritzsche
d0ad8d0da0ef0c0a7fdfeacdf3f8622531baed45: Bug 1277806 - Update the docs. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Wed, 14 Sep 2016 02:59:00 +0200 - rev 314719
Push 20583 by alessio.placitelli@gmail.com at Wed, 21 Sep 2016 16:38:21 +0000
Bug 1277806 - Update the docs. r=gfritzsche
d99209b752fbc75b35e437a476c14a93f54b0774: Bug 1277806 - Implement keyed scalar measurements in Telemetry. r=gfritzsche,nfroyd
Alessio Placitelli <alessio.placitelli@gmail.com> - Fri, 16 Sep 2016 03:43:00 +0200 - rev 314718
Push 20583 by alessio.placitelli@gmail.com at Wed, 21 Sep 2016 16:38:21 +0000
Bug 1277806 - Implement keyed scalar measurements in Telemetry. r=gfritzsche,nfroyd MozReview-Commit-ID: 9kkjpLAIQUX
66a2fa62d7601aaae4069bc9a2c4ec13854f65e7: Bug 1277806 - Add support for the keyed scalars to the scalar registry. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Wed, 07 Sep 2016 02:39:00 +0200 - rev 314717
Push 20583 by alessio.placitelli@gmail.com at Wed, 21 Sep 2016 16:38:21 +0000
Bug 1277806 - Add support for the keyed scalars to the scalar registry. r=gfritzsche MozReview-Commit-ID: 8dKj92Kh2Ev
5a20e1ffb8eae493ac1b6c46e77c376d19a375bb: bug 1218576 - Turn canRecordExtended on for browser_use_counters.js r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 16 Sep 2016 09:13:06 -0400 - rev 314455
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Turn canRecordExtended on for browser_use_counters.js r=gfritzsche With the content accumulations now being aggregated in the parent, both the child and parent must be allowed to record for Telemetry accumulations to work. MozReview-Commit-ID: 2j9YZIPqbZr
ca430b715311fd26c1709f9ef07ac19d741f6ca8: bug 1218576 - Request an immediate batch send when the batch size hits a high water mark. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 08 Sep 2016 10:15:15 -0400 - rev 314454
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Request an immediate batch send when the batch size hits a high water mark. r=gfritzsche We've now seen an OOM trying to grow the accumulations array during a test suite. The g*Accumulations arrays do grow unboundedly in size waiting for the IPC timer to fire, so we should put a size bound as well as a time bound to trigger the batch send. The current size bound is 5K elements. This was chosen out of a hat. MozReview-Commit-ID: 5HeWdbLfN03
1b498933da3ae553f8a965c4b20e40fbe57fd1bf: bug 1218576 - Ensure accumulations are for valid IDs. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 08 Sep 2016 10:09:54 -0400 - rev 314453
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure accumulations are for valid IDs. r=gfritzsche We're seeing occasional failures of the isValid assert on the parent side where the ID we're being asked to accumulate on is invalid. Check the IDs on both sides to ensure that they're valid heading in. MozReview-Commit-ID: 4gLG54Tx64s
f3b858440d0112e121efd0080e2eaf9f081d6d36: bug 1218576 - Change unused.h to Unused.h, which matters to some filesystems. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 30 Aug 2016 12:07:18 -0400 - rev 314451
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Change unused.h to Unused.h, which matters to some filesystems. r=gfritzsche MozReview-Commit-ID: GOy5Xz2Pxta
762e238a73d064a497891f997347f10b6c2e8921: bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 23 Aug 2016 14:11:31 -0400 - rev 314450
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche Throw some process selectors in the Histograms and Keyed Histograms sections to allow users to choose which process type's histograms they'd like to see.
5d3383a8df5f53550e54f8132fdb69b4479f721c: bug 1218576 - Test child categorical histogram aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 19 Aug 2016 11:53:17 -0400 - rev 314449
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Test child categorical histogram aggregation r=gfritzsche It's new, it wasn't tested, and my patches broke it earlier so we should have coverage for it. MozReview-Commit-ID: B25bFOJHMSQ
c97a5b2b086accd52fb5dd0b27eb6d5127fb6fc8: bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 12 Aug 2016 14:51:48 -0400 - rev 314448
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche Rewrite the categorical histogram accumulation code to use the common path. This way it gets remote accumulation for cheap. MozReview-Commit-ID: 3q6gdSvBix
6e20455447661423af908193c9458895df211c7e: bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 12 Aug 2016 09:09:18 -0400 - rev 314447
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche Every other Accumulate call has it :S MozReview-Commit-ID: 8uWtADebuJ1
02bee0c4865ad16db50a47b25c6410dd1b1b3dce: bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 28 Jul 2016 12:22:06 -0400 - rev 314446
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche I saw a one-off crash on try in internal_GetHistogramByEnumId. Not reproducible but maybe possible if we're trying to accumulate using an invalid ID. So let's guard against that. MozReview-Commit-ID: Ei6eTlV91mJ
83d24a3dc1a99dd5669cc718e459996e26ad44e2: bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 12 Jul 2016 11:49:38 -0400 - rev 314445
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche On content process shutdown we send a content process ping to ensure we have up-to-date data from the content process before it goes away. Now we need to also flush the batched telemetry accumulations to the parent so that it can be present in the ping. No attempt is made to synchronize access to IPCTimerFired. It is safe to re-enter. No attempt is made to cancel the timer as its firing is benign. MozReview-Commit-ID: 1gjNH9IPhKf
92ed900459dfcf59a3a28263d0855ee279d74f49: bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 05 Jul 2016 09:51:49 -0400 - rev 314444
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche Clear isn't generally called at all, and isn't dispatched to the parent process for child telemetry aggregation. Clear should only be called on the parent process. MozReview-Commit-ID: stIutvAO6h
021273dad9aead8dbc1455018bcd6d6d1566483e: bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 05 Jul 2016 09:34:33 -0400 - rev 314443
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche waitOnCondition is used to wait for the telemetry batch to be processed (roughly every 2s). It resolves and rejects to the same value as there are a couple of xfail tests that need the wrong answer. MozReview-Commit-ID: I1JqEXQSL7d
4b674e3249ecab5caf4d7a10bc1f40a1615ea84e: bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 04 Jul 2016 11:17:07 -0400 - rev 314442
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche No more requestChildPayloads (or need for it). MozReview-Commit-ID: AmPuT04HjWx
206ce3f7b0cde047a5b4f1b8f4b61b3b33f77d0b: bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 04 Jul 2016 11:16:05 -0400 - rev 314441
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche The JS histograms, too, need to dispatch their accumulations from child to parent. JSHistograms_Add now only supports histograms that are in gHistogramsMap or that were created in the parent process. After bug 1288745, maybe we'll be able to change this to be less convoluted. MozReview-Commit-ID: 3qTH89YKbGP
f5a08bea2e1704e656b21a14079537931da77c5e: bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:46:22 -0400 - rev 314440
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche Take the opportunity presented through changing child telemetry accumulation to bring the ping form closer to the ideas expressed in bug 1281795. childPayloads still exists, but without histograms or keyedHistograms which are now at root.processes.content.{keyedH|h}istograms. This will require coordinated changes in the aggregator and moztelemetry libraries. MozReview-Commit-ID: AqG2jmBBC2W
712681439306713ccaf6cab6c7e3098ef995390b: bug 1218576 - Remove requestChildPayloads r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:43:37 -0400 - rev 314439
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Remove requestChildPayloads r=gfritzsche To simplify using child telemetry from the parent process, only allow child telemetry payloads to be generated once per child process, on shut down. This will allow us to use the child telemetry's subsession information to leave childPayloads the way it currently is. Will need to update test_ChildHistograms.js as it is the only consumer. MozReview-Commit-ID: 2qSztg0QHV5
1b2b8973c8a2debe79803db16ebd514629a8df2c: bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:38:35 -0400 - rev 314438
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche I originally thought we'd be able to avoid the previous implementation's waste of a map full of every kind of keyed histogram. Unfortunately, other code (TelemetrySession at the very least) depends on this (and will throw if a keyed histogram isn't present, even if it is empty) MozReview-Commit-ID: 8MCGVa595UB
832793e20c54a1fc6a2c6573e9205e2e783a3676: bug 1218576 - Support subsession hgrams for child aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:36:07 -0400 - rev 314437
Push 20574 by cbook@mozilla.com at Tue, 20 Sep 2016 10:05:16 +0000
bug 1218576 - Support subsession hgrams for child aggregation r=gfritzsche The original commit didn't properly support subsession histograms, so rectify that lapse by adding support for stripping out the base name of a histogram when trying to determine its id. MozReview-Commit-ID: LvUek6f5WUx
074fc3a0ac1f4ac5166194275ea7de7b3eb03d17: Bug 1300891 - Rename SCRIPT_BLOCK_WRONG_MIME to avoid confusing the telemetry probe. r=gfritzsche
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Thu, 08 Sep 2016 09:29:17 +0200 - rev 313214
Push 20492 by kwierso@gmail.com at Thu, 08 Sep 2016 22:29:45 +0000
Bug 1300891 - Rename SCRIPT_BLOCK_WRONG_MIME to avoid confusing the telemetry probe. r=gfritzsche
ab12d34f31451576d5891b2262270dc758b3607f: Bug 1299143 - Remove outdated comment about Telemetry.snapshot.static. r=gfritzsche
AdamG2 <adamgj.wong@gmail.com> - Wed, 07 Sep 2016 00:48:03 -0400 - rev 313052
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
Bug 1299143 - Remove outdated comment about Telemetry.snapshot.static. r=gfritzsche MozReview-Commit-ID: KxW3jTaPjHX
57f9849f0f8f93b1609a327f70b1cd49838e524b: bug 1218576 - Change unused.h to Unused.h, which matters to some filesystems. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 30 Aug 2016 12:07:18 -0400 - rev 313007
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Change unused.h to Unused.h, which matters to some filesystems. r=gfritzsche MozReview-Commit-ID: GOy5Xz2Pxta
9595c56c9db29296d8313ad17b4c94a3fab8deb6: bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 23 Aug 2016 14:11:31 -0400 - rev 313006
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche Throw some process selectors in the Histograms and Keyed Histograms sections to allow users to choose which process type's histograms they'd like to see.
9d15ae92f2faf5671531bffab52b036c3eb9f451: bug 1218576 - Test child categorical histogram aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 19 Aug 2016 11:53:17 -0400 - rev 313005
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Test child categorical histogram aggregation r=gfritzsche It's new, it wasn't tested, and my patches broke it earlier so we should have coverage for it. MozReview-Commit-ID: B25bFOJHMSQ
ea7282078b054f7618bd1e8b54b544f18e2a4fff: bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 12 Aug 2016 14:51:48 -0400 - rev 313004
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche Rewrite the categorical histogram accumulation code to use the common path. This way it gets remote accumulation for cheap. MozReview-Commit-ID: 3q6gdSvBix
848f4ef30978ebbe1126012e0d1a29b59d8626ac: bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 12 Aug 2016 09:09:18 -0400 - rev 313003
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche Every other Accumulate call has it :S MozReview-Commit-ID: 8uWtADebuJ1
1b6666eb3b815fb289b8dc342f35fea47dffdb1b: bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 28 Jul 2016 12:22:06 -0400 - rev 313002
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche I saw a one-off crash on try in internal_GetHistogramByEnumId. Not reproducible but maybe possible if we're trying to accumulate using an invalid ID. So let's guard against that. MozReview-Commit-ID: Ei6eTlV91mJ
ce2a2dabb0421fa8fd375f4baff9c9eac15cf723: bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 12 Jul 2016 11:49:38 -0400 - rev 313001
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche On content process shutdown we send a content process ping to ensure we have up-to-date data from the content process before it goes away. Now we need to also flush the batched telemetry accumulations to the parent so that it can be present in the ping. No attempt is made to synchronize access to IPCTimerFired. It is safe to re-enter. No attempt is made to cancel the timer as its firing is benign. MozReview-Commit-ID: 1gjNH9IPhKf
3caacb5c213bd7187b78456ab8b7c4388473813b: bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 05 Jul 2016 09:51:49 -0400 - rev 313000
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche Clear isn't generally called at all, and isn't dispatched to the parent process for child telemetry aggregation. Clear should only be called on the parent process. MozReview-Commit-ID: stIutvAO6h
c68fc5ad5ecff9621aafb4fc889d2374ec5f4121: bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 05 Jul 2016 09:34:33 -0400 - rev 312999
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche waitOnCondition is used to wait for the telemetry batch to be processed (roughly every 2s). It resolves and rejects to the same value as there are a couple of xfail tests that need the wrong answer. MozReview-Commit-ID: I1JqEXQSL7d
1678482b2fad73f0aa0c298ae9c41b46b6fd9d1e: bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 04 Jul 2016 11:17:07 -0400 - rev 312998
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche No more requestChildPayloads (or need for it). MozReview-Commit-ID: AmPuT04HjWx
df28918fe2361f0b54ca9ce4773a29c4c0675d06: bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 04 Jul 2016 11:16:05 -0400 - rev 312997
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche The JS histograms, too, need to dispatch their accumulations from child to parent. JSHistograms_Add now only supports histograms that are in gHistogramsMap or that were created in the parent process. After bug 1288745, maybe we'll be able to change this to be less convoluted. MozReview-Commit-ID: 3qTH89YKbGP
eb5dbe28ab209f742c60ea6ec9c76dc5cba19eba: bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:46:22 -0400 - rev 312996
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche Take the opportunity presented through changing child telemetry accumulation to bring the ping form closer to the ideas expressed in bug 1281795. childPayloads still exists, but without histograms or keyedHistograms which are now at root.processes.content.{keyedH|h}istograms. This will require coordinated changes in the aggregator and moztelemetry libraries. MozReview-Commit-ID: AqG2jmBBC2W
baf105cbe0c84c9531a29d3fd0680b4b1d95563d: bug 1218576 - Remove requestChildPayloads r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:43:37 -0400 - rev 312995
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Remove requestChildPayloads r=gfritzsche To simplify using child telemetry from the parent process, only allow child telemetry payloads to be generated once per child process, on shut down. This will allow us to use the child telemetry's subsession information to leave childPayloads the way it currently is. Will need to update test_ChildHistograms.js as it is the only consumer. MozReview-Commit-ID: 2qSztg0QHV5
7fdd6b6ab5945eab4bc7cddbcba34ce0c2fb2fbf: bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:38:35 -0400 - rev 312994
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche I originally thought we'd be able to avoid the previous implementation's waste of a map full of every kind of keyed histogram. Unfortunately, other code (TelemetrySession at the very least) depends on this (and will throw if a keyed histogram isn't present, even if it is empty) MozReview-Commit-ID: 8MCGVa595UB
a0a4829d0ca0184e22e9e0232553c7ebdf0adc52: bug 1218577 - Support subsession hgrams for child aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Wed, 29 Jun 2016 15:36:07 -0400 - rev 312993
Push 20479 by kwierso@gmail.com at Thu, 08 Sep 2016 01:08:46 +0000
bug 1218577 - Support subsession hgrams for child aggregation r=gfritzsche The original commit didn't properly support subsession histograms, so rectify that lapse by adding support for stripping out the base name of a histogram when trying to determine its id. MozReview-Commit-ID: LvUek6f5WUx
705cb7ff83607a4669a496999913580e12699aed: Bug 1295058 - Make sync ping only submit every 12 hours or on browser shutdown r=gfritzsche,markh
Thom Chiovoloni <tchiovoloni@mozilla.com> - Wed, 31 Aug 2016 12:50:34 -0400 - rev 312464
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1295058 - Make sync ping only submit every 12 hours or on browser shutdown r=gfritzsche,markh MozReview-Commit-ID: 9BcMGAP0w7U