searching for reviewer(erahm)
94d5d14da6bac6f013d6cc1187ac218092cea05e: Bug 1313440: Fix NS_ENSURE_TRUE(isSandbox) warnings in JPM bootstrap. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 27 Oct 2016 13:28:49 -0700 - rev 320035
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313440: Fix NS_ENSURE_TRUE(isSandbox) warnings in JPM bootstrap. r=erahm MozReview-Commit-ID: E4qgjheRyV6
fb2d15e4f33d8a643197563608d1c216691abb18: Bug 1313440: Fix NS_ENSURE_TRUE(isSandbox) warnings in test code. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 27 Oct 2016 13:28:01 -0700 - rev 320034
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313440: Fix NS_ENSURE_TRUE(isSandbox) warnings in test code. r=erahm MozReview-Commit-ID: GkDaUL6sDfy
b010bc73909323e71acf61edfb0750f611e68f97: Bug 1309929 - Use an async memory report for workers r=erahm
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 28 Oct 2016 10:50:16 +0100 - rev 319975
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309929 - Use an async memory report for workers r=erahm
ad24f084859f9ebf5a1a99a7470d6abb513d8d61: Bug 1311397: fix DataChannel logging for mochitests/etc r=erahm
Randell Jesup <rjesup@jesup.org> - Fri, 28 Oct 2016 03:25:10 -0400 - rev 319970
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1311397: fix DataChannel logging for mochitests/etc r=erahm
8394f9b7b9e59e1f44636ee26f0c040101c93080: Bug 1312331 - Build up list of applicable rules in reverse to avoid quadratic time array manipulations. r=erahm
Cameron McCormack <cam> - Mon, 24 Oct 2016 02:59:00 +0200 - rev 319365
Push 20743 by philringnalda@gmail.com at Wed, 26 Oct 2016 05:13:15 +0000
Bug 1312331 - Build up list of applicable rules in reverse to avoid quadratic time array manipulations. r=erahm MozReview-Commit-ID: HAjtxQVZo8X
93cdd187a2535349195fd5d4ec71bee88fa04f54: Bug 1301627 - Change the name of commented variables when calling perf_event_open. r=erahm
Kirti Singla <singlakirti3@gmail.com> - Sun, 23 Oct 2016 10:10:00 -0700 - rev 319144
Push 20736 by cbook@mozilla.com at Mon, 24 Oct 2016 14:57:45 +0000
Bug 1301627 - Change the name of commented variables when calling perf_event_open. r=erahm
03c8f8c920554d2b1bcef162fadc77d1a3f24f05: Bug 1308993 - aboutdebugging remove align-items: self-start;r=erahm
Julian Descottes <jdescottes@mozilla.com> - Thu, 13 Oct 2016 16:42:26 +0200 - rev 317806
Push 20704 by cbook@mozilla.com at Fri, 14 Oct 2016 10:29:22 +0000
Bug 1308993 - aboutdebugging remove align-items: self-start;r=erahm MozReview-Commit-ID: 7d054lVgwdt
5c7d19f4aed921f9ff2dba1206c71669d76bb7f0: Bug 1306616 - part 2 - remove nsWritingIterator<T>::write; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Mon, 03 Oct 2016 17:21:52 -0400 - rev 316257
Push 20649 by philringnalda@gmail.com at Tue, 04 Oct 2016 03:52:28 +0000
Bug 1306616 - part 2 - remove nsWritingIterator<T>::write; r=erahm Iterators shouldn't have methods like write(); if you need to write to an iterator, that logic should be handled by something outside of the iterator...which also explains why we have a specialization of nsCharTraits<nsWritingIterator<T>>. The HTML parser wants this for its own reasons, so we have to make sure it continues to work.
1f5b932a4fade74aaa2b9e92417adae3cd942a70: Bug 1306616 - part 1 - don't use write() method of nsWritingIterator in nsReadableUtils; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Mon, 03 Oct 2016 17:21:52 -0400 - rev 316256
Push 20649 by philringnalda@gmail.com at Tue, 04 Oct 2016 03:52:28 +0000
Bug 1306616 - part 1 - don't use write() method of nsWritingIterator in nsReadableUtils; r=erahm Iterators really shouldn't have methods like these; there should be something else sitting on top of iterators that provides this.
c0be513c03c8d04eb3a8fbe24bb11e3bbd01621f: Bug 1294577 - Don't issue a warning in ThirdPartyUtil::IsThirdPartyWindow when encountering a window with a null principal; r=erahm
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Sep 2016 15:46:14 -0400 - rev 315935
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1294577 - Don't issue a warning in ThirdPartyUtil::IsThirdPartyWindow when encountering a window with a null principal; r=erahm
c8c685a95ab025a21c418759f292bc491ab26957: Bug 1305422 - part 18 - remove #if 0'd-out code from nsStringIterator.h; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:57 -0400 - rev 315889
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 18 - remove #if 0'd-out code from nsStringIterator.h; r=erahm We don't support IBM VisualAge for OS/2 anymore, and we haven't needed this code in a long time regardless.
f933f6215b9d67ab84255642d8ab2cb208f051c1: Bug 1305422 - part 17 - remove size_{forward,backward} from ns{Reading,Writing}Iterator; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:57 -0400 - rev 315888
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 17 - remove size_{forward,backward} from ns{Reading,Writing}Iterator; r=erahm
088bfcd8f3cb583e0357c73b8ce03b8bea95df3d: Bug 1305422 - part 11 - don't call size_forward in nsXPCOMStrings.cpp; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:57 -0400 - rev 315882
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 11 - don't call size_forward in nsXPCOMStrings.cpp; r=erahm
55be43ac96c9037c2245b3cf0b90f59b38364984: Bug 1305422 - part 9 - remove {start,end} from ns{Reading,Writing}Iterator; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:57 -0400 - rev 315880
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 9 - remove {start,end} from ns{Reading,Writing}Iterator; r=erahm These methods are now unused thanks to previous patches.
9dc21248ab121e9d0acf01dc24d0fa297f2632ce: Bug 1305422 - part 6 - pass explicit end iterators for CopyTo{Upper,Lower}Case; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:57 -0400 - rev 315877
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 6 - pass explicit end iterators for CopyTo{Upper,Lower}Case; r=erahm This change avoids calling size_forward on the iterator, which we are trying to eliminate.
9b814ee26cd7a8d4eeb1f9e3206a4e6b37d22b2a: Bug 1305422 - part 6a - add operator- support for ns{Reading,Writing}Iterator; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:58 -0400 - rev 315876
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 6a - add operator- support for ns{Reading,Writing}Iterator; r=erahm This change is necessary so we can start using a pair of iterators (current, end) and subtract them to figure out how far we have left to go. The current code just uses size_forward and size_backward for this purpose, and it's quite an unusual iterator that knows how far it can go until it's done.
a5b04e48b3e8e70b8a213afb75170da85c4d5b62: Bug 1305422 - part 4 - don't call size_forward in nsIDNService.cpp; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:58 -0400 - rev 315874
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 4 - don't call size_forward in nsIDNService.cpp; r=erahm We don't need to bother with iterators here at all; we can just ask the string for its data and length directly.
e208dfe24c94f7c3cddbc27df9e49d7fadc2acaf: Bug 1305422 - part 3 - don't call size_forward in nsTStringComparator.cpp; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:58 -0400 - rev 315873
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 3 - don't call size_forward in nsTStringComparator.cpp; r=erahm Asking for size_forward on an iterator that you haven't started reading from is just asking for the length of the original string, so use that instead.
8313868b4334a07005ec359e6b0745ee395f10ad: Bug 1305422 - part 2 - don't call size_forward on ns*String::iterators to check for SetLength failure; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:58 -0400 - rev 315872
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 2 - don't call size_forward on ns*String::iterators to check for SetLength failure; r=erahm We have better ways of checking for SetLength failure nowadays, and even if these SetLength calls did fail, the program would crash anyway.
77a8d7d6a0fb5fb4cdce1c9edf68a573f7d3de55: Bug 1305422 - part 1 - remove normalize* methods from ns{Reading,Writing}Iterator; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Sep 2016 22:33:58 -0400 - rev 315871
Push 20634 by cbook@mozilla.com at Fri, 30 Sep 2016 10:10:13 +0000
Bug 1305422 - part 1 - remove normalize* methods from ns{Reading,Writing}Iterator; r=erahm They are never called.
f65a03612d328904e0cdb1368911cace655d535b: Bug 1304199 - Fix nsWindow::GetNativeData called with bad value. r=erahm
Ryan Hunt <ryanhunt@outlook.com> - Wed, 21 Sep 2016 12:39:00 -0400 - rev 315675
Push 20623 by cbook@mozilla.com at Thu, 29 Sep 2016 09:49:42 +0000
Bug 1304199 - Fix nsWindow::GetNativeData called with bad value. r=erahm MozReview-Commit-ID: EwvoZCkmliH
6b12cec59752d5e42c5013c3551287608a388d03: Bug 1298855 - part 2 - remove prcpucfg.h #include from xpt_arena.h; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Wed, 21 Sep 2016 18:16:10 -0400 - rev 314830
Push 20591 by cbook@mozilla.com at Thu, 22 Sep 2016 11:42:18 +0000
Bug 1298855 - part 2 - remove prcpucfg.h #include from xpt_arena.h; r=erahm Nothing else in this code requires prcpucfg.h at this point, and we might as well remove nspr.h from xpt_xdr.cpp while we're at it.
fd9ce614a6112b0650c8e6eb82c0eba455dfced0: Bug 1298855 - part 1 - use EndianUtils.h in xpt_xdr.cpp; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Wed, 21 Sep 2016 18:16:10 -0400 - rev 314829
Push 20591 by cbook@mozilla.com at Thu, 22 Sep 2016 11:42:18 +0000
Bug 1298855 - part 1 - use EndianUtils.h in xpt_xdr.cpp; r=erahm More obvious, slightly more efficient, and dispensing with NSPR macro goo is always a good thing.
177f41cecedb422d7a11156091ee718ec919c643: Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Sep 2016 17:12:24 +1000 - rev 312947
Push 20470 by cbook@mozilla.com at Wed, 07 Sep 2016 15:25:31 +0000
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. This change avoids lots of false positives for Coverity's CHECKED_RETURN warning, caused by NS_WARN_IF's current use in both statement-style and expression-style. In the case where the code within the NS_WARN_IF has side-effects, I made the following change. > NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); > --> > Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); In the case where the code within the NS_WARN_IF lacks side-effects, I made the following change. > NS_WARN_IF(!condWithoutSideEffects); > --> > NS_WARNING_ASSERTION(condWithoutSideEffects, "msg"); This has two improvements. - The condition is not evaluated in non-debug builds. - The sense of the condition is inverted to the familiar "this condition should be true" sense used in assertions. A common variation on the side-effect-free case is the following. > nsresult rv = Fn(); > NS_WARN_IF_(NS_FAILED(rv)); > --> > DebugOnly<nsresult rv> = Fn(); > NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
f38efca9b50a6f4b88e0a59feb0435d1f13e4d5e: Bug 1300013 - Fix bogus tooltip for explicit/dom/memory-file-data/small memory report. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 05 Sep 2016 14:14:00 +1000 - rev 312698
Push 20458 by philringnalda@gmail.com at Tue, 06 Sep 2016 00:05:54 +0000
Bug 1300013 - Fix bogus tooltip for explicit/dom/memory-file-data/small memory report. r=erahm. The parameter was missing. The patch also clarifies the wording.
93657f8dedaafa384bcd49c71b52e195ec968de8: Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Sep 2016 15:01:16 +1000 - rev 312382
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm. The new name makes the sense of the condition much clearer. E.g. compare: NS_WARN_IF_FALSE(!rv.Failed()); with: NS_WARNING_ASSERTION(!rv.Failed()); The new name also makes it clearer that it only has effect in debug builds, because that's standard for assertions.
de84b1059f7f510526debc5b7a0236bfb883de71: Bug 1299871 - Increase leak threshold on OS X to paper over increased layers leak. r=erahm
Andrew McCreight <continuation@gmail.com> - Thu, 01 Sep 2016 11:04:09 -0700 - rev 312340
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1299871 - Increase leak threshold on OS X to paper over increased layers leak. r=erahm MozReview-Commit-ID: 2QQa5uxmO5J
7651ea2490e0f0d36757ee238fcf4446b1869d18: Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 24 Aug 2016 15:23:45 +1000 - rev 311079
Push 20390 by kwierso@gmail.com at Fri, 26 Aug 2016 00:16:06 +0000
Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm. This patch removes checking of all the callback calls in memory reporter CollectReport() functions, because it's not useful. The patch also does some associated clean-up. - Replaces some uses of nsIMemoryReporterCallback with the preferred nsIHandleReportCallback typedef. - Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports() parameter names, for consistency. - Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl. - Uses the MOZ_COLLECT_REPORT macro in all suitable places. Overall the patch reduces code size by ~300 lines and reduces the size of libxul by about 37 KiB on my Linux64 builds.
58a080c24f5f2da87a692992c75139f0a4f0b0a5: Bug 1262826 - specialize nsTHashtable<nsPtrHashKey<T>> to share a common implementation; r=erahm
Nathan Froyd <froydnj@gmail.com> - Mon, 22 Aug 2016 18:45:47 -0400 - rev 310634
Push 20373 by ryanvm@gmail.com at Tue, 23 Aug 2016 14:12:11 +0000
Bug 1262826 - specialize nsTHashtable<nsPtrHashKey<T>> to share a common implementation; r=erahm We have a number of nsTHashtable<nsPtrHashKey<T>> instantiations, mostly from IPDL-generated code. There's no reason in principle that all of these instantiations couldn't share code, since they're all storing POD entries of the same size. Let's specialize nsTHashtable for such types, providing a thin layer over a hashtable that stores void pointers. This change saves about 90K of space (!) on x86-64 Linux.
57753be3e42157603a2ceaf86dac87c0b742fc62: Bug 1295197 - use non-null-checked operator new in xpcom/; r=erahm
Nathan Froyd <froydnj@gmail.com> - Mon, 22 Aug 2016 18:40:10 -0400 - rev 310633
Push 20373 by ryanvm@gmail.com at Tue, 23 Aug 2016 14:12:11 +0000
Bug 1295197 - use non-null-checked operator new in xpcom/; r=erahm The standard placement new function is declared to not throw, which means that, per spec, a null check on its result is required. There are a number of places throughout xpcom/ where we know that we are passing non-null pointers to placement new (and receiving them as a return value), and we are therefore doing useless work performing these null checks. Therefore, we should be using an operator new overload that doesn't require the null check. MFBT has just such an overload, so use that.
f8d33a9752282800cec9eb6e67e967de68e7dcc4: Bug 1295197 - use non-null-checked operator new in xpcom/; r=erahm
Nathan Froyd <froydnj@gmail.com> - Tue, 16 Aug 2016 17:05:39 -0400 - rev 309633
Push 20328 by kwierso@gmail.com at Wed, 17 Aug 2016 05:10:33 +0000
Bug 1295197 - use non-null-checked operator new in xpcom/; r=erahm The standard placement new function is declared to not throw, which means that, per spec, a null check on its result is required. There are a number of places throughout xpcom/ where we know that we are passing non-null pointers to placement new (and receiving them as a return value), and we are therefore doing useless work performing these null checks. Therefore, we should be using an operator new overload that doesn't require the null check. MFBT has just such an overload, so use that.
ef4aaae8d79bb6ca37b88d3440db1247fa10e260: Bug 1294620 - Use infallible XPIDL attribute getters more. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 12 Aug 2016 15:19:29 +1000 - rev 309608
Push 20328 by kwierso@gmail.com at Wed, 17 Aug 2016 05:10:33 +0000
Bug 1294620 - Use infallible XPIDL attribute getters more. r=erahm. This makes a lot of code more compact, and also avoids some redundant nsresult checks. The patch also removes a handful of redundant checks on infallible setters.
1c8384a1cfe69e2990e8797e14f15b5ef175759d: Bug 1294809 - remove cppunittest TestPipe; r=erahm
Nathan Froyd <froydnj@gmail.com> - Mon, 15 Aug 2016 21:31:04 -0400 - rev 309463
Push 20328 by kwierso@gmail.com at Wed, 17 Aug 2016 05:10:33 +0000
Bug 1294809 - remove cppunittest TestPipe; r=erahm We have TestPipes gtests that does the same thing (see the TestPipe2 function and callers) as this test.
b8117f4a3659120291ecbfcc07650fed632dda02: Bug 1291970 (part 2) - Tweak nsCategoryManager memory reporter handling. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 11 Aug 2016 09:29:44 +1000 - rev 309030
Push 20299 by kwierso@gmail.com at Fri, 12 Aug 2016 23:39:35 +0000
Bug 1291970 (part 2) - Tweak nsCategoryManager memory reporter handling. r=erahm. This patch adds an assertion that makes sure that the nsCategoryManager is destroyed after the nsMemoryReporterManager, because bad things would happen otherwise. Also, nsCategoryManager uses manual memory management (it's AddRef/Release are hardwired to always return 2 and 1 respectively) so it doesn't matter if we register it as a strong or weak memory reporter. But it's more common to use RegisterWeakMemoryReporter when the argument is |this|, so this patch does that.
6612a73409a9029aff2461b9ab9f451b4677f51d: Bug 1291970 (part 1) - Use MOZ_MUST_USE in nsMemoryReporterManager. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 04 Aug 2016 12:14:14 +1000 - rev 309029
Push 20299 by kwierso@gmail.com at Fri, 12 Aug 2016 23:39:35 +0000
Bug 1291970 (part 1) - Use MOZ_MUST_USE in nsMemoryReporterManager. r=erahm.
3660839b76ee6d25836b4c3456103d8e7afe053b: Bug 1293603 (part 3) - Remove erroneous NS_METHOD uses in widget/. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 09 Aug 2016 14:03:13 +1000 - rev 308877
Push 20279 by cbook@mozilla.com at Wed, 10 Aug 2016 14:04:43 +0000
Bug 1293603 (part 3) - Remove erroneous NS_METHOD uses in widget/. r=erahm. All these occurrences are for methods declared with NS_IMETHOD, and so they should be NS_IMETHODIMP instead of NS_METHOD.
b09d90288666fb3afb11877fc45527b904ef23db: Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 08 Aug 2016 12:18:10 +1000 - rev 308876
Push 20279 by cbook@mozilla.com at Wed, 10 Aug 2016 14:04:43 +0000
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm. This patch makes most Run() declarations in subclasses of nsIRunnable have the same form: |NS_IMETHOD Run() override|. As a result of these changes, I had to add |override| to a couple of other functions to satisfy clang's -Winconsistent-missing-override warning.
4417b2d37bc5b768181b792daccb56c3d29a5d11: Bug 1293603 (part 1) - Add |override| to CollectReports() declarations missing it. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 08 Aug 2016 11:04:11 +1000 - rev 308875
Push 20279 by cbook@mozilla.com at Wed, 10 Aug 2016 14:04:43 +0000
Bug 1293603 (part 1) - Add |override| to CollectReports() declarations missing it. r=erahm.
746392907239ebc994cefb5bd0aac5d1b92171ac: Bug 1275309 (part 1) - Add a variant of Base64Decode(). r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 04 Aug 2016 11:49:46 +1000 - rev 308752
Push 20266 by cbook@mozilla.com at Tue, 09 Aug 2016 13:49:06 +0000
Bug 1275309 (part 1) - Add a variant of Base64Decode(). r=erahm. This mirrors the changes made to encoding in bug 1273712.
d4130ffb32090902cb050aab0ed302784c39dd2a: Bug 1244306 - Rotate mozlog files within a size limit. r=erahm
Honza Bambas <honzab.moz@firemni.cz> - Fri, 29 Jul 2016 06:51:00 -0400 - rev 307613
Push 20188 by cbook@mozilla.com at Tue, 02 Aug 2016 15:14:32 +0000
Bug 1244306 - Rotate mozlog files within a size limit. r=erahm
8d4f43219dcfeb6b102f974e2617a31c1745a989: Bug 1286016 - Re-organize browser.ini manifests to reflect support files needed by tests in toolkit/mozapps/extensions/test/browser/browser.ini r=erahm
Chris Manchester <cmanchester@mozilla.com> - Wed, 20 Jul 2016 11:47:22 -0700 - rev 305885
Push 20080 by cbook@mozilla.com at Thu, 21 Jul 2016 14:27:27 +0000
Bug 1286016 - Re-organize browser.ini manifests to reflect support files needed by tests in toolkit/mozapps/extensions/test/browser/browser.ini r=erahm MozReview-Commit-ID: Kfn3ApOTXOk
2f8d5f889b47589b79a8ad95456f863c1b83cfb4: Bug 1282185 (part 2) - Fix an assertion failure in DMD. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 13 Jul 2016 19:32:27 +1000 - rev 304946
Push 20000 by cbook@mozilla.com at Thu, 14 Jul 2016 10:07:33 +0000
Bug 1282185 (part 2) - Fix an assertion failure in DMD. r=erahm.
d8e2cf1f7079f756f65654dca128245ddc3d4a6f: Bug 1282185 (part 1) - Remove a bogus assertion in DMD. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 13 Jul 2016 18:10:56 +1000 - rev 304945
Push 20000 by cbook@mozilla.com at Thu, 14 Jul 2016 10:07:33 +0000
Bug 1282185 (part 1) - Remove a bogus assertion in DMD. r=erahm. Since bug 1253512 landed, it's possible for DeadBlocks to lack an allocation stack.
04ee49f5bd4a16e88eefcb1ca8e890274d25593d: Bug 1271751 - part 8 - fix bug in nsTArray_CopyWithConstructors; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:04 -0400 - rev 304275
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 8 - fix bug in nsTArray_CopyWithConstructors; r=erahm The backwards copying case in MoveOverlappingRegion had a bug: rather than destroying each element from the source range as we moved it, we would always destroy the element at the beginning of the source range. Fortunately, none of the existing types that were copied via constructors seem to trigger the problematic code.
acf15b7ae545af2f723a7a15b6a7cde8fa9cf63b: Bug 1271751 - part 7 - remove nsTArray_CopyWith*::Copy*; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:05 -0400 - rev 304274
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 7 - remove nsTArray_CopyWith*::Copy*; r=erahm After all the previous patches, we never call these functions. Any copying required by nsTArray is taken care of by other means.
a4ec59ebd89761e0c4f5e84082740fc28537182c: Bug 1271751 - part 6 - make ShiftData actually move its elements rather than copying; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:05 -0400 - rev 304273
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 6 - make ShiftData actually move its elements rather than copying; r=erahm This change eliminates the last use of the Copy* family of functions.
862be98e16060a61fb36485e5a1243973b1a0dd2: Bug 1271751 - part 5 - use MoveNonOverlappingRegion instead of CopyNonOverlappingRegion; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:05 -0400 - rev 304272
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 5 - use MoveNonOverlappingRegion instead of CopyNonOverlappingRegion; r=erahm In all of the calls to CopyNonOverlappingRegion from within nsTArray, we don't care about the contents of the source afterwards. So we can use moves instead of copies to potentially make things more efficient.
a458e6f337ce9ebbd2c96508d8c05e3a78a14ff7: Bug 1271751 - part 4 - rename CopyNonOverlappingRegionWithHeader to MoveNonOverlappingRegionWithHeader; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:05 -0400 - rev 304271
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 4 - rename CopyNonOverlappingRegionWithHeader to MoveNonOverlappingRegionWithHeader; r=erahm Whenever we're copying the header, we can be guaranteed that we're never going to use the elements from the old array afterward, so can move (in the C++ sense) the elements rather than copying them.
c726b0821954d4df564983e0fd59c97ef1c271d6: Bug 1271751 - part 3 - add Move{Non,}OverlappingRegion; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:05 -0400 - rev 304270
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 3 - add Move{Non,}OverlappingRegion; r=erahm We'll need these for future patches as we transition nsTArray to use moves for most of its operations rather than copies. The implementation of these functions are essentially cut-and-paste versions of the Copy* functions, but using moves.
7247f68ba1108f4d9447536060e0c27463ff78ff: Bug 1271751 - part 2 - rename {Copy,Move}Elements to something more accurate; r=erahm
Nathan Froyd <froydnj@gmail.com> - Fri, 08 Jul 2016 16:59:05 -0400 - rev 304269
Push 19932 by philringnalda@gmail.com at Sat, 09 Jul 2016 16:00:45 +0000
Bug 1271751 - part 2 - rename {Copy,Move}Elements to something more accurate; r=erahm The names {Copy,Move}Elements are based on the use of mem{cpy,move}, respectively. However, I submit that we really want the names to reflect the C++ operations being done, rather than the underlying implementation details. So let's rename these to reflect that we are always copying the elements, and discriminate between the two cases based on whether the regions being copied overlap or not. Bring CopyHeaderAndElements along for the ride, as well.