searching for reviewer(acomminos)
f82c28837b077231726876afb727c3ce3b4f74f3: Bug 1299707 - Disable XInput2 without MOZ_USE_USE_XINPUT2 on content process. r=acomminos
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 07 Oct 2016 12:24:56 +0900 - rev 318294
Push 20716 by cbook@mozilla.com at Tue, 18 Oct 2016 08:45:23 +0000
Bug 1299707 - Disable XInput2 without MOZ_USE_USE_XINPUT2 on content process. r=acomminos Actually, we don't turn of xinput2 on content process. So, although chrome process cannot detect touch screen device, content process can detect it. So if we turn off xinput2 on chrome process, content process should be turned off. MozReview-Commit-ID: 1kfsDBpqhC1
7f526cb5eccf63ce6c997503e23b6825ed2b7ad2: Bug 1299228 - Add nsPIDOMWindow.h header to nsColorPicker.cpp. r=acomminos
Martin Stransky <stransky@redhat.com> - Tue, 30 Aug 2016 10:13:00 -0400 - rev 312616
Push 20451 by philringnalda@gmail.com at Sun, 04 Sep 2016 04:58:29 +0000
Bug 1299228 - Add nsPIDOMWindow.h header to nsColorPicker.cpp. r=acomminos
08698ef52412b19e62284485371b838ed484e96a: Bug 1297845 - Initialize gtk in GPU process. r=acomminos
Ryan Hunt <rhunt@mozilla.com> - Tue, 30 Aug 2016 01:05:00 -0400 - rev 312613
Push 20451 by philringnalda@gmail.com at Sun, 04 Sep 2016 04:58:29 +0000
Bug 1297845 - Initialize gtk in GPU process. r=acomminos MozReview-Commit-ID: EngQvL6h3EU
148543c54d26e4c641d87cb7ce02fe4207fd1e25: Bug 1289251 - Allow GLContextProviderGLX to create a GLContext out of process. r=acomminos,jgilbert
Ryan Hunt <rhunt@mozilla.com> - Mon, 29 Aug 2016 17:14:20 -0700 - rev 312594
Push 20451 by philringnalda@gmail.com at Sun, 04 Sep 2016 04:58:29 +0000
Bug 1289251 - Allow GLContextProviderGLX to create a GLContext out of process. r=acomminos,jgilbert MozReview-Commit-ID: 9AdBGkEzI1n
be4e5ce4a8a4edd40c76b1df76cc8fce765e9655: Bug 1289251 - Create a CompositorWidget for GTK+X11 platform. r=acomminos,jrmuizel
Ryan Hunt <rhunt@mozilla.com> - Fri, 22 Jul 2016 10:23:07 -0700 - rev 312593
Push 20451 by philringnalda@gmail.com at Sun, 04 Sep 2016 04:58:29 +0000
Bug 1289251 - Create a CompositorWidget for GTK+X11 platform. r=acomminos,jrmuizel MozReview-Commit-ID: 1eq3rRwv1g3
2df13967b7466c92cb629e3600a101a1826dfad8: Bug 1289251 - Allow GLContextProviderGLX to create a GLContext out of process. r=acomminos,jgilbert
Ryan Hunt <rhunt@mozilla.com> - Mon, 29 Aug 2016 17:14:20 -0700 - rev 312456
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1289251 - Allow GLContextProviderGLX to create a GLContext out of process. r=acomminos,jgilbert MozReview-Commit-ID: 9AdBGkEzI1n
c0285428a8a04dd0d8f7ad1ed46a2e04147dfbc6: Bug 1289251 - Create a CompositorWidget for GTK+X11 platform. r=acomminos,jrmuizel
Ryan Hunt <rhunt@mozilla.com> - Fri, 22 Jul 2016 10:23:07 -0700 - rev 312455
Push 20447 by kwierso@gmail.com at Fri, 02 Sep 2016 20:36:44 +0000
Bug 1289251 - Create a CompositorWidget for GTK+X11 platform. r=acomminos,jrmuizel MozReview-Commit-ID: 1eq3rRwv1g3
8fe922a0b012ebd840538186f3ef6b193d0cc529: Bug 1271524 - Move tab widget to WidgetCache. r=acomminos
Martin Stransky <stransky@redhat.com> - Sun, 21 Aug 2016 23:13:00 -0400 - rev 310615
Push 20373 by ryanvm@gmail.com at Tue, 23 Aug 2016 14:12:11 +0000
Bug 1271524 - Move tab widget to WidgetCache. r=acomminos
2832042ac206d082cda7a63d15641418e4c54ce5: Bug 1291769 - use correct "checked" state for treeview expanders, r=acomminos
Martin Stransky <stransky@redhat.com> - Wed, 03 Aug 2016 14:53:00 +0200 - rev 308278
Push 20229 by cbook@mozilla.com at Fri, 05 Aug 2016 10:07:54 +0000
Bug 1291769 - use correct "checked" state for treeview expanders, r=acomminos
42ddeb0cbb27113973effc4ed773aa3832836845: Bug 1289763 - Move gImageMenuItemWidget/gCheckMenuItemWidget to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Thu, 28 Jul 2016 03:54:00 +0200 - rev 308276
Push 20229 by cbook@mozilla.com at Fri, 05 Aug 2016 10:07:54 +0000
Bug 1289763 - Move gImageMenuItemWidget/gCheckMenuItemWidget to WidgetCache, r=acomminos
60a5e5073e1fe1783ad792982adba18e2fa0f334: Bug 1289764 - Move gHPanedWidget/gVPanedWidget to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Fri, 29 Jul 2016 05:30:00 +0200 - rev 308275
Push 20229 by cbook@mozilla.com at Fri, 05 Aug 2016 10:07:54 +0000
Bug 1289764 - Move gHPanedWidget/gVPanedWidget to WidgetCache, r=acomminos
cc77bef0fabe7be4854f3c01e1f7462f42ecf622: Bug 1288413 - Move GtkTreeView widgets to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Fri, 29 Jul 2016 05:15:00 +0200 - rev 308274
Push 20229 by cbook@mozilla.com at Fri, 05 Aug 2016 10:07:54 +0000
Bug 1288413 - Move GtkTreeView widgets to WidgetCache, r=acomminos
d2fb36bd0bcf06dc69685bb6770d258f9f4843de: Bug 1291856 - push clip before drawing GTK3 widgets. r=acomminos
Lee Salzman <lsalzman@mozilla.com> - Wed, 03 Aug 2016 20:24:39 -0400 - rev 308154
Push 20219 by cbook@mozilla.com at Thu, 04 Aug 2016 14:06:48 +0000
Bug 1291856 - push clip before drawing GTK3 widgets. r=acomminos MozReview-Commit-ID: 84Y8sBg7NzF
5ad44f0d3ea46981d77e10563fe5c868384bfdc4: Bug 1290048 - Remove gtk_style_context_set_state/gtk_style_context_set_direction after ClaimStyleContext() call. r=acomminos
Martin Stransky <stransky@redhat.com> - Thu, 28 Jul 2016 04:13:00 -0400 - rev 307285
Push 20177 by cbook@mozilla.com at Sat, 30 Jul 2016 14:25:14 +0000
Bug 1290048 - Remove gtk_style_context_set_state/gtk_style_context_set_direction after ClaimStyleContext() call. r=acomminos
8f5b78b3d9189cc84a6f22da08a0683a190112f9: Bug 1288696 - Move MenuSeparatorWidget to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Mon, 25 Jul 2016 05:40:00 +0200 - rev 306694
Push 20117 by cbook@mozilla.com at Tue, 26 Jul 2016 15:07:58 +0000
Bug 1288696 - Move MenuSeparatorWidget to WidgetCache, r=acomminos
cd7544affe40f0ed80059a7b22e2fed6639019d8: Bug 1288412 - Move GtkScrolledWindow to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Mon, 25 Jul 2016 06:46:00 +0200 - rev 306693
Push 20117 by cbook@mozilla.com at Tue, 26 Jul 2016 15:07:58 +0000
Bug 1288412 - Move GtkScrolledWindow to WidgetCache, r=acomminos Land Bug 1282753 before this one.
efb4af0a5b7550d9d2efbb126df62c75a3082be2: Bug 1287085 - Move GtkInfoBar from gtk3drawing to WidgetCache. r=acomminos
Martin Stransky <stransky@redhat.com> - Tue, 19 Jul 2016 00:03:00 -0400 - rev 305916
Push 20080 by cbook@mozilla.com at Thu, 21 Jul 2016 14:27:27 +0000
Bug 1287085 - Move GtkInfoBar from gtk3drawing to WidgetCache. r=acomminos
f4320d509686d6ef91ad4f5fff485adbbad18933: Bug 1287080 - Move Toolbar, Frame and Gripper widgets from gtk3drawing to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Mon, 18 Jul 2016 05:29:00 +0200 - rev 305796
Push 20064 by cbook@mozilla.com at Wed, 20 Jul 2016 09:28:23 +0000
Bug 1287080 - Move Toolbar, Frame and Gripper widgets from gtk3drawing to WidgetCache, r=acomminos
e44c9f57299f408faa824ef26d1020457181080e: Bug 1287082 - Move GtkExpander widget from gtk3drawing.cpp to WidgetCache, r=acomminos
Martin Stransky <stransky@redhat.com> - Mon, 18 Jul 2016 04:27:00 +0200 - rev 305778
Push 20064 by cbook@mozilla.com at Wed, 20 Jul 2016 09:28:23 +0000
Bug 1287082 - Move GtkExpander widget from gtk3drawing.cpp to WidgetCache, r=acomminos
c37c930d089f97e44a3ae9846ac0ffb23e23ac67: Bug 694570 - (3/4) - Stop using libgnome and libgnomeui on Linux. r=acomminos
Oliver Henshaw <oliver.henshaw@gmail.com> - Mon, 20 Jun 2016 08:13:00 +0200 - rev 302150
Push 19716 by cbook@mozilla.com at Tue, 21 Jun 2016 13:43:05 +0000
Bug 694570 - (3/4) - Stop using libgnome and libgnomeui on Linux. r=acomminos (Based on original patch by Chris Coulson.) Replace session management through libgnome with direct use of libSM and libICE. This allows xsmp session restore on gtk2 and gtk3 builds. Changes in behaviour: - It now only sends the "session-save" notification when the save style is SmSaveLocal or SmSaveBoth. Saving internal state with a save style of SmSaveGlobal is actually incorrect. This means that Firefox now distinguishes between a normal session exit and a session exit with session saving enabled. - As "quit-application-requested" might pop up a dialog, it only does this if the interact style is not SmInteractStyleNone - "quit-application-requested" is only sent after sending SmcInteractRequest and receiving an interact message. - It defers closing the connection to the session manager until the destructor, i.e after the "web-workers-shutdown" async shutdown phase completes. This means that firefox shouldn't be killed too early and lose data (*). * It still might be killed prematurely if it takes too long to quit and the session manager decides to timeout, but that's another story.
1cc3aabd11e84921d824ba6126a994102d0bf22e: Bug 694570 (2/2) - Stop using libgnome and libgnomeui on Linux. r=acomminos
Oliver Henshaw <oliver.henshaw@gmail.com> - Fri, 27 May 2016 10:52:00 +0200 - rev 299351
Push 19431 by cbook@mozilla.com at Mon, 30 May 2016 10:25:08 +0000
Bug 694570 (2/2) - Stop using libgnome and libgnomeui on Linux. r=acomminos (Based on original patch by Chris Coulson.) Replace session management through libgnome with direct use of libSM and libICE. This allows xsmp session restore on gtk2 and gtk3 builds. Changes in behaviour: - It now only sends the "session-save" notification when the save style is SmSaveLocal or SmSaveBoth. Saving internal state with a save style of SmSaveGlobal is actually incorrect. This means that Firefox now distinguishes between a normal session exit and a session exit with session saving enabled. - As "quit-application-requested" might pop up a dialog, it only does this if the interact style is not SmInteractStyleNone - "quit-application-requested" is only sent after sending SmcInteractRequest and receiving an interact message. - It defers closing the connection to the session manager until the destructor, i.e after the "web-workers-shutdown" async shutdown phase completes. This means that firefox shouldn't be killed too early and lose data (*). * It still might be killed prematurely if it takes too long to quit and the session manager decides to timeout, but that's another story.
eb8f153723e05479cd76cc2b6486eb2a32e42663: bug 1271893 add a 1.5 pixel-scaling step r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Wed, 11 May 2016 09:21:13 +1200 - rev 297146
Push 19206 by cbook@mozilla.com at Fri, 13 May 2016 10:06:58 +0000
bug 1271893 add a 1.5 pixel-scaling step r=acomminos The only change in behaviour introduced here is that dpi values in the range [144,168) will now use pixel scaling of 1.5 instead of 2. MozReview-Commit-ID: JD6FcZGLYtI
37c815005a7223bb81f947957bd80ae45c26376f: bug 1264170 only add slider class to scale after style save r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Wed, 13 Apr 2016 08:48:15 +1200 - rev 295222
Push 18983 by cbook@mozilla.com at Thu, 28 Apr 2016 14:35:23 +0000
bug 1264170 only add slider class to scale after style save r=acomminos so that ranges don't render like their thumbs MozReview-Commit-ID: KshWxyAb1nh
f7eef7358c99b93677fdd356c0d4cdf1a328f9fe: bug 1261277 use GtkTextView to get an appropriate color for resizers r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Thu, 31 Mar 2016 23:30:12 +1300 - rev 291467
Push 18506 by cbook@mozilla.com at Mon, 04 Apr 2016 10:03:10 +0000
bug 1261277 use GtkTextView to get an appropriate color for resizers r=acomminos MozReview-Commit-ID: IhcjE7Aax8g
323653e6a3d9aee66a5a4bdc8c10c25f8953b523: bug 1260178 null check pattern from -unico-border-gradient r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Tue, 29 Mar 2016 17:50:47 +1300 - rev 290845
Push 18446 by kwierso@gmail.com at Thu, 31 Mar 2016 20:09:54 +0000
bug 1260178 null check pattern from -unico-border-gradient r=acomminos MozReview-Commit-ID: HooAlTmINmq
3a2973be8bbdd9d15fc9f932a942fe9c4c724d5e: bug 1257695 disable GTK3 deprecation warnings in widget/gtk r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Thu, 17 Mar 2016 22:45:01 +1300 - rev 289727
Push 18304 by cbook@mozilla.com at Tue, 22 Mar 2016 11:33:07 +0000
bug 1257695 disable GTK3 deprecation warnings in widget/gtk r=acomminos MozReview-Commit-ID: 4tFJXIfhfTI
ea2b3a89986eacac865dd97b9fd306a275bbe48b: bug 1211892 read -unico-border-gradient of early Unico versions for ThreeDHighlight and ThreeDShadow r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Fri, 18 Mar 2016 22:49:46 +1300 - rev 289578
Push 18283 by cbook@mozilla.com at Mon, 21 Mar 2016 15:02:44 +0000
bug 1211892 read -unico-border-gradient of early Unico versions for ThreeDHighlight and ThreeDShadow r=acomminos MozReview-Commit-ID: KWfQqT5MIjT
fe3b0ce3a5fe3d28313ecd225cd800e45c435a3b: bug 1197165 apply tooltip style class when creating window instead of when drawing r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Wed, 02 Mar 2016 18:04:00 +1300 - rev 286653
Push 18000 by cbook@mozilla.com at Fri, 04 Mar 2016 12:40:23 +0000
bug 1197165 apply tooltip style class when creating window instead of when drawing r=acomminos This is consistent with gtktooltip.c. gtk_style_context_save() modifies the CSS node hierarchy causing this rule to incorrectly match: .tooltip * { background-color: transparent; } See also https://bugzilla.gnome.org/show_bug.cgi?id=761870#c2
8b9251fa3a326b32a98dd5eb65562885b7defca2: bug 1230065 consider arrow size in dropdown minimum widget size r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Tue, 01 Mar 2016 13:12:03 +1300 - rev 286652
Push 18000 by cbook@mozilla.com at Fri, 04 Mar 2016 12:40:23 +0000
bug 1230065 consider arrow size in dropdown minimum widget size r=acomminos
f2f4c8ce77a3c6415ed55740be32dc75187eaaf0: bug 1199602 emit resume-events on GdkFrameClock if flush/resume not balanced at dispose r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Fri, 26 Feb 2016 11:19:24 +1300 - rev 285722
Push 17861 by kwierso@gmail.com at Fri, 26 Feb 2016 21:28:51 +0000
bug 1199602 emit resume-events on GdkFrameClock if flush/resume not balanced at dispose r=acomminos Fixes https://bugzilla.gnome.org/show_bug.cgi?id=742636 in affected GDK versions.
307fa388360994c5515511320df3f2cd6085f3b0: bug 1199602 give existing wrap_gtk_window_check_resize internal linkage r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Wed, 24 Feb 2016 18:42:09 +1300 - rev 285721
Push 17861 by kwierso@gmail.com at Fri, 26 Feb 2016 21:28:51 +0000
bug 1199602 give existing wrap_gtk_window_check_resize internal linkage r=acomminos
0ed4561d22d10665136b7741dfb9adefee23135d: bug 1205199 keep the socket alive as long as the plug window r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Wed, 10 Feb 2016 18:24:40 +1300 - rev 283905
Push 17557 by cbook@mozilla.com at Thu, 11 Feb 2016 10:57:16 +0000
bug 1205199 keep the socket alive as long as the plug window r=acomminos
45a665ae8dc7e96651ad15bfd002a4ca13f04191: bug 1227008 use GtkPaperSize in GtkPageSetup directly, instead of maintaining a separate copy r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Wed, 25 Nov 2015 11:07:21 +1300 - rev 274128
Push 16397 by cbook@mozilla.com at Wed, 25 Nov 2015 12:59:34 +0000
bug 1227008 use GtkPaperSize in GtkPageSetup directly, instead of maintaining a separate copy r=acomminos Fixes a leak in nsPrintSettingsGTK::SetGtkPrintSettings() and missed paper size copy in operator= (bug 965991). GtkPageSetup always has a GtkPaperSize [1], which is returned from gtk_page_setup_get_paper_size() as indicated in the docs [2]: "Return value: the paper size" without "or NULL". [1] https://git.gnome.org/browse/gtk+/tree/gtk/gtkpagesetup.c?h=2.18.0#n68 [2] https://git.gnome.org/browse/gtk+/tree/gtk/gtkpagesetup.c?h=2.18.0#n164
a29828c4d7be167a1334d9de4309057e462edb56: Bug 1205741 - add xpm and svg to supported gdk-pixbuf formats. r=acomminos,dveditz
Lee Salzman <lsalzman@mozilla.com> - Thu, 17 Sep 2015 15:01:51 -0400 - rev 263416
Push 15264 by philringnalda@gmail.com at Sun, 20 Sep 2015 04:09:18 +0000
Bug 1205741 - add xpm and svg to supported gdk-pixbuf formats. r=acomminos,dveditz
71d398b08d25c0bd7ea42377d264443d3c1c973e: Bug 1194397 - Force gdk_window_ensure_native on gdk window creation. r=acomminos
Lee Salzman <lsalzman@mozilla.com> - Tue, 25 Aug 2015 18:42:40 -0400 - rev 259324
Push 14841 by ryanvm@gmail.com at Wed, 26 Aug 2015 04:05:57 +0000
Bug 1194397 - Force gdk_window_ensure_native on gdk window creation. r=acomminos
10e77092a656b4800876c0233e2a188cf6f9eb6a: Bug 1184009 - Limit gtk file picker preview source sizes. r=acomminos
Lee Salzman <lsalzman@mozilla.com> - Fri, 07 Aug 2015 12:24:22 -0400 - rev 257156
Push 14593 by ryanvm@gmail.com at Tue, 11 Aug 2015 14:59:44 +0000
Bug 1184009 - Limit gtk file picker preview source sizes. r=acomminos
43e50f129af4ec22db4810366b8aa281c4aaed84: Bug 1184009 - Limit image preview sizes. r=acomminos
Lee Salzman <lsalzman@mozilla.com> - Tue, 21 Jul 2015 13:16:44 -0400 - rev 254224
Push 14188 by cbook@mozilla.com at Thu, 23 Jul 2015 11:47:18 +0000
Bug 1184009 - Limit image preview sizes. r=acomminos
082dc52f03763545a22f495a221b969f2decefef: bug 1182972 no need to pass member variable bounds to NativeResize r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Tue, 14 Jul 2015 15:24:56 +1200 - rev 252941
Push 14035 by ryanvm@gmail.com at Wed, 15 Jul 2015 17:30:16 +0000
bug 1182972 no need to pass member variable bounds to NativeResize r=acomminos
cb0eda54dfab0071dfb6a5f5580ce47b79085f04: bug 1182972 remove mNeedsMove/mNeedsResize logic; instead process changes immediately r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Tue, 14 Jul 2015 15:23:47 +1200 - rev 252940
Push 14035 by ryanvm@gmail.com at Wed, 15 Jul 2015 17:30:16 +0000
bug 1182972 remove mNeedsMove/mNeedsResize logic; instead process changes immediately r=acomminos
9f74cd3a13b426173135097f541ba26998e3ce5a: bug 1182972 create NativeMove helper method r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Mon, 13 Jul 2015 14:29:05 +1200 - rev 252939
Push 14035 by ryanvm@gmail.com at Wed, 15 Jul 2015 17:30:16 +0000
bug 1182972 create NativeMove helper method r=acomminos
842bb09eade83a696cb82e28a01c586e93f9e022: bug 1182972 remove unused aRepaint parameter from NativeResize methods r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Mon, 13 Jul 2015 13:57:23 +1200 - rev 252938
Push 14035 by ryanvm@gmail.com at Wed, 15 Jul 2015 17:30:16 +0000
bug 1182972 remove unused aRepaint parameter from NativeResize methods r=acomminos
7afaa79f611e6e97796abbba3a1634dff0a55fb9: bug 1180008 don't measure size of decorations for override-redirect windows r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Tue, 21 Apr 2015 19:52:00 +1200 - rev 251449
Push 13864 by cbook@mozilla.com at Mon, 06 Jul 2015 11:07:39 +0000
bug 1180008 don't measure size of decorations for override-redirect windows r=acomminos
14c98ce60b8ad94efe0f80ab07683f30989609bd: bug 1180008 use mGdkWindow instead of finding it from gtk_widget_get_window(mShell) r=acomminos
Karl Tomlinson <karlt+@karlt.net> - Tue, 21 Apr 2015 19:06:41 +1200 - rev 251448
Push 13864 by cbook@mozilla.com at Mon, 06 Jul 2015 11:07:39 +0000
bug 1180008 use mGdkWindow instead of finding it from gtk_widget_get_window(mShell) r=acomminos Since https://hg.mozilla.org/mozilla-central/rev/9541dbf6e020#l2.184 there is only one GdkWindow per nsWindow. The mGdkWindow pointer is cleared in OnContainerUnrealize() before the shell widget destruction completes: https://hg.mozilla.org/mozilla-central/annotate/50b95032152c/widget/gtk/nsWindow.cpp#l2480