fb7655f3e1cf3bf9635da9e434eb7da6cf6800f9: Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319893
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats Right now, this method has only one stub impl, in nsContainerFrame; a later patch will add a more interesting (overriding) impl in nsFlexContainerFrame. MozReview-Commit-ID: 3U3vTTX4vdm
8088e5a9e6e322731d4a3008642b54a1fc0774b1: Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319892
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats (We'll react to the ReflowInput flags and do the actual CSS Box Alignment in a later patch in this series.) MozReview-Commit-ID: EZd7npWSzQI
eea6479452f0be2d7ee98f6d537106f6fe8a0d50: Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319891
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats MozReview-Commit-ID: GZ35iZ2E1Iz
eb4b52bf06ec8c1f5b33cfba7255a0d4bb64c168: Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319890
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats MozReview-Commit-ID: 5tvCIEhAsPH
539db74e4a889a6dc0605f91ff40ab7e748b996d: Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319889
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats MozReview-Commit-ID: 1Eh2CreOLTC
f57f9ac1435edc2d581c4645fa818ffd665d68f7: Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319888
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats MozReview-Commit-ID: 5rGemcMMOhl
2162d5c9fb54f3e1b993add441287216534b0b9c: Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319887
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats This patch also: * Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore. * Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly). MozReview-Commit-ID: 8canWfXk6Kf
7aa8199183fca08ca7d9b309fa01580affb45da7: Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319886
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats MozReview-Commit-ID: 5lXUsusLryC
86a391e3e1638407465610b0dc5b5fc4694a0a08: Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:25 -0700 - rev 319885
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats This patch makes the following specific changes: (1) Adds an early-return to both versions of the IsOrderLEQ function, to treat placeholder children as LEQ everything (including each other). This will tend to sort them to the beginning of the child list, which is unimportant but fine. More importantly, though: this means our "order"-sorting code won't reorder placeholders *with respect to each other* (since our sort algorithm is stable). So their painting order won't be affected by the "order" property, which is required by the spec. (2) Drops some nsPlaceholderFrame::GetRealFrameFor() calls -- they're unnecessary, since any placeholder frames will have prompted us to return earlier. One caveat to (2): this patch does leave a few "nsPlaceholderFrame::GetRealFrameFor()" calls in place, *for the moment*. These remaining calls are for handling placeholders that are wrapped, i.e. inside of anonymous flex items. These calls are still needed to avoid assertion-failures (i.e. to get a consistent ordering) at this point, but they'll be removed in a later patch in this same bug, when we stop wrapping placeholders in anonymous flex items. MozReview-Commit-ID: 1R6NW30Kxgv
1658a195f669351b5f6caf5dbafdb0b4b12a6c2c: Bug 1313421 part 3: Extend single-flex-item reftest to test scenario with abspos child before flex item.
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:49 -0700 - rev 319884
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313421 part 3: Extend single-flex-item reftest to test scenario with abspos child before flex item. (This modified testcase fails unless we have both this bug's patches and bug 1269045's patches, and it's annotated accordingly.) MozReview-Commit-ID: 76ky8OIpV3a
ae632144724fc5efae24a32acab2d7d938384123: Bug 1313421 part 2: Use flex container's FlexLine linked-list to determine the first flex item, rather than its child-frame list. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:48 -0700 - rev 319883
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313421 part 2: Use flex container's FlexLine linked-list to determine the first flex item, rather than its child-frame list. r=mats This shouldn't change our behavior right now, but it will make a difference after bug 1269045 -- when that bug lands, we'll have nsPlaceholderFrames (which are not flex items) in the child-frame list, which means we can't depend on its first entry being a flex item anymore. MozReview-Commit-ID: KRXYaK8R8bc
c565ba669d962165dc90b99f77b0b26d4acb4d92: Bug 1313421 part 1: Unconditionally cache a FlexItem's ascent, after it's been reflowed. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:41 -0700 - rev 319882
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313421 part 1: Unconditionally cache a FlexItem's ascent, after it's been reflowed. r=mats This removes a (very minor) optimization. The optimization was simply that we avoided storing this nscoord value, if we could tell that we weren't ever going to need it. Now it's becoming a bit more complicated to prove that we'll never need it, so we might as well just store it unconditionally. MozReview-Commit-ID: 94FFc9SO516
1145a10a2fd5e23d0191ae9e1c22a6fa6e47ec0a: Backed out changeset 582e5f96a727 (bug 1262251) for Linux serviceworker bustage
Phil Ringnalda <philringnalda@gmail.com> - Thu, 27 Oct 2016 18:50:12 -0700 - rev 319881
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Backed out changeset 582e5f96a727 (bug 1262251) for Linux serviceworker bustage
e84c02971f372880904cdd7456bb895f00604ecd: Bug 1313375 - Fix nsDeviceContext::IsPrinterSurface() to not fail between BeginPage()/EndPage() calls. r=mstange
Jonathan Watt <jwatt@jwatt.org> - Mon, 24 Oct 2016 13:58:20 +0100 - rev 319880
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313375 - Fix nsDeviceContext::IsPrinterSurface() to not fail between BeginPage()/EndPage() calls. r=mstange
04ee6f23fb6f13061acad21a0e57b1a0f7664615: Bug 1313381 - Add assertions to nsDeviceContext to assert that it is only initialized once. r=mstange
Jonathan Watt <jwatt@jwatt.org> - Fri, 21 Oct 2016 20:39:11 +0100 - rev 319879
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313381 - Add assertions to nsDeviceContext to assert that it is only initialized once. r=mstange
da1c0184e9f51860b8ac0b75c78bb30ddeed473c: Bug 1309397 - Remove nsIPrintOptions::ShowPrintSetupDialog. r=vlad, f=myk
Jonathan Watt <jwatt@jwatt.org> - Tue, 11 Oct 2016 16:32:57 +0100 - rev 319878
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1309397 - Remove nsIPrintOptions::ShowPrintSetupDialog. r=vlad, f=myk
a8c8bb56737d5f5407d80c731bfe70fa3cba7f77: Bug 1313426 - gecko decision task: ValueError: No JSON object. fix SETA. r=dustin on a CLOSED TREE
Joel Maher <jmaher@mozilla.com> - Thu, 27 Oct 2016 15:12:33 -0400 - rev 319877
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1313426 - gecko decision task: ValueError: No JSON object. fix SETA. r=dustin on a CLOSED TREE MozReview-Commit-ID: F4V3VcDHMnW
a1ea2703d9e81330c261846575016399e01ba893: Bug 1203813 - Make nsHelperAppDlg dialog be parented by top-level nsIDOMWindow. r=mrbkap
Mike Conley <mconley@mozilla.com> - Thu, 27 Oct 2016 02:47:32 -0400 - rev 319876
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1203813 - Make nsHelperAppDlg dialog be parented by top-level nsIDOMWindow. r=mrbkap MozReview-Commit-ID: LUK01OptZgG
582e5f96a727af4a6da4ec26dbe882ef57914bfb: Bug 1262251 - Make openWindow() launch Fennec if it isn't already running. r=catalinb
Dylan Roeh <droeh@mozilla.com> - Thu, 27 Oct 2016 13:58:39 -0500 - rev 319875
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
Bug 1262251 - Make openWindow() launch Fennec if it isn't already running. r=catalinb
d1e487f723a0154cbd9752f37fcbaebf17cbcf1c: bug 1303447 - implement text interface methods for the windows ProxyAccessible r=aklotz
Michael Li <michael.li11702@gmail.com> - Tue, 18 Oct 2016 10:13:10 -0400 - rev 319874
Push 20749 by ryanvm@gmail.com at Sat, 29 Oct 2016 13:21:21 +0000
bug 1303447 - implement text interface methods for the windows ProxyAccessible r=aklotz
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 tip