e646421ae23162e96138ae2a4ffd12ba75d66daa: Bug 1239945 part 7 - Move GetAnimationCollection to AnimationCollection; r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 09 Mar 2016 12:55:39 +0900 - rev 287438
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1239945 part 7 - Move GetAnimationCollection to AnimationCollection; r=dholbert By moving GetAnimationCollection to AnimationCollection itself, we can remove a bunch of virtual methods on the animation managers, simplify call sites, and provide better type safety by ensuring a correspondence between element property names and concrete animation types. One change in behavior, however, is that in doing this we can no longer add any newly-created AnimationCollection to the corresponding manager's linked list of collections inside GetAnimationCollection. Instead we take a bool outparam to indicate if a new collection was created and leave managing the linked list to the manager. This is just a temporary measure, however, since by the end of this patch series will will eliminate this linked list altogether along with this flag. MozReview-Commit-ID: 1jsc4QcmVDg
565778f033af09449a9f860b9608114d7ad83055: Bug 1239945 part 6 - Templatize AnimationCollection based on the concrete type of Animation stored; r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 09 Mar 2016 12:55:39 +0900 - rev 287437
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1239945 part 6 - Templatize AnimationCollection based on the concrete type of Animation stored; r=dholbert This patch templatizes the type of Animation stored in an AnimationCollection. This allows us to remove a number AsCSSAnimation() calls in nsAnimationManager. This patch also removes the AnimationPtrArray typedef. In its place we introduce OwningCSSAnimationPtrArray and OwningCSSTransitionPtrArray but we don't use these as widely. There was some comment previously that the typedefs in animation code make it hard to read, particularly when these typedefs don't make it clear if the data type is an owning reference or not. In doing this we need to templatize CommonAnimationManager as well and move the implementation of its (few) methods to the header file. We may be able to remove the need for templatizing CommonAnimationManager later in this patch series depending on how we ultimately decide to handle the lifetime of AnimationCollection objects. CommonAnimationManager::GetAnimationCollection is a bit messy but this will be significantly tidied up in subsequent patches in this series. MozReview-Commit-ID: 3ywatY53pRR
bf22fcece06e85cd195d61e37382ffc0084e4d05: Bug 1252639 (part 2) - Move contents of plarenas.h into plarena.h. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 04 Mar 2016 10:36:51 +1100 - rev 287436
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1252639 (part 2) - Move contents of plarenas.h into plarena.h. r=glandium. Because the plarenas.h/plarena.h is strange and confusing. But the patch keeps plarenas.h around in a way that the API doesn't change -- any code that included plarena.h or plarenas.h should not need changing.
c661f2c5cd878c26e25abc0256b4893d8a249b49: Bug 1252639 (part 1) - Remove the shared PLArena freelist. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 04 Mar 2016 10:35:13 +1100 - rev 287435
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1252639 (part 1) - Remove the shared PLArena freelist. r=glandium. It's not useful and just adds complexity.
b7fd5da36595139efc6d103249b36a5338d0efb9: Bug 1243734 - Part 5. Add MOZ_ENABLE_MASK_AS_SHORTHAND compile flag; r=ted r=dbaron
CJKu <cku@mozilla.com> - Wed, 09 Mar 2016 11:15:09 +0800 - rev 287434
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1243734 - Part 5. Add MOZ_ENABLE_MASK_AS_SHORTHAND compile flag; r=ted r=dbaron MozReview-Commit-ID: 8KbrEXnJqlp
80c6c41be91f61216dac8e3394e17b694496f267: Back out 3 changesets (bug 1250616, bug 1251372) for failing browser_checkAddonCompatibility.js after the version bump
Phil Ringnalda <philringnalda@gmail.com> - Tue, 08 Mar 2016 19:04:46 -0800 - rev 287433
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Back out 3 changesets (bug 1250616, bug 1251372) for failing browser_checkAddonCompatibility.js after the version bump CLOSED TREE Backed out changeset 4fa5b5a25f04 (bug 1251372) Backed out changeset 502cf531ec26 (bug 1250616) Backed out changeset 2f25d03334b2 (bug 1250616)
c575320f1d603d726cabb777d522e12b647018d8: Bug 1253989 Part 6 - Refactor open_test_html(). r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Mar 2016 22:45:47 +0800 - rev 287432
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253989 Part 6 - Refactor open_test_html(). r=mtseng MozReview-Commit-ID: 2VY1GnVF7Jx
ba096724ac7ce2bed4741b3b68668e924552db61: Bug 1253989 Part 5 - Remove touch caret and selection carets naming. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Mar 2016 22:45:47 +0800 - rev 287431
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253989 Part 5 - Remove touch caret and selection carets naming. r=mtseng - To avoid confusion, call the blinking cursor (nsCaret) "cursor" so that AccessibleCaret can be called caret for short. - Add second_caret_location() as a helper function, and use it in selection mode tests. MozReview-Commit-ID: IKN6KuR92HE
c0fdb08d2254c5c75e7173233f4d2decabf23738: Bug 1253989 Part 4 - Rename AccessibleCaret test files. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Mar 2016 22:45:47 +0800 - rev 287430
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253989 Part 4 - Rename AccessibleCaret test files. r=mtseng Remove "touch caret" and "selection carets" from file names and titles. MozReview-Commit-ID: KqjYE7tiqXd
2693625a55e044fac5ae200e424bed98abca7047: Bug 1253989 Part 3 - Use @parameterized to rewrite selection mode tests. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Mar 2016 22:21:31 +0800 - rev 287429
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253989 Part 3 - Use @parameterized to rewrite selection mode tests. r=mtseng * Inline some of the open_*_html methods since they're called only once. * Save test running time by finding the elements needed in tests instead of find all of the elements in open_*_html methods. * Remove test_long_press_to_select_non_selectable_word() since it's covered by test_focus_not_changed_by_long_press_on_non_selectable(). * Use hyphen for element ids. * Replace "left" and "right" caret by "first" and "second" caret, respectively. MozReview-Commit-ID: Ey5m5zO3HYc
dc451d25f1238c5a7573d891cc1eee70c3f6294b: Bug 1253989 Part 2 - Use @parameterized to rewrite cursor mode tests. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Mar 2016 22:21:31 +0800 - rev 287428
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253989 Part 2 - Use @parameterized to rewrite cursor mode tests. r=mtseng Remove _test_touch_caret_hides_after_receiving_wheel_event() completely since it was a test only for touch caret, which is a leftover in bug 1221459. MozReview-Commit-ID: 4szwuG6t5SF
864342da6536da575b628a49d81bd396e481924e: Bug 1253989 Part 1 - Remove tests for accessiblecaret preference off. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Mar 2016 22:21:30 +0800 - rev 287427
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253989 Part 1 - Remove tests for accessiblecaret preference off. r=mtseng I don't feel these tests are helpful. It's unlikely that someone will accidentally turn on AccessibleCaret on desktop platforms without being noticed. Remove these tests also reduces the test running time. MozReview-Commit-ID: 33RQQSy77gZ
74c384246dccf7ff973d695191af1851fc13aa01: No bug - Fixup whitespaces in build/moz.configure/{init,old}.configure. r=me
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Mar 2016 11:39:18 +0900 - rev 287426
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
No bug - Fixup whitespaces in build/moz.configure/{init,old}.configure. r=me
dce8cc239a84080ea12cfee1fdaba75f13ef02bc: Bug 1250109 - Change DOMEventTargetHelper subclasses to not assume that GetOwner() is non-null, since it can be nulled out by navigation. r=bzbarsky
Michelangelo De Simone <michelangelo@mozilla.com> - Fri, 04 Mar 2016 13:37:50 -0800 - rev 287425
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1250109 - Change DOMEventTargetHelper subclasses to not assume that GetOwner() is non-null, since it can be nulled out by navigation. r=bzbarsky MozReview-Commit-ID: 8EGB58FWLi2
fd6bbe2b188e175c411e1f30ea598161b296a553: Bug 1252015 - Change mImageContent reference to be Element type instead of nsIContent. r=baku
Stephan Leroux <sleroux@mozilla.com> - Thu, 03 Mar 2016 12:55:54 -0500 - rev 287424
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1252015 - Change mImageContent reference to be Element type instead of nsIContent. r=baku MozReview-Commit-ID: 9Mwhgg5ADmY
13462856bcc54369a5495b1ef2113745ce8475e4: Bug 1253593 - Fix applicationCache.onchecking notification on e10s. r=jduell
Honza Bambas <honzab.moz@firemni.cz> - Sat, 05 Mar 2016 07:28:00 -0500 - rev 287423
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253593 - Fix applicationCache.onchecking notification on e10s. r=jduell
c12df2e6a862b538eec3432f5cd5c93cebd43b53: Bug 1112499 - Set up shutdown pipe before new thread starts. r=keeler
Daniel Stenberg <daniel@haxx.se> - Fri, 26 Feb 2016 14:29:00 -0500 - rev 287422
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1112499 - Set up shutdown pipe before new thread starts. r=keeler
73c0af3f36939971564f1210aeee2cfbbfddc3b0: Bug 1251855 - Adjust expected results if RELEASE_BUILD is set. r=bz
Ryan VanderMeulen <ryanvm@gmail.com> - Sat, 05 Mar 2016 16:41:44 -0500 - rev 287421
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1251855 - Adjust expected results if RELEASE_BUILD is set. r=bz
0851150ccf6ed9f42175f6fa44922931bb49aac6: Bug 1253849 - Tweak some reftest annotations.
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 08 Mar 2016 21:23:17 -0500 - rev 287420
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 1253849 - Tweak some reftest annotations.
d5b703a8210f22809087feea1d0df54b70749a44: Bug 963238: Fix compilation errors. r=me
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 09 Mar 2016 13:32:02 +1100 - rev 287419
Push 18088 by cbook@mozilla.com at Wed, 09 Mar 2016 10:48:42 +0000
Bug 963238: Fix compilation errors. r=me MozReview-Commit-ID: K08L6G4F47P
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip